Your message dated Sun, 6 Aug 2017 00:20:52 +0100 with message-id <c9f6d12b-f83e-62bd-71c5-e6bd8747f...@gmail.com> and subject line Re: Bug#866303: guidedog: maintainer script(s) not using strict mode has caused the Debian Bug report #866303, regarding guidedog: maintainer script(s) not using strict mode to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 866303: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=866303 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: guidedog Version: 1.2.0-3+b1 Severity: normal User: trei...@debian.org Usertags: colis-shparser Dear maintainer, at least one of the maintainer scripts (preinst, postinst, prerm, postrm) of the package guidedog does not use strict mode. Policy section 10.4 says: "Shell scripts (sh and bash) [..] should almost certainly start with set -e so that errors are detected." "Every script should use set -e or check the exit status of every command." Please insert a "set -e" at the beginning of your script to enable strict mode. You should not replace this by a first line "#!/bin/sh -e" as it is not effective when your script is executed by an explicit invocation of sh. Note that this might make your script fail in cases where it did not fail before. This is the purpose of strict mode - make it fail when any unexpected error is encountered. You should make sure that you catch any error (non-zero exit codes of commands) that you decide to tolerate. Techniques to locally catch an error include using appropriate options to your command when available, adding a " || true" at the end of the command, or selectively switching off strict mode by "set +e" and switching it back on again later by "set -e". This bug filing has been discussed and approved in thread [1]. -Ralf. [1] https://lists.debian.org/debian-devel/2017/06/msg00342.html
--- End Message ---
--- Begin Message ---Hello, This bug has been fixed. Thank you ----------------------------------------- Antonio Cardoso Martins digiplan...@gmail.com antonio.mart...@sectra.com Homepage: http://digiplan.eu.org Linkedin: http://pt.linkedin.com/in/digiplan Facebook: http://www.facebook.com/digiplan.pt ----------------------------------------- On 28-06-2017 20:02, trei...@debian.org wrote: > Package: guidedog > Version: 1.2.0-3+b1 > Severity: normal > User: trei...@debian.org > Usertags: colis-shparser > > Dear maintainer, > > at least one of the maintainer scripts (preinst, postinst, prerm, > postrm) of the package guidedog does not use strict mode. Policy > section 10.4 says: > > "Shell scripts (sh and bash) [..] should almost certainly start with > set -e so that errors are detected." > > "Every script should use set -e or check the exit status of every > command." > > Please insert a "set -e" at the beginning of your script to enable > strict mode. You should not replace this by a first line "#!/bin/sh > -e" as it is not effective when your script is executed by an > explicit invocation of sh. > > Note that this might make your script fail in cases where it did not > fail before. This is the purpose of strict mode - make it fail when > any unexpected error is encountered. You should make sure that you > catch any error (non-zero exit codes of commands) that you decide to > tolerate. Techniques to locally catch an error include using > appropriate options to your command when available, adding a " || > true" at the end of the command, or selectively switching off strict > mode by "set +e" and switching it back on again later by "set -e". > > This bug filing has been discussed and approved in thread [1]. > > -Ralf. > > [1] https://lists.debian.org/debian-devel/2017/06/msg00342.html >
--- End Message ---
