Your message dated Sun, 06 Aug 2017 22:23:13 +0000
with message-id <e1detx3-0006a8...@fasolo.debian.org>
and subject line Bug#829266: fixed in libldm 0.2.3-5
has caused the Debian Bug report #829266,
regarding libldm: Fix for uninitialized variable, seen when building with -O3
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
829266: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=829266
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: libldm
Version: 0.2.3-4
Severity: minor
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu yakkety ubuntu-patch

Hi Hilko,

libldm version 0.2.3-4 failed to build in Ubuntu on the ppc64el
architecture, with an uninitialized variable error:

 libtool: link: ( cd ".libs" && rm -f "libldm-1.0.la" && ln -s 
"../libldm-1.0.la" "libldm-1.0.la" )
 gcc -DHAVE_CONFIG_H -I. -I..   -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Werror 
-Wshadow -Wextra -Wno-unused-local-typedefs -Wno-unused-parameter 
-I/usr/include/glib-2.0 -I/usr/lib/powerpc64le-linux-gnu/glib-2.0/include 
-pthread -I/usr/include/json-glib-1.0 -I/usr/include/glib-2.0 
-I/usr/lib/powerpc64le-linux-gnu/glib-2.0/include -pthread 
-I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 
-I/usr/lib/powerpc64le-linux-gnu/glib-2.0/include -g -O3 
-fstack-protector-strong -Wformat -Werror=format-security -c -o 
ldmtool-ldmtool.o `test -f 'ldmtool.c' || echo './'`ldmtool.c
 ldmtool.c: In function ‘shell’:
 ldmtool.c:642:12: error: ‘result’ may be used uninitialized in this function 
[-Werror=maybe-uninitialized]
          if (result) json_builder_reset(jb);
             ^
 cc1: all warnings being treated as errors
 make[3]: *** [ldmtool-ldmtool.o] Error 1

(https://launchpadlibrarian.net/257939759/buildlog_ubuntu-yakkety-ppc64el.libldm_0.2.3-4_BUILDING.txt.gz)

The attached patch has been applied in Ubuntu to fix this build failure. 
Please consider applying it in Debian as well (and/or forwarding it
upstream); it doesn't directly impact Debian builds, but is still "correct"
and improves compatibility if anyone does want to build the Debian package
with -O3.

Cheers,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slanga...@ubuntu.com                                     vor...@debian.org
diff -Nru libldm-0.2.3/debian/patches/series libldm-0.2.3/debian/patches/series
--- libldm-0.2.3/debian/patches/series	2014-06-13 14:04:15.000000000 -0700
+++ libldm-0.2.3/debian/patches/series	2016-07-01 09:41:41.000000000 -0700
@@ -4,3 +4,4 @@
 0004-Don-t-call-g_type_init-when-compiling-with-newer-gli.patch
 0005-Cast-result-of-be64toh-to-uint64_t.patch
 0006-Avoid-shadowing-error-on-mips.patch
+uninitialized_variables.patch
diff -Nru libldm-0.2.3/debian/patches/uninitialized_variables.patch libldm-0.2.3/debian/patches/uninitialized_variables.patch
--- libldm-0.2.3/debian/patches/uninitialized_variables.patch	1969-12-31 16:00:00.000000000 -0800
+++ libldm-0.2.3/debian/patches/uninitialized_variables.patch	2016-07-01 09:52:09.000000000 -0700
@@ -0,0 +1,19 @@
+Author: Steve Langasek <steve.langa...@ubuntu.com>
+Description: Fix build failure due to possible uninitialized variable
+ When building with -O3, as we do on ppc64el in Ubuntu, gcc is more
+ aggressive about detecting uninitialized variables.  Set a default value
+ for this (presumed) false-positive.
+
+Index: libldm-0.2.3/src/ldmtool.c
+===================================================================
+--- libldm-0.2.3.orig/src/ldmtool.c
++++ libldm-0.2.3/src/ldmtool.c
+@@ -624,7 +624,7 @@
+         history_len++;
+         free(line);
+ 
+-        gboolean result;
++        gboolean result = FALSE;
+         if (!do_command(ldm, argc, argv, &result, out, jg, jb)) {
+             if (g_strcmp0("quit", argv[0]) == 0 ||
+                 g_strcmp0("exit", argv[0]) == 0)

--- End Message ---
--- Begin Message ---
Source: libldm
Source-Version: 0.2.3-5

We believe that the bug you reported is fixed in the latest version of
libldm, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 829...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Hilko Bengen <ben...@debian.org> (supplier of updated libldm package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 07 Aug 2017 00:01:48 +0200
Source: libldm
Binary: libldm-dev libldm-dbg libldm-1.0-0 ldmtool
Architecture: source
Version: 0.2.3-5
Distribution: unstable
Urgency: medium
Maintainer: Hilko Bengen <ben...@debian.org>
Changed-By: Hilko Bengen <ben...@debian.org>
Description:
 ldmtool    - tool for managing Microsoft Windows dynamic disks
 libldm-1.0-0 - library for managing Microsoft Windows dynamic disks
 libldm-dbg - Debug symbols for libldm
 libldm-dev - library for managing Microsoft Windows dynamic disks
Closes: 829266 853496
Changes:
 libldm (0.2.3-5) unstable; urgency=medium
 .
   * Add patch to fix FTBFS with GCC 7 (Closes: #853496)
   * Add patch to fix uninitialized variable error, thanks to Steve Langasek
     (Closes: #829266)
   * Modernize package: Bump Standards-Version, Debhelper compat level
Checksums-Sha1:
 e3d013b114af25e43d98fd413095fc932f642756 2105 libldm_0.2.3-5.dsc
 e737033d690cd8a7a86a74fc67801609103acd51 5280 libldm_0.2.3-5.debian.tar.xz
 2cf9408ae3660f72af4de96e740ce40658bb1b52 7568 libldm_0.2.3-5_source.buildinfo
Checksums-Sha256:
 0b8817e9c87007794f26d29c8cb02840fe2d00b632d4567ba3266f1e02d9792b 2105 
libldm_0.2.3-5.dsc
 d8504e4f8b4693618a2278f048716084acc1ba83bd6c068aec3d6b3895b2746e 5280 
libldm_0.2.3-5.debian.tar.xz
 db59c7778970859d5c45b986b027126d2d2aa411997be2cec94352478bba90fd 7568 
libldm_0.2.3-5_source.buildinfo
Files:
 3ff700f238a8f0180482958e305e5b6d 2105 libs extra libldm_0.2.3-5.dsc
 fc3cf9be2db69e7f94506da403fc1622 5280 libs extra libldm_0.2.3-5.debian.tar.xz
 da8f40bb898a18e2790dd5ffa8501e68 7568 libs extra 
libldm_0.2.3-5_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEErnMQVUQqHZbPTUx4dbcQY1whOn4FAlmHkpMACgkQdbcQY1wh
On616Q/8D4I3ihVbJf0jICTUTAXkBPQL2IW3nveIO6AjKd1PqfmlU8iKdW0TwQEm
R2jA+p1wC0DVZqkxsgAqH2Sjrd02gvTXDWZdFc7h4GhPSMTKRFCO718MLVtJmGXV
PYdkaY/+UE4dpB9hOiS1x01MoHQJexLPSgbM7/QWAdCxhEa/pCsXqCYTZvESleOD
MMpwJxP/1pHKCnoTNBZZVy1G1szm7utKcxEKbwdZLTODRwVGebD1H4omgnNKHqy6
qDurljofEUI1dmGXFog0CWaJCFAxsrEnbUc1BGqMh11Mn4CLaULvUGKB9WO/a8sX
H3hsj+V01GnvllD15OQJvnGkQUx1Crn0x9oaj01FuW0J11Z3d1aop4KKsgL6400y
UYEpLwHCUIyIhRcoif6U4HBgqw5gH4SlH2wRqzRu9nwbWlgUhF/xfV41WK+u7G3C
6FkW55/NJSk14PcRdq9GHM25+spyIcH4BscEZO80HiyP3brwfVWA7MwJwfwHluJu
uhNGwg9WSVKEUHVOCOjeZFHjZgY8r9FfavcvQfrH42D01+37XEVHaxbWX3ceOT7A
10XCFxPm5jvgHfHwxdRUU0GotU14c7cHsmYOWQadLp5oYqQTPc3nQOKZNo5AEKqU
Qc8TRQt5fLeuMlNi5iGgWY6QEQ6D4yeQfhyejTBQkbGB0QkM9MM=
=ymst
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to