Your message dated Wed, 9 Aug 2017 11:03:31 -0400
with message-id 
and subject line Re: emacs25: Logic for "nocheck" is inverted in debian/rules
has caused the Debian Bug report #868856,
regarding emacs25: Logic for "nocheck" is inverted in debian/rules
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact

Debian Bug Tracking System
Contact with problems
--- Begin Message ---
Source: emacs25
Version: 25.2+1-2
Severity: serious
Justification: builds without testsuite


I'm not 100% sure whether this bug warrents the severity serious, but
since running the testsuites is normally mandatory on all release
architectures, I figured the priority should be high.  Feel free to
downgrade the severity if necessary.

The debian/rules of emacs25 has:

ifneq (,$(filter nocheck, $(DEB_BUILD_OPTIONS)))
        $(MAKE) -C debian/build-lucid check
        $(MAKE) -C debian/build-nox check
        $(MAKE) -C debian/build-x check

This reads as "if DEB_BUILD_OPTIONS contains 'nocheck' don't run the
testsuite". This is, of course, wrong. It should be the other way
around, i.e. the testsuite should be run by default and be disabled
if "nocheck" is found in DEB_BUILD_OPTIONS. The fix is trivial:
Just replace the "ifneq" with "ifeq".

On a sidenote: I did that and noticed that the testsuite actually
fails. If that is the original reason for this bug, I would like
to ask to either temporarily comment out the section above or
disable the individual tests which are failing.

Either way, passing "nocheck" should never run the testsuite.


 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer -
`. `'   Freie Universitaet Berlin -
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

--- End Message ---
--- Begin Message ---
Wrong bug number mentioned in changelog but this should be fixed now.

emacs25 (25.2+1-3) unstable; urgency=medium
   * Actually run tests by default (fix DEB_BUILD_OPTIONS nocheck test)
     Fix the inverted logic.  Thanks to John Paul Adrian Glaubitz for
     reporting the problem.  (Closes: 869328)

--- End Message ---

Reply via email to