Your message dated Tue, 15 Aug 2017 13:04:10 +0000
with message-id <[email protected]>
and subject line Bug#871833: fixed in conntrack-tools 1:1.4.4+snapshot20161117-6
has caused the Debian Bug report #871833,
regarding conntrack-tools: Fix autopkgtests for compatibility with Ubuntu
kernel, containers
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
871833: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=871833
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: conntrack-tools
User: [email protected]
Usertags: origin-ubuntu artful ubuntu-patch autopkgtest
Version: 1:1.4.4+snapshot20161117-5
Severity: normal
Tags: patch
Dear maintainers,
The conntrack-tools 1.4.4+snapshot20161117 update was blocked from reaching
Ubuntu's 17.04 release, because it regresses its autopkgtests in Ubuntu
compared to 1.4.3-3.
I have so far identified two problems with the tests when running on Ubuntu:
- the tests modprobe a bunch of nf_conntrack_* modules; if some of these
modules don't load because they are built into the kernel (as is the case
for some of them on Ubuntu), these tests fail.
- several tests are marked 'isolation-container', but provide a
configuration to conntrackd that requires host-level privileges, so
conntrackd fails at startup when run in a container.
I have uploaded the attached patch to Ubuntu to address both of these
problems. Please consider applying in Debian as well.
I am still seeing one test failure on the Ubuntu autopkgtest infrastructure
that I haven't yet reproduced locally. I'll send another patch if and when
I manage to address this.
Thanks,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
[email protected] [email protected]
diff -Nru conntrack-tools-1.4.4+snapshot20161117/debian/patches/series
conntrack-tools-1.4.4+snapshot20161117/debian/patches/series
--- conntrack-tools-1.4.4+snapshot20161117/debian/patches/series
2016-12-05 03:52:20.000000000 -0800
+++ conntrack-tools-1.4.4+snapshot20161117/debian/patches/series
2017-08-11 14:50:43.000000000 -0700
@@ -1 +1,2 @@
missing-include.patch
+skip-already-loaded-modules.patch
diff -Nru
conntrack-tools-1.4.4+snapshot20161117/debian/patches/skip-already-loaded-modules.patch
conntrack-tools-1.4.4+snapshot20161117/debian/patches/skip-already-loaded-modules.patch
---
conntrack-tools-1.4.4+snapshot20161117/debian/patches/skip-already-loaded-modules.patch
1969-12-31 16:00:00.000000000 -0800
+++
conntrack-tools-1.4.4+snapshot20161117/debian/patches/skip-already-loaded-modules.patch
2017-08-11 20:53:24.000000000 -0700
@@ -0,0 +1,56 @@
+Description: Don't fail on modprobe since the driver might be built-in
+ Any of these nf drivers could be built-ins instead of modules; don't cause
+ the testsuite to fail on modprobe, instead let it proceed and succeed/fail
+ later based on actual test results.
+ .
+ Ideally we would check up front if the driver is loaded rather than trying
+ to modprobe and ignoring failures, but there doesn't seem to be a reliable
+ place to check this in the kernel filesystem
+Author: Steve Langasek <[email protected]>
+
+Index: conntrack-tools-1.4.4+snapshot20161117/tests/conntrack/run-test.sh
+===================================================================
+--- conntrack-tools-1.4.4+snapshot20161117.orig/tests/conntrack/run-test.sh
++++ conntrack-tools-1.4.4+snapshot20161117/tests/conntrack/run-test.sh
+@@ -10,10 +10,12 @@
+ #
+ # XXX: module auto-load not support by nfnetlink_cttimeout yet :-(
+ #
+-modprobe nf_conntrack_ipv4
+-modprobe nf_conntrack_ipv6
+-modprobe nf_conntrack_proto_udplite
+-modprobe nf_conntrack_proto_sctp
+-modprobe nf_conntrack_proto_dccp
+-modprobe nf_conntrack_proto_gre
++# any or all of these might be built-ins rather than modules, so don't error
++# out on failure from modprobe
++modprobe nf_conntrack_ipv4 || true
++modprobe nf_conntrack_ipv6 || true
++modprobe nf_conntrack_proto_udplite || true
++modprobe nf_conntrack_proto_sctp || true
++modprobe nf_conntrack_proto_dccp || true
++modprobe nf_conntrack_proto_gre || true
+ ./test testcases
+Index: conntrack-tools-1.4.4+snapshot20161117/tests/nfct/run-test.sh
+===================================================================
+--- conntrack-tools-1.4.4+snapshot20161117.orig/tests/nfct/run-test.sh
++++ conntrack-tools-1.4.4+snapshot20161117/tests/nfct/run-test.sh
+@@ -11,10 +11,12 @@
+ #
+ # XXX: module auto-load not support by nfnetlink_cttimeout yet :-(
+ #
+-modprobe nf_conntrack_ipv4
+-modprobe nf_conntrack_ipv6
+-modprobe nf_conntrack_proto_udplite
+-modprobe nf_conntrack_proto_sctp
+-modprobe nf_conntrack_proto_dccp
+-modprobe nf_conntrack_proto_gre
++# any or all of these might be built-ins rather than modules, so don't error
++# out on failure from modprobe
++modprobe nf_conntrack_ipv4 || true
++modprobe nf_conntrack_ipv6 || true
++modprobe nf_conntrack_proto_udplite || true
++modprobe nf_conntrack_proto_sctp || true
++modprobe nf_conntrack_proto_dccp || true
++modprobe nf_conntrack_proto_gre || true
+ ./test timeout
diff -Nru
conntrack-tools-1.4.4+snapshot20161117/debian/tests/basic-daemon-test.sh
conntrack-tools-1.4.4+snapshot20161117/debian/tests/basic-daemon-test.sh
--- conntrack-tools-1.4.4+snapshot20161117/debian/tests/basic-daemon-test.sh
2016-11-17 00:25:52.000000000 -0800
+++ conntrack-tools-1.4.4+snapshot20161117/debian/tests/basic-daemon-test.sh
2017-08-11 16:46:53.000000000 -0700
@@ -42,6 +42,23 @@
rm -f $LOCKFILE
fi
+if [ $(systemd-detect-virt) == lxc ]; then
+ scheduling=""
+ bufsize=""
+else
+ scheduling=<<EOF
+ Nice -20
+ Scheduler {
+ Type FIFO
+ Priority 99
+ }
+EOF
+ bufsize=<<EOF
+ SndSocketBuffer 12492800
+ RcvSocketBuffer 12492800
+EOF
+fi
+
echo "
Sync {
Mode NOTRACK {
@@ -55,19 +72,14 @@
Port 3780
Interface lo
Checksum on
- SndSocketBuffer 12492800
- RcvSocketBuffer 12492800
+$bufsize
}
Options {
ExpectationSync On
}
}
General {
- Nice -20
- Scheduler {
- Type FIFO
- Priority 99
- }
+$scheduling
Syslog on
LockFile $LOCKFILE
diff -Nru conntrack-tools-1.4.4+snapshot20161117/debian/tests/control
conntrack-tools-1.4.4+snapshot20161117/debian/tests/control
--- conntrack-tools-1.4.4+snapshot20161117/debian/tests/control 2016-12-07
01:35:34.000000000 -0800
+++ conntrack-tools-1.4.4+snapshot20161117/debian/tests/control 2017-08-11
20:55:01.000000000 -0700
@@ -24,8 +24,8 @@
Tests: conntrack-internal-testsuite.sh
Depends: @, @builddeps@, kmod
-Restrictions: needs-root, isolation-machine, build-needed
+Restrictions: needs-root, isolation-machine, build-needed, allow-stderr
Tests: nfct-internal-testsuite.sh
Depends: @, @builddeps@, kmod
-Restrictions: needs-root, isolation-machine, build-needed
+Restrictions: needs-root, isolation-machine, build-needed, allow-stderr
diff -Nru
conntrack-tools-1.4.4+snapshot20161117/debian/tests/systemd-service-test.sh
conntrack-tools-1.4.4+snapshot20161117/debian/tests/systemd-service-test.sh
--- conntrack-tools-1.4.4+snapshot20161117/debian/tests/systemd-service-test.sh
2016-11-17 00:25:52.000000000 -0800
+++ conntrack-tools-1.4.4+snapshot20161117/debian/tests/systemd-service-test.sh
2017-08-11 16:47:25.000000000 -0700
@@ -26,6 +26,35 @@
return 0
}
+get_ethernet_device()
+{
+ for dev in /sys/class/net/*; do
+ if [ $(cat "$dev/type") = 1 ]; then
+ echo $(basename "$dev")
+ break
+ fi
+ done
+}
+
+ETHER=$(get_ethernet_device)
+
+if [ $(systemd-detect-virt) == lxc ]; then
+ scheduling=""
+ bufsize=""
+else
+ scheduling=<<EOF
+ Nice -20
+ Scheduler {
+ Type FIFO
+ Priority 99
+ }
+EOF
+ bufsize=<<EOF
+ SndSocketBuffer 12492800
+ RcvSocketBuffer 12492800
+EOF
+fi
+
echo "
Sync {
Mode NOTRACK {
@@ -37,21 +66,16 @@
IPv4_address 127.0.0.1
IPv4_Destination_Address 127.0.0.1
Port 3780
- Interface eth0
+ Interface $ETHER
Checksum on
- SndSocketBuffer 12492800
- RcvSocketBuffer 12492800
+$bufsize
}
Options {
ExpectationSync On
}
}
General {
- Nice -20
- Scheduler {
- Type FIFO
- Priority 99
- }
+$scheduling
Syslog on
LockFile /var/lock/conntrackd.lock
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: conntrack-tools
Source-Version: 1:1.4.4+snapshot20161117-6
We believe that the bug you reported is fixed in the latest version of
conntrack-tools, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Arturo Borrero Gonzalez <[email protected]> (supplier of updated
conntrack-tools package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 15 Aug 2017 14:14:29 +0200
Source: conntrack-tools
Binary: conntrack conntrackd nfct
Architecture: source amd64
Version: 1:1.4.4+snapshot20161117-6
Distribution: unstable
Urgency: medium
Maintainer: Debian Netfilter Packaging Team
<[email protected]>
Changed-By: Arturo Borrero Gonzalez <[email protected]>
Description:
conntrack - Program to modify the conntrack tables
conntrackd - Connection tracking daemon
nfct - Tool to interact with the connection tracking system
Closes: 871833
Changes:
conntrack-tools (1:1.4.4+snapshot20161117-6) unstable; urgency=medium
.
[ Arturo Borrero Gonzalez ]
* [82925029] d/t/control: add testcase to cover bug #855281
* [85880465] d/control: move package to pkg-netfilter
.
[ Steve Langasek ]
* [5d478ea5] d/tests/: use containers-friendy test config files
(Closes: #871833)
* [bf85e4d2] d/tests/: more robust handling of modules in CI environments
(Closes: #871833)
.
[ Arturo Borrero Gonzalez ]
* [b3fa112b] d/t/control: fix typo
Checksums-Sha1:
621913a9678a9ca38ba4148bcf377bf67bdd3455 2666
conntrack-tools_1.4.4+snapshot20161117-6.dsc
a5db3c7ca02d773af3bbda526d13147a63a5e2d4 150708
conntrack-tools_1.4.4+snapshot20161117.orig.tar.bz2
c4b2f4e01fac564ac5c6399641a0b330a3239a36 10176
conntrack-tools_1.4.4+snapshot20161117-6.debian.tar.xz
1c738aef127d79d379da7a4b28c23d0af9eb7f6f 62694
conntrack-dbgsym_1.4.4+snapshot20161117-6_amd64.deb
eccdc737853da63538d69e46368d94da0f7e60bb 7499
conntrack-tools_1.4.4+snapshot20161117-6_amd64.buildinfo
b8d6c617a9e4353f225c04f254a3f9d96786f67d 33208
conntrack_1.4.4+snapshot20161117-6_amd64.deb
fb00b9b02c9e869eead6497e5f5bd125136a9b34 391898
conntrackd-dbgsym_1.4.4+snapshot20161117-6_amd64.deb
1d7ee1849fac2f4b92cd3b0db16bd443c68653ef 128590
conntrackd_1.4.4+snapshot20161117-6_amd64.deb
6aa6f216c10bdc11f74584c32361ded707a3d346 28142
nfct-dbgsym_1.4.4+snapshot20161117-6_amd64.deb
96479902fed1f5e07608e7d498c2a12c2030b481 15148
nfct_1.4.4+snapshot20161117-6_amd64.deb
Checksums-Sha256:
309eef24521d42a9365507b1bf398c883ebfd9b5e0db9a7f8d4da439709ce976 2666
conntrack-tools_1.4.4+snapshot20161117-6.dsc
601704bd2b6dc4a5eeef6a1a0a5a05260af979a69fcef14f47d29402bc54ce0d 150708
conntrack-tools_1.4.4+snapshot20161117.orig.tar.bz2
a3ebeac40a77d1615003d668edf4afe927827a2a6a3799595e910ff3330ac64c 10176
conntrack-tools_1.4.4+snapshot20161117-6.debian.tar.xz
98cd78da12122312ac80ffc0a2c2a890e2d927de1ca6547eae993e59d4473d06 62694
conntrack-dbgsym_1.4.4+snapshot20161117-6_amd64.deb
ca717a360244ac0cccd4bec7890711333bbb605fc61f44d9775b2f9f5e25cee4 7499
conntrack-tools_1.4.4+snapshot20161117-6_amd64.buildinfo
27609b69ac2a45dbea129002aaa77cefb921d1b44cad2b37f57f9049d3cb739d 33208
conntrack_1.4.4+snapshot20161117-6_amd64.deb
d6a4b66581c6439c5509a0eab357ce69d1729d841e7e261bae571b18f67fcffd 391898
conntrackd-dbgsym_1.4.4+snapshot20161117-6_amd64.deb
70db49f036cdef74804b355516bb4fd7221cc1757ecd4b2bb4c2f5a0c6731d37 128590
conntrackd_1.4.4+snapshot20161117-6_amd64.deb
a55780453fe6a06ed443d42939360d72d3248835afe19135ea82a32817068f32 28142
nfct-dbgsym_1.4.4+snapshot20161117-6_amd64.deb
ce991519d4e7632d5067b5c5ac0fcaa41b1a09959f0102e6735e3123fff46202 15148
nfct_1.4.4+snapshot20161117-6_amd64.deb
Files:
4aa46b440e3ae25dd0d3ebde2480ec47 2666 net extra
conntrack-tools_1.4.4+snapshot20161117-6.dsc
2a7a2b56d35e089c0c0ede7d5a0cb763 150708 net extra
conntrack-tools_1.4.4+snapshot20161117.orig.tar.bz2
9d63d00ce96de1c8f07c1b72019c1ed7 10176 net extra
conntrack-tools_1.4.4+snapshot20161117-6.debian.tar.xz
fc07004f45a7e5e816e1dfacf450a624 62694 debug extra
conntrack-dbgsym_1.4.4+snapshot20161117-6_amd64.deb
4ef1499a98137aeda86daae0f11e146b 7499 net extra
conntrack-tools_1.4.4+snapshot20161117-6_amd64.buildinfo
72be01b83977563205138e9c6c9a04cb 33208 net extra
conntrack_1.4.4+snapshot20161117-6_amd64.deb
b86dd61874b587802dc3fa6e003de0bf 391898 debug extra
conntrackd-dbgsym_1.4.4+snapshot20161117-6_amd64.deb
762480b1db9ff1248672d23bc6c83d8c 128590 net extra
conntrackd_1.4.4+snapshot20161117-6_amd64.deb
5cdcc9a266cb6e4460d2a7ce1c564a68 28142 debug extra
nfct-dbgsym_1.4.4+snapshot20161117-6_amd64.deb
b0c83adadad1758555008404261594a2 15148 net extra
nfct_1.4.4+snapshot20161117-6_amd64.deb
-----BEGIN PGP SIGNATURE-----
iQJGBAEBCgAwFiEE3ZhhqyPcMzOJLgepaOcTmB0VFfgFAlmS61cSHGFydHVyb0Bk
ZWJpYW4ub3JnAAoJEGjnE5gdFRX40lkP/iStUk6ttUo/1Tg3WGytY8NPfghWBTj6
Z/wKjwAjl6oabocNw4OvR6jrBI/WRhm0jmxND71JwQRV5kfh3tFPUzdMshWcIG6m
VSxG3fg36VFO/g603fS6x9AKwLQ1inPRTVPrW0VbCiUzpe/UIu8IZGj/tsdw5I+W
hiRS/QjJPaPWF383RTwAc7uT0ti/MK8jEMYat3xXSXMioyK8LRaQSgLhEya42/ka
9ICoKDYnGVJbpTtKlm+GpyHA2tZe+acP/VRcC8UKZ0OgD+2sUHgO4+x/9Mdi3VTo
TlsHJUfSZM/zYT+7mglekZIB1C0owIsWSqs0cCLLZ2t7miHp3ceemB+As/3zULlK
uekC32NPOoVXftEDYeOpZKN0XWAg2eiV3KQ5+w7DgBoJd5NyELFlJ7ROdKawY5uL
4JDD6nV9AQ6hOIsWS9vN8wwumtVDRytqeyvig7ugpGJOmikPh9O2cgBG2L/GQsCk
UiCVLyXB+1WJkreYVWUF9J9+czVqfbmBFLKT1jyaYIHqhSN39ckwma0JmDXC+PmA
Vq4PYWpP3NehINoKlzcJ7P072BUJZpsceJjjuIX1P+8qii+ZrGTLqLieJpya9GL6
m5NtrXD2mq8+++jfu5jutnLz67WVtFgm+U8j5U1BoyGTl29562Mxnkfu31UNqc7c
DJHdVyOfFrZf
=EWDR
-----END PGP SIGNATURE-----
--- End Message ---
