Your message dated Tue, 22 Aug 2017 21:10:11 +0000
with message-id <[email protected]>
and subject line Bug#872865: fixed in libtecla 1.6.3-2
has caused the Debian Bug report #872865,
regarding libtecla: gl_get_line() fails to detect EOF
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
872865: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=872865
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libtecla1
Version: 1.6.3-1
Severity: normal
File: libtecla
Tags: patch upstream
gl_get_line() in server mode will errenously fail to detect an EOF
condition when reading from a fd which is not a tty and return
GL_READ_BLOCKED indefinetly. The bug is in gl_read_unmasked() which
calls isatty() before checking the errno from the read() call and
thereby clobbering errno if the fd in fact does not refer to a tty.
I've tried to contact upstream but the email address in the docs and
on the homepage bounces. A patch fixing the issue is attached.
-- System Information:
Debian Release: 9.1
APT prefers stable
APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 4.4.0-89-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=locale: Cannot set
LC_ALL to default locale: No such file or directory
UTF-8), LANGUAGE=en_US.UTF-8 (charmap=locale: Cannot set LC_ALL to default
locale: No such file or directory
UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages libtecla1 depends on:
ii libc6 2.24-11+deb9u1
libtecla1 recommends no packages.
libtecla1 suggests no packages.
-- debconf information excluded
--- libtecla.orig/getline.c 2013-09-12 07:04:00.000000000 +0000
+++ libtecla/getline.c 2017-08-21 14:40:39.248681309 +0000
@@ -3296,6 +3296,7 @@
static GlReadStatus gl_read_unmasked(GetLine *gl, int fd, char *c)
{
int nread; /* The return value of read() */
+ int saved_errno;
/*
* Unblock the signals that we are trapping, while waiting for I/O.
*/
@@ -3307,6 +3308,7 @@
do {
errno = 0;
nread = read(fd, c, 1);
+ saved_errno = errno;
} while(nread < 0 && errno==EINTR);
/*
* Block all of the signals that we are trapping.
@@ -3319,7 +3321,7 @@
case 1:
return GL_READ_OK;
case 0:
- return (isatty(fd) || errno != 0) ? GL_READ_BLOCKED : GL_READ_EOF;
+ return (isatty(fd) || saved_errno != 0) ? GL_READ_BLOCKED : GL_READ_EOF;
default:
return GL_READ_ERROR;
};
--- End Message ---
--- Begin Message ---
Source: libtecla
Source-Version: 1.6.3-2
We believe that the bug you reported is fixed in the latest version of
libtecla, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Andreas Tille <[email protected]> (supplier of updated libtecla package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Tue, 22 Aug 2017 21:42:28 +0200
Source: libtecla
Binary: libtecla-dev libtecla1
Architecture: source amd64
Version: 1.6.3-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Med Packaging Team
<[email protected]>
Changed-By: Andreas Tille <[email protected]>
Description:
libtecla-dev - interactive command line editing facilities (development)
libtecla1 - interactive command line editing facilities
Closes: 872865
Changes:
libtecla (1.6.3-2) unstable; urgency=medium
.
* Moved packaging from SVN to Git
* Standards-Version: 4.0.1 (no changes needed)
* debhelper 10
* Enable gl_get_line() to detect EOF (Thanks for the patch to Guido
Berhoerster <[email protected]>)
Closes: #872865
* hardening
Checksums-Sha1:
2d8382f1d43bae9a55f03490fec54771cd74ea63 2063 libtecla_1.6.3-2.dsc
63693aad2dd35eb2d92ade153d3152e1fab4a65a 7320 libtecla_1.6.3-2.debian.tar.xz
3a2ff91c21166e37b548d83824a90e406e3edf82 195828 libtecla-dev_1.6.3-2_amd64.deb
8487a81c99a7dcbade348dc42e283b7dc81f7152 103392 libtecla1_1.6.3-2_amd64.deb
9f790655fe62d47960915f7b95a681d9d8e38325 5946 libtecla_1.6.3-2_amd64.buildinfo
Checksums-Sha256:
1e39ca6fc7dc2caad015e9959c4fc589e29aab407bb599dd0d08ea0018df3170 2063
libtecla_1.6.3-2.dsc
841f7588a0b3fb03ce20e88427e1142cd0fd13d589fed83d845f1f73151c020d 7320
libtecla_1.6.3-2.debian.tar.xz
5352e63aa37f6a73bff8a6c0e332921d9b839cbfe302c5dfb8d5115f6975420a 195828
libtecla-dev_1.6.3-2_amd64.deb
a2ab6058dc897e693a61b5d1d27f64250d805d10cf6de66f2006ff1b6737693f 103392
libtecla1_1.6.3-2_amd64.deb
2cd49be329f40f649a970cf1121e8431ddafe708398abcc47618b70d9b94f2df 5946
libtecla_1.6.3-2_amd64.buildinfo
Files:
09fb65be6dbf08d11a37dffb0a34c4a8 2063 science optional libtecla_1.6.3-2.dsc
3052b58ef7c153ea0ec8bcf80d69e276 7320 science optional
libtecla_1.6.3-2.debian.tar.xz
bfd4b6519971442c4b9fa34236adfcc5 195828 libdevel optional
libtecla-dev_1.6.3-2_amd64.deb
aebc50ef31518f984e3b5cbdc0596af4 103392 libs optional
libtecla1_1.6.3-2_amd64.deb
5af5904f7c00da907ae6989ce84fdcca 5946 science optional
libtecla_1.6.3-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJFBAEBCAAvFiEE8fAHMgoDVUHwpmPKV4oElNHGRtEFAlmcjLYRHHRpbGxlQGRl
Ymlhbi5vcmcACgkQV4oElNHGRtEMsw//ekA98pNj4Rus0NMgH9Lj26aqBmDBnH19
bKCeEBuaO4Q82wnJODn5oNkG/+UvA/BcgcKtTZXIfzBPWS3a+YgEq0DVgKbTTuel
RUxQGwsB1Pmt5IihLcAjVaT5Ir9SCma5+tBic16pSe0h+yAC7JRwE2Mvir7HqxJI
4pCDbb38l8lZ+MroIpm8mmAPLUBHHIwFK6qwlzXNhPhqlQWxds3aTcxf1gqBOER0
K+cX+ZwFXwEqyTkmJ3u6jjmM7MLxw7uL/w6qrY/StW3AefAgIHPI6ZhFLvgJeIQu
JEO6z5cCYdFlMq7CsvP6e9SxKbk5C5D6VuDHfaPd6IBFUeR0BZ9twR+9PxMD43pe
3SyJrDWQBjOeyRXDKdcH3wsV8/4cl5hNXNrT8+JZf4GhHnQlGAtjkAzEHR2Km3SF
PLkMKrDjnxfm4f12GMrtpGdN8xK7+EtA6U19kO0k7F2IadFQEFLGak5HoamHgkXL
s/O0HNFRsd8U2nHhfsuELqhMP0FC6AI6O8jUT3KScV0H/SykUtxFI9w6T2SN8z8S
54t6XhSKUWCwu9UOwxKPWddqU//eUVEisFKw1bVHE0CyNTczoTtMmNCm4Yxb0jnd
dy0XxnZRrDicFY1UIUq1eSDAlwIcqZMycyyURC5iOXAU3FcjxxTRFQd9REmbR2R4
ddof976NL3Q=
=oxeu
-----END PGP SIGNATURE-----
--- End Message ---
