Your message dated Thu, 07 Sep 2017 15:16:06 +0200
with message-id <[email protected]>
and subject line Re: Bug#874572: hexchat: opens URLs in Firefox
has caused the Debian Bug report #874572,
regarding hexchat: opens URLs in Firefox
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
874572: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=874572
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: hexchat
Version: 2.12.4-5+b2
Severity: normal
Tags: upstream
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Hexchat bydefault passes URLs to firefox.
Included patch makes it browser-agnostic, by instead (recommending
xdg-utils and) calling xdg-open.
This bug was reported in the Debian derivative PureOS at
https://tracker.pureos.net/T90 - but should preferrably be solved once
generically for Debian and all its derivatives.
- Jonas
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEn+Ppw2aRpp/1PMaELHwxRsGgASEFAlmxLkQACgkQLHwxRsGg
ASHopQ//audYKFT/orgnXQSU4lzja45lXdfZtZV4vI5pktpbHi2wP8+e51FZqfc3
osJqOlHDdOlVePvfwPsX1kczTZ8KTfkUwPVQtFbA4NHpytbniLHelf7s/7Oe/zxw
Lyt/PHtyoEiCqW2gfblRtbNC8xCLbbf7BfpmYLhXuZaTnWSiCKfD2QQyYx33OiC6
zQ0SjcJiogDOePHjbFBoU6L0thh+RwxcABNbT6Tm+UK8nSQ2GKfJfLz6uVqQ3yvT
xSKm0FukgCO8qRPx0M1r9n6Bc6FB32IpqtjXLAjgLtEwERPKU5GRuWPStkzU+foK
0Ox1CmocP/rGvNHAXua8d+ZrJ30nuqHhTsG9Eb4nGFt8AuFZnJwWpmiauDPCqVnF
W5wUpQAcaI3QlIMomg+LFvqbu2drocew5Fge0aXKxbTwT20n5QmqVbLvxlzvQh59
YasR+sFnGwk4bPg/YfHYoC048w0+mT4vdYPzItxf1IH/Ed6K4rZvslX5T4t4DyBi
j+DWfnBkhqoAwqj+ub3OehDT5T3P+PXgmvbAoEc+urz/havWP9PG9bvORSam5X3i
EQn+fd3e9YuCVXOEo2nYzB/NU5+0DEEsDJ0b7ZZ49AOdRYbuXTGoipKCu7G9bMmB
AQjl6KsUrlazYmRqD4ATSAu3+TPhMzy+bXiYCpT7S5JEv//saU8=
=A2Ek
-----END PGP SIGNATURE-----
diff --git a/debian/control b/debian/control
index d8ab16b..5268ee9 100644
--- a/debian/control
+++ b/debian/control
@@ -36,6 +36,7 @@ Recommends:
hexchat-perl,
hexchat-plugins,
hexchat-python3,
+ xdg-utils,
Suggests:
hexchat-otr,
unifont,
diff --git a/debian/patches/0004-use-xdg-open.patch
b/debian/patches/0004-use-xdg-open.patch
new file mode 100644
index 0000000..3b06fc0
--- /dev/null
+++ b/debian/patches/0004-use-xdg-open.patch
@@ -0,0 +1,11 @@
+--- a/src/common/hexchat.c
++++ b/src/common/hexchat.c
+@@ -768,7 +768,7 @@
+ "NAME WII\n" "CMD quote WHOIS %2 %2\n\n";
+
+ static char defaultconf_urlhandlers[] =
+- "NAME Open Link in a new Firefox Window\n" "CMD
!firefox -new-window %s\n\n";
++ "NAME Open Link in a external application\n" "CMD
!xdg-open %s\n\n";
+
+ #ifdef USE_SIGACTION
+ /* Close and open log files on SIGUSR1. Usefull for log rotating */
diff --git a/debian/patches/series b/debian/patches/series
index 7b6a883..abd54a5 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,5 +1,6 @@
0001-Debian-server-defaults.patch
0003-build-both-python-plugins.patch
+0004-use-xdg-open.patch
4c178782a779f013fafab476506f7d4dae372b8a.patch
diff --git a/debian/patches/ubuntu.series b/debian/patches/ubuntu.series
index 1ecb91e..6ee0403 100644
--- a/debian/patches/ubuntu.series
+++ b/debian/patches/ubuntu.series
@@ -1,4 +1,5 @@
0001-Ubuntu-server-defaults.patch
0003-build-both-python-plugins.patch
+0004-use-xdg-open.patch
4c178782a779f013fafab476506f7d4dae372b8a.patch
--- End Message ---
--- Begin Message ---
On Thu, Sep 07, 2017 at 02:14:18PM +0200, Mattia Rizzolo wrote:
> On Thu, Sep 07, 2017 at 01:32:23PM +0200, Jonas Smedegaard wrote:
> > Hexchat bydefault passes URLs to firefox.
>
> That's not entirely true.
> Whilst it's true that that button hardocdes firefox and opens only
> with it, there is another button "Open Link in Brower" that uses
> whatever broeser is default in the system; it's not clear to me how it
> select a browser, but see src/fe-gtk/menu.c.
Thanks for the insight.
> > Included patch makes it browser-agnostic, by instead (recommending
> > xdg-utils and) calling xdg-open.
>
> Do you still think there is such a need.
No, given your additional info I consider the current behaviour
(slightly odd, but) in no need of patching.
Thanks! Closing as a non-bug.
> > This bug was reported in the Debian derivative PureOS at
> > https://tracker.pureos.net/T90 - but should preferrably be solved
> > once generically for Debian and all its derivatives.
>
> Please consider bringing such bugs directly to upstream
> https://github.com/hexchat/hexchat
Thanks for mentioning. Concretely I felt that Debian is enthusiastic
about treating applications equally whereas upstream might genuinely
choose to favor specific tools. But I didn't give it much thought, and
(if it was an issue worth addressing - see above) then indeed it makes
sense to at least _propose_ flexibility upstream - which they could then
simply choose to not accept. I will think harder on that aspect for
future bug reporting. thanks again!
- Jonas
--
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
--- End Message ---
