Your message dated Sun, 24 Sep 2017 15:02:11 +0000
with message-id <e1dw8q7-000gxv...@fasolo.debian.org>
and subject line Bug#838288: fixed in mailman 1:2.1.23-1+deb9u1
has caused the Debian Bug report #838288,
regarding mailman: SpamAssassin module broken in Testing and Unstable
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
838288: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=838288
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: mailman
Version: 1:2.1.23-1
Severity: normal
Tags: patch

Dear Maintainer,

   * What led up to the situation?

Upgraded mailman to the version in testing.  We have the SpamAssassin
module in use as per instructions:

in mm_cfg.py we uncommented the line:

GLOBAL_PIPELINE.insert(1, 'SpamAssassin')

Mailman produced errors like these in ite error log:

Sep 16 19:06:29 2016 (3736) Uncaught runner exception: cannot import name matche
s_p
Sep 16 19:06:29 2016 (3736) Traceback (most recent call last):
  File "/var/lib/mailman/Mailman/Queue/Runner.py", line 119, in _oneloop
    self._onefile(msg, msgdata)
  File "/var/lib/mailman/Mailman/Queue/Runner.py", line 190, in _onefile
    keepqueued = self._dispose(mlist, msg, msgdata)
  File "/var/lib/mailman/Mailman/Queue/IncomingRunner.py", line 130, in _dispose
    more = self._dopipeline(mlist, msg, msgdata, pipeline)
  File "/var/lib/mailman/Mailman/Queue/IncomingRunner.py", line 150, in _dopipel
ine
    __import__(modname)
  File "/var/lib/mailman/Mailman/Handlers/SpamAssassin.py", line 31, in <module>
    from Mailman.Handlers.Moderate import matches_p
ImportError: cannot import name matches_p

and all messages were shunted.

   * What exactly did you do (or not do) that was effective (or
     ineffective)?

Applying the following patch fixes the probelm for us:

--- /usr/lib/mailman/Mailman/Handlers/SpamAssassin.py   2016-04-26 
03:06:54.000000000 +1000
+++ /backup/usr/lib/mailman/Mailman/Handlers/SpamAssassin.py    2016-05-02 
15:21:29.833067102 +1000
@@ -28,7 +28,6 @@
 from Mailman import Errors
 from Mailman.Logging.Syslog import syslog
 from Mailman.Handlers import Hold
-from Mailman.Handlers.Moderate import matches_p
 
 SPAMD_HOST    = getattr(mm_cfg, 'SPAMASSASSIN_HOST', '')
 DISCARD_SCORE = getattr(mm_cfg, 'SPAMASSASSIN_DISCARD_SCORE', 10)
@@ -78,7 +77,7 @@
     if MEMBER_BONUS != 0:
         for sender in msg.get_senders():
             if mlist.isMember(sender) or \
-                   matches_p(sender, mlist.accept_these_nonmembers, 
mlist.internal_name()):
+                   mlist.GetPattern(sender, mlist.accept_these_nonmembers, 
at_list='accept_these_nonmembers'):
                 score -= MEMBER_BONUS
                 break
 

   * What was the outcome of this action?

mailman works again

   * What outcome did you expect instead?

--------

It appears that the SpamAssasin module is added by the Debian packaging
and it used an interface from the main mailman package that was removed.

The version of mailman in Stable is fine (1:2.1.18-2+deb8u1) but that
in Testing ans Unstable are broken (1:2.1.22-1 and 1:2.1.23-1).

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'stable-updates'), (500, 'stable'), (1, 
'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.4.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages mailman depends on:
ii  apache2 [httpd]        2.4.23-4
ii  cron [cron-daemon]     3.0pl1-128
ii  debconf [debconf-2.0]  1.5.59
ii  libc6                  2.23-5
ii  logrotate              3.8.7-2
ii  lsb-base               9.20160629
ii  python-dnspython       1.14.0-3
pn  python:any             <none>
ii  ucf                    3.0036

Versions of packages mailman recommends:
ii  postfix [mail-transport-agent]  3.1.0-5+b1

Versions of packages mailman suggests:
ii  listadmin     2.40-5
ii  lynx          2.8.9dev9-1
ii  spamassassin  3.4.1-5

-- debconf information:
* mailman/create_site_list:
* mailman/used_languages: en
* mailman/default_server_language: en
  mailman/gate_news: false
* mailman/site_languages: en
* mailman/queue_files_present: abort installation

-- debsums errors found:
debsums: changed file /usr/lib/mailman/Mailman/Handlers/SpamAssassin.py (from 
mailman package)

--- End Message ---
--- Begin Message ---
Source: mailman
Source-Version: 1:2.1.23-1+deb9u1

We believe that the bug you reported is fixed in the latest version of
mailman, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 838...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thijs Kinkhorst <th...@debian.org> (supplier of updated mailman package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 14 Sep 2017 12:23:04 +0200
Source: mailman
Binary: mailman
Architecture: source amd64
Version: 1:2.1.23-1+deb9u1
Distribution: stretch
Urgency: medium
Maintainer: Mailman for Debian <pkg-mailman-hack...@lists.alioth.debian.org>
Changed-By: Thijs Kinkhorst <th...@debian.org>
Description:
 mailman    - Powerful, web-based mailing list manager
Closes: 838288
Changes:
 mailman (1:2.1.23-1+deb9u1) stretch; urgency=medium
 .
   * Fixed broken dependencies in SpamAssassin.py (Closes: #838288).
     Thanks Stephen Rothwell for the patch.
Checksums-Sha1:
 85c07e07d78186baed9a2838c2821586aa5dc763 1793 mailman_2.1.23-1+deb9u1.dsc
 8f67e2dbace27505945ff21d7989d2b0e000dada 102252 
mailman_2.1.23-1+deb9u1.debian.tar.xz
 96c9b9f4d76af573470cc40016c9f6bc28294021 19234 
mailman-dbgsym_2.1.23-1+deb9u1_amd64.deb
 ccc22ce18b87708bdd6c7363c9b35efb170fd17b 5746 
mailman_2.1.23-1+deb9u1_amd64.buildinfo
 77004655d04fcbcca3a9f49c354a706f980e6c71 4466440 
mailman_2.1.23-1+deb9u1_amd64.deb
Checksums-Sha256:
 9ce9d049447f200884ffd0e46b0c7c1976cfb833b712695e2afaec02dffd27db 1793 
mailman_2.1.23-1+deb9u1.dsc
 f2d4ea6031bd19fb86c4ff0efd888405f6b03f8ec9160160f27ea076a0147b8d 102252 
mailman_2.1.23-1+deb9u1.debian.tar.xz
 078451dec3961229e2b8b785dc69d91dda2abfe420fac33dc7a36e741f410f0a 19234 
mailman-dbgsym_2.1.23-1+deb9u1_amd64.deb
 ec10e86de2c8aa9eb2f8175d2d0b0c7cc4a09e12cd1aa1c89228c072851143a4 5746 
mailman_2.1.23-1+deb9u1_amd64.buildinfo
 69a9924123d63446c18155d61596f4d319c7b3ff0544424062903a8c4d674a33 4466440 
mailman_2.1.23-1+deb9u1_amd64.deb
Files:
 55e2117f86dae0bb4511daf29024d08c 1793 mail optional mailman_2.1.23-1+deb9u1.dsc
 e22bb3faf2d276a5f5bf7e5bfbbf795c 102252 mail optional 
mailman_2.1.23-1+deb9u1.debian.tar.xz
 5e12f46357c93b52b48a49411300d3f7 19234 debug extra 
mailman-dbgsym_2.1.23-1+deb9u1_amd64.deb
 cc279b64bd9c3b971c8a000ded210f45 5746 mail optional 
mailman_2.1.23-1+deb9u1_amd64.buildinfo
 4a23136069a32b0ce46c1d8f38500404 4466440 mail optional 
mailman_2.1.23-1+deb9u1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBCAAGBQJZx1l0AAoJEFb2GnlAHawElwUH/2FOG6RvuMJau7lyBwdUMKo/
CeZSmQEp7hvn1XVc0/WhKft449IwRX3gI0ZrrmZiKLc3mRP4ZiZHgF+GiVfvLWNL
OAER8JssU1nHXsUPODQtcukxTLTIZf3gx3bl7eBqFuZxanWyT2bbqA0425ZrAcEj
GVKbGnAWFHzCXFGlYqMqpIBL7oxGKX5+W7i7/zEIehaqh7/qxYTdS+lu5xTO40rJ
2gjmbMgcJ6N3CGzpJ72l9VesGanuHkvkRXZpSoD1PgYqkGCH4hhJ0wqj6vYMq2z/
Ny2PrnolAXyS0b2p+odhRFZzLZ+FIvSN3o/nx49cWijmzNln8gXDxH7hkYYCTJU=
=bTVt
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to