Your message dated Thu, 28 Sep 2017 12:49:56 +0000
with message-id <[email protected]>
and subject line Bug#872993: fixed in libvpd 2.2.5-3
has caused the Debian Bug report #872993,
regarding libvpd: udev rules fail whilst /var/lib is not-mounted or read-only
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
872993: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=872993
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libvpd
Version: libvpd: udev rules fail whilst /var/lib is not-mounted or read-only
Severity: important
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Dear Maintainer,
As discussed at https://launchpad.net/bugs/1682774 some users
experience a race condition with udev rules. Specifically state file
vpdupdate is not writable at all times throughout the system
lifecycle.
It has been recommended to use /run, a runtime directory, for the
vpdupdate notify file since that persist and is writable at all
times.
A patch to this effect has been provided. See attached.
Could you please consider to apply it?
Regards,
Dimitri.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBCAAGBQJZnXAcAAoJEMrC2LnNLKX5+9QH/RKWXFEwf1Eds9MAZoog4d/Q
vF3FUL4iyBEeIYcE50yMFXhxBagam/T3RgtN/XB31l7ud8qAkyS/W/aq/rVpTBeB
BVGHNKHR3KFUdYJWNBxu7Cjj5EFW2GNE30j3lVs4/RA4kkfiI6N6ylGKa3m41I1g
1yggZTcDXl/4CZb1hAWNnIE6jlLYvbdj5Hi3w5VSLvwefy9sPIBQipxNC0v1rC6B
ia9tgRi3n5t0TDfrcwDSqgiAWhDpeWiI7anU5zmK8MauTLM3M3bC7oLtozsRvYs+
gdRUXmPMcykP3aXcw48l1JaMQGl23KZ7KLf1aTRi6obL6g0W4fXoWCgR4Zd9XnY=
=47co
-----END PGP SIGNATURE-----
>From 7d959c5ff48978853b01c43e959236988a46a018 Mon Sep 17 00:00:00 2001
From: Brahadambal Srinivasan <[email protected]>
Date: Fri, 23 Jun 2017 11:13:27 +0530
Subject: [PATCH] Changes run.vpdupdate creation path from /var/lib/lsvpd to
/run
Process '/bin/touch /var/lib/lsvpd/run.vpdupdate' failed with
exit code 1.
Canonical folks suggested that it can happen if any of below condition meets:
- If it's running before /var/lib/lsvpd is mounted
- If it's being run while the root filesystem is still mounted read only?
and suggested to create file under /run/ if we are not worried about file data.
Advantage when we create file under /run:
- If udev triggers libvpd rules before mounting /var or even if it is
read-only then also we won't get above mentioned issue.
This patch changes run.vpdupdate file creation path from /var/lib/lsvpd/ to /run/ .
Signed-off-by: Brahadambal Srinivasan <[email protected]>
Tested-by: Ankit Kumar <[email protected]>
Reviewed-by: Ankit Kumar <[email protected]>
Signed-off-by: Vasant Hegde <[email protected]>
---
90-vpdupdate.rules | 2 +-
Makefile.am | 2 --
libvpd.spec.in | 1 -
src/vpdretriever.cpp | 4 ++--
4 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/90-vpdupdate.rules b/90-vpdupdate.rules
index d332c3c..5a4b42d 100644
--- a/90-vpdupdate.rules
+++ b/90-vpdupdate.rules
@@ -1 +1 @@
-KERNELS=="*", ACTION=="*", DEVPATH=="/devices/*", RUN+="/bin/touch /var/lib/lsvpd/run.vpdupdate"
+KERNELS=="*", ACTION=="*", DEVPATH=="/devices/*", RUN+="/bin/touch /run/run.vpdupdate"
diff --git a/Makefile.am b/Makefile.am
index 6788e43..2bd2326 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -67,7 +67,5 @@ libtool: $(LIBTOOL_DEPS)
install-exec-hook:
mkdir -p $(DESTDIR)/${sysconfdir}/udev/rules.d/
mkdir -p $(DESTDIR)/${localstatedir}/lib/lsvpd/
- install -D --mode=644 run.vpdupdate \
- ${DESTDIR}/${localstatedir}/lib/lsvpd/run.vpdupdate
install -D --mode=644 90-vpdupdate.rules \
${DESTDIR}/${sysconfdir}/udev/rules.d/90-vpdupdate.rules
diff --git a/libvpd.spec.in b/libvpd.spec.in
index c05bacf..71f9101 100644
--- a/libvpd.spec.in
+++ b/libvpd.spec.in
@@ -53,7 +53,6 @@ Contains header files for building with libvpd.
%{_libdir}/libvpd_cxx-@[email protected].*
%{_libdir}/libvpd-@[email protected].*
%{_sysconfdir}/udev/rules.d/90-vpdupdate.rules
-%{_var}/lib/lsvpd/run.vpdupdate
%files devel
%defattr(-,root,root,-)
diff --git a/src/vpdretriever.cpp b/src/vpdretriever.cpp
index 6f7f137..9f7e7a0 100644
--- a/src/vpdretriever.cpp
+++ b/src/vpdretriever.cpp
@@ -44,7 +44,7 @@ namespace lsvpd
{
const string VpdRetriever::DEFAULT_DIR ( "/var/lib/lsvpd/" );
const string VpdRetriever::DEFAULT_FILE ( "vpd.db" );
- const string VpdRetriever::UDEV_NOTIFY_FILE ( "run.vpdupdate" );
+ const string VpdRetriever::UDEV_NOTIFY_FILE ( "/run/run.vpdupdate" );
VpdRetriever::VpdRetriever( string envDir,
string dbFileName ) throw( VpdException& )
@@ -63,7 +63,7 @@ namespace lsvpd
{
struct stat vpd_stat,udev_stat;
const string vpddb = VpdRetriever::DEFAULT_DIR + VpdRetriever::DEFAULT_FILE;
- const string udev_file = VpdRetriever::DEFAULT_DIR + VpdRetriever::UDEV_NOTIFY_FILE;
+ const string udev_file = VpdRetriever::UDEV_NOTIFY_FILE;
Logger logger;
int flag = 1;
--
2.9.3
--- End Message ---
--- Begin Message ---
Source: libvpd
Source-Version: 2.2.5-3
We believe that the bug you reported is fixed in the latest version of
libvpd, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Frédéric Bonnard <[email protected]> (supplier of updated libvpd
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 27 Sep 2017 15:06:21 +0000
Source: libvpd
Binary: libvpd-2.2-2 libvpd-dev
Architecture: source
Version: 2.2.5-3
Distribution: unstable
Urgency: medium
Maintainer: Frédéric Bonnard <[email protected]>
Changed-By: Frédéric Bonnard <[email protected]>
Description:
libvpd-2.2-2 - VPD Database access library
libvpd-dev - VPD Database access library development files
Closes: 872993
Changes:
libvpd (2.2.5-3) unstable; urgency=medium
.
* d/p/0001-Changes-run.vpdupdate-creation-path-from-var-lib-lsv.patch
Use runtime directory for the udev notify file, instead of
/var/lib. Thanks Dimitri John Ledkov. (Closes: #872993)
* d/control :
- Fix accents in my name
* d/control : upgrade Standard-version to 4.1.0
- Use Priority optional instead of extra
- d/copyright : using https for Format
Checksums-Sha1:
e025dba1446c0c8b3de5553af76bf9977dcf828f 1847 libvpd_2.2.5-3.dsc
04b134ca597634b6ef05b6ee5825d18efc1d6d37 5944 libvpd_2.2.5-3.debian.tar.xz
Checksums-Sha256:
096fff851e90f85665ca0995452217a4265cbd476a7194d1a4c1ad47a027228c 1847
libvpd_2.2.5-3.dsc
0c12340147898d26c08c4961418ca2461b80481545b9e2d04c12087ce29ef090 5944
libvpd_2.2.5-3.debian.tar.xz
Files:
aa2398612ba03ad8bf897ab1cfb1a212 1847 libs optional libvpd_2.2.5-3.dsc
29937ea3b0950f5a6d144da7eb886a5d 5944 libs optional
libvpd_2.2.5-3.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIcBAEBCgAGBQJZzO1CAAoJEGt0mPy5s1is5pQP/jdYJ3EKHSDES+8TJyJCmlij
3OeFtesuo1RwSZCz0rKHqNw/CqxC+hpqEd+Wa3YwPeSW4ivGKQFf4J9F6jXN3/QP
PEZKIGIGGa0G1ldTDo4TOoHf5HXSQXNEzgILG9rlpJz6cTY4f2EWhOVnookj09LT
xL6jrxH7+lyy3GooLFNyw/QRSmJobKyG4Hsba3PNSvnQeZ8B0RDz74JfuDsfhgAu
nUh9cw1Hbsq0QxW5mNq9+kMtr1c/72ESZWm7IzTkCR75mBEyzvHOkEDPwVgAQUt3
jeFB21ieEQAv52hShNmyb+WQqmEmDtZOMYi7wksupWwBSsKG8QSOQU54AiKa1EAs
UHjloHJ6cp1yhh5K6kl1wpxSE6MhuxZOufM4jSI+Bq5ZsGQuOUSZiQUABQ1gli6f
x2Ot0ZEqVqqo14pjUkVJI/4ih1oacQ0kER8SnNVyGyKdjErV05LjPWzo0/Z8g9Un
1eRhiqTVjqYHEdZMnfl0zaqJ8zLsfoyGzUks/rNUwHrARWZTLJsaBWHXrCm+yzdE
jduvZV9wmwollvVbm1pAsXjf8UpYoh+F1MdX0R68XLmVVdA4JpSS3XUrRmx9nQg9
yfOISsQy496zR6pz6+cy4dFpvmoj0AGZaPD11AZhRQmsnAzzNhXuPXoFtk5UHSJk
74yH7mMA7AU1/78RXB2v
=gcjd
-----END PGP SIGNATURE-----
--- End Message ---
