Your message dated Fri, 13 Oct 2017 09:04:47 +0000 with message-id <[email protected]> and subject line Bug#876354: fixed in mozjs52 52.3.1-5 has caused the Debian Bug report #876354, regarding mozjs52: FTBFS with SHELL=/bin/zsh: Could not detect environment shell! to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 876354: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=876354 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Source: mozjs52 Version: 52.3.1-4 Severity: important Tags: patch Steps to reproduce: Build mozjs52 on zelenka and minkus (s390x and mips porterboxes) from an account like mine with SHELL=/bin/zsh Expected result: Build succeeds, but tests fail due to #873778 Actual result: > Creating config.status > Traceback (most recent call last): > File "./../../configure.py", line 107, in <module> > sys.exit(main(sys.argv)) > File "./../../configure.py", line 31, in main > return config_status(config) > File "./../../configure.py", line 92, in config_status > from mozbuild.config_status import config_status > File "/home/smcv/mozjs52-52.3.1/build/mach_bootstrap.py", line 370, in > __call__ > module = self._original_import(name, globals, locals, fromlist, level) > File "/home/smcv/mozjs52-52.3.1/python/mozbuild/mozbuild/config_status.py", > line 21, in <module> > from mozbuild.base import MachCommandConditions > File "/home/smcv/mozjs52-52.3.1/build/mach_bootstrap.py", line 370, in > __call__ > module = self._original_import(name, globals, locals, fromlist, level) > File "/home/smcv/mozjs52-52.3.1/python/mozbuild/mozbuild/base.py", line 17, > in <module> > from mach.mixin.process import ProcessExecutionMixin > File "/home/smcv/mozjs52-52.3.1/build/mach_bootstrap.py", line 370, in > __call__ > module = self._original_import(name, globals, locals, fromlist, level) > File "/home/smcv/mozjs52-52.3.1/python/mach/mach/mixin/process.py", line > 29, in <module> > raise Exception('Could not detect environment shell!') > Exception: Could not detect environment shell! > debian/rules:38: recipe for target 'override_dh_auto_configure' failed debian/rules sets SHELL and PYTHON before invoking ./configure, but the syntax is wrong: it is just setting "shell parameters" (variables), not environment variables, so they won't be exported into configure's environment unless they were already exported. Also, it looks as though SHELL may need to be exported during make, not just configure. It seems safest to export them globally, as in the attached patch. Upstream for this package seem to have missed some subtleties of how $SHELL normally works. As the GNU Make documentation puts it: > Unlike most variables, the variable 'SHELL' is never set from the > environment. This is because the 'SHELL' environment variable is used > to specify your personal choice of shell program for interactive use. > It would be very bad for personal choices like this to affect the > functioning of makefiles. Regards, smcv (still no closer to understanding the test failures...)>From cf19a4602442c908c489c52da372a74e140d6451 Mon Sep 17 00:00:00 2001 From: Simon McVittie <[email protected]> Date: Thu, 21 Sep 2017 10:13:45 +0100 Subject: [PATCH] Export SHELL and PYTHON for all stages of the build process (Closes: #nnnnnn) --- debian/changelog | 7 +++++++ debian/rules | 6 +++++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/debian/changelog b/debian/changelog index cc81af8a..189c5bec 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +mozjs52 (52.3.1-5) UNRELEASED; urgency=medium + + * Export SHELL and PYTHON for all stages of the build process + (Closes: #nnnnnn) + + -- Simon McVittie <[email protected]> Thu, 21 Sep 2017 10:10:10 +0100 + mozjs52 (52.3.1-4) unstable; urgency=medium [ Jeremy Bicha ] diff --git a/debian/rules b/debian/rules index b62ced55..f903238e 100755 --- a/debian/rules +++ b/debian/rules @@ -7,6 +7,10 @@ DEB_HOST_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE) DEB_BUILD_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE) DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH) +# mozjs' build process does not seem to be compatible with other shells +# like zsh +export SHELL = /bin/sh +export PYTHON = python SRCDIR = $(CURDIR)/js/src @@ -35,7 +39,7 @@ override_dh_clean: # scripts, so we call configure ourselves. # http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=570375 override_dh_auto_configure: - cd $(SRCDIR) && SHELL=/bin/sh && PYTHON=python && $(SHELL) configure \ + cd $(SRCDIR) && $(SHELL) configure \ --host=$(DEB_HOST_GNU_TYPE) \ --target=$(DEB_BUILD_GNU_TYPE) \ --prefix=/usr \ -- 2.14.1
--- End Message ---
--- Begin Message ---Source: mozjs52 Source-Version: 52.3.1-5 We believe that the bug you reported is fixed in the latest version of mozjs52, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Simon McVittie <[email protected]> (supplier of updated mozjs52 package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Fri, 13 Oct 2017 00:24:00 +0100 Source: mozjs52 Binary: libmozjs-52-0 libmozjs-52-dev Architecture: source Version: 52.3.1-5 Distribution: unstable Urgency: medium Maintainer: Debian GNOME Maintainers <[email protected]> Changed-By: Simon McVittie <[email protected]> Description: libmozjs-52-0 - SpiderMonkey JavaScript library libmozjs-52-dev - SpiderMonkey JavaScript library - development headers Closes: 873778 876354 Changes: mozjs52 (52.3.1-5) unstable; urgency=medium . * Team upload . [ Simon McVittie ] * Regenerate patches * Export SHELL and PYTHON for all stages of the build process (Closes: #876354) * d/p/Allow-to-override-ICU_DATA_FILE-from-the-environment.patch: Add patch from firefox-esr to allow ICU_DATA_FILE to be forced in the environment. We need to use a big-endian version on BE architectures. * d/p/Patch-pregenerated-old-configure-to-match-build-autoconf-.patch: Apply the equivalent of that patch to the pregenerated old-configure script * d/p/Add-intl-icu_sources_data.py-from-firefox-esr.patch: Add patch importing intl/icu_sources_data.py from firefox-esr_52.4.0esr-2 so we can regenerate the ICU_DATA_FILE * d/rules: Regenerate the ICU_DATA_FILE (with the correct endianness) so the interpreter doesn't fail to initialize on big-endian architectures (Closes: #873778) * d/p/icu_sources_data.py-Decouple-from-Mozilla-build-system.patch: Avoid needing the mozpack module to generate the ICU_DATA_FILE * d/p/Fix-crashes-in-AtomicOperations-none-on-s390x.patch: Add patch from firefox-esr to fix atomic operations crashes on s390x * d/p/icu_sources_data-Write-command-output-to-our-stderr.patch: Make sure output from icu_sources_data.py ends up in buildd logs * d/p/tests-For-tests-that-are-skipped-on-64-bit-mips64-is-also.patch: Count mips64 as a 64-bit architecture for the purposes of skipping tests * d/rules: Run a "hello, world" program before running the test suite. If mozjs fails to initialize on a platform, the diagnostics given are fairly useless; try something much simpler before we go to the effort of running the full test suite. Failure to run this program causes FTBFS, to make sure we won't ship completely useless builds. * d/test.sh: Wrap build-time tests, making test-suite failures non-fatal on architectures with known issues (downgrades severity of: #877428, #878284, #878285, #878286) * d/rules: Skip build-time tests if cross-compiling * d/rules: Run icu build with VERBOSE=1 to see compilation commands . [ Jeremy Bicha ] * Add Don-t-include-xlocale.patch: Fix build with glibc >= 2.26 Checksums-Sha1: 9c503cc35159f4ffe0299180e6df9ec6cd4309fd 2200 mozjs52_52.3.1-5.dsc 5537d316f10fe5ec73f579e637d13621d0cc453e 70060 mozjs52_52.3.1-5.debian.tar.xz 7e350568e2206d0ac73b023c208848c0bc3f31f1 6073 mozjs52_52.3.1-5_source.buildinfo Checksums-Sha256: 6f33a01d3c2ce9685fef4a17eab57efb01c9d3f8f31efc8fec1a4b9374129156 2200 mozjs52_52.3.1-5.dsc 60ef140120366be14ae26143167e02d12b4c88e21a2bf8b6a36ddf42937d321b 70060 mozjs52_52.3.1-5.debian.tar.xz 033fc78fb0e37641c37e1d7e9501f6be38a5ec3c9993189815517e444853347a 6073 mozjs52_52.3.1-5_source.buildinfo Files: d416ae475ef8714490060f32fe667572 2200 libs optional mozjs52_52.3.1-5.dsc 83c6fc4cca5582a90004de38c88d201a 70060 libs optional mozjs52_52.3.1-5.debian.tar.xz a81fd9cc0f9ce244d61eea4446da6037 6073 libs optional mozjs52_52.3.1-5_source.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEENuxaZEik9e95vv6Y4FrhR4+BTE8FAlngfZcACgkQ4FrhR4+B TE+mEA//d5ZMLOYh0g4N2CQhYokRChBYDpYBxy2Zhf76cHgbWwkknrAvsLtG1+VM AUrJWdEIwaGKb6jz/dg1NO6B6vJ9yLxa90gEA0p9N5m8p/i8wGfUI+loJAWPsz07 K4lb+vLHC6dGRterd96Z/tilREP4kdX9h7fA2BDIRoAhELIn9stKlMT6qiujj97r KdzA/1H8MuWis8H9sH3+5jPG4tlpCUnzbD0dFc+xc548XO6MwXp/cG8EKT8G9H8M 5H31CNgLfaQ1fWfBuiKnukWmNl0mySbKiipoJVozbNFIy8/lCL8zXqRyye+MRmGy H1vNx7fO16nes0rZsmK7Ljpxlo04XlYSYENLs3h4ylGm92fmwykUkb7374Y72+hy mu7bkOXxCBabRw8KTiTa0TzVxgCfrL4BbnjPkBoKcdItWWxDOf0rM+ImUXnm896k pEfq6r4khl2h+YeJhi7U1W15Y8B5Hrj5N2k3AXh310F0rHWV+UD50YJ039UIXI+W IjbLNZmkCeF04J6eFIOd2qCk9hYpkq/QaTVU2vZMqKQFpptGhJBjS32S6vxTQCeG Z8pn3p84xcXHl5NpK/zpxxU8DbgjKYNlM6Pv221KMq/5gT6irsk8ciXs6rsHhzH2 96rElSkMtPPIoWD7frYTfQH6w75jNs1BxoA4yeazf6/Nw5erFuA= =JLPe -----END PGP SIGNATURE-----
--- End Message ---
