Your message dated Mon, 06 Nov 2017 15:14:55 +0000
with message-id <[email protected]>
and subject line Bug#878024: fixed in geoip 1.6.11-3
has caused the Debian Bug report #878024,
regarding geoip: Fixes for compatibility with g++7
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
878024: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=878024
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: geoip
Version: 1.6.11-2
Severity: important
Tags: patch
Justification: FTBFS
User: [email protected]
Usertags: origin-ubuntu artful ubuntu-patch
Hi Patrick,
The geoip package failed to build in Ubuntu with glibc 2.26 during a test
rebuild. I expect this build failure will also affect Debian soon, once
unstable moves to the new version of glibc.
x86_64-linux-gnu-g++ -Wdate-time -D_FORTIFY_SOURCE=2 -std=gnu++98
-Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -g
debian/src/geoip-csv-to-dat.cpp -o debian/ tmp/geoip-generator -lGeoIP \
-I /<<PKGBUILDDIR>>/debian/tmp/usr/include/ -L
/<<PKGBUILDDIR>>/debian/tmp/usr/lib/x86_64-linux-gnu/
debian/src/geoip-csv-to-dat.cpp:173:11: error: ‘uint_fast32_t’ does not name
a type; did you mean ‘uint32_t’?
typedef uint_fast32_t edge_type;
^~~~~~~~~~~~~
uint32_t
debian/src/geoip-csv-to-dat.cpp:176:4: error: ‘edge_type’ does not name a type
edge_type edges[2];
^~~~~~~~~
[...]
https://launchpad.net/ubuntu/+archive/test-rebuild-20170922/+build/13422915/+files/buildlog_ubuntu-artful-amd64.geoip_1.6.11-2_BUILDING.txt.gz
The attached patch fixes compatibility with the newer glibc+gcc. Please
consider applying this to Debian.
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
[email protected] [email protected]
diff -Nru geoip-1.6.11/debian/files geoip-1.6.11/debian/files
--- geoip-1.6.11/debian/files 1969-12-31 19:00:00.000000000 -0500
+++ geoip-1.6.11/debian/files 2017-10-08 14:45:02.000000000 -0400
@@ -0,0 +1 @@
+geoip_1.6.11-2ubuntu1_source.buildinfo net optional
diff -Nru geoip-1.6.11/debian/rules geoip-1.6.11/debian/rules
--- geoip-1.6.11/debian/rules 2017-07-03 03:36:15.000000000 -0400
+++ geoip-1.6.11/debian/rules 2017-10-08 14:43:08.000000000 -0400
@@ -15,9 +15,9 @@
override_dh_auto_install:
$(MAKE) install DESTDIR=$(CURDIR)/debian/tmp
# Build the build script.
- $(CXX) $(CPPFLAGS) -std=gnu++98 $(LDFLAGS) -g
debian/src/geoip-csv-to-dat.cpp -o debian/tmp/geoip-generator -lGeoIP \
+ $(CXX) $(CPPFLAGS) -std=gnu++11 $(LDFLAGS) -g
debian/src/geoip-csv-to-dat.cpp -o debian/tmp/geoip-generator -lGeoIP \
-I $(CURDIR)/debian/tmp/usr/include/ -L
$(CURDIR)/debian/tmp/usr/lib/$(DEB_HOST_MULTIARCH)/
- $(CXX) $(CPPFLAGS) -std=gnu++98 $(LDFLAGS) -g
debian/src/geoip-asn-csv-to-dat.cpp -o debian/tmp/geoip-generator-asn -lGeoIP \
+ $(CXX) $(CPPFLAGS) -std=gnu++11 $(LDFLAGS) -g
debian/src/geoip-asn-csv-to-dat.cpp -o debian/tmp/geoip-generator-asn -lGeoIP \
-I $(CURDIR)/debian/tmp/usr/include/ -L
$(CURDIR)/debian/tmp/usr/lib/$(DEB_HOST_MULTIARCH)/
chrpath -d -k debian/tmp/usr/bin/geoip*
diff -Nru geoip-1.6.11/debian/src/geoip-asn-csv-to-dat.cpp
geoip-1.6.11/debian/src/geoip-asn-csv-to-dat.cpp
--- geoip-1.6.11/debian/src/geoip-asn-csv-to-dat.cpp 2017-07-03
03:36:15.000000000 -0400
+++ geoip-1.6.11/debian/src/geoip-asn-csv-to-dat.cpp 2017-10-08
14:44:15.000000000 -0400
@@ -708,13 +708,13 @@
switch (address_family) {
case AF_INET: {
- const char structure_info[4] = { 0xFF, 0xFF, 0xFF, 9 };
- dat_stream.write(structure_info, 4);
+ const unsigned char structure_info[4] = { 0xFF, 0xFF,
0xFF, 9 };
+ dat_stream.write((const char *)structure_info, 4);
break;
}
case AF_INET6: {
- const char structure_info[4] = { 0xFF, 0xFF, 0xFF, 21 };
- dat_stream.write(structure_info, 4);
+ const unsigned char structure_info[4] = { 0xFF, 0xFF,
0xFF, 21 };
+ dat_stream.write((const char *)structure_info, 4);
break;
}
default:
diff -Nru geoip-1.6.11/debian/src/geoip-csv-to-dat.cpp
geoip-1.6.11/debian/src/geoip-csv-to-dat.cpp
--- geoip-1.6.11/debian/src/geoip-csv-to-dat.cpp 2017-07-03
03:36:15.000000000 -0400
+++ geoip-1.6.11/debian/src/geoip-csv-to-dat.cpp 2017-10-08
14:42:30.000000000 -0400
@@ -680,8 +680,8 @@
void dat_writer::write_structure_info()
{
- const char structure_info[4] = { 0xFF, 0xFF, 0xFF, database_type };
- dat_stream->write(structure_info, 4);
+ const unsigned char structure_info[4] = { 0xFF, 0xFF, 0xFF,
database_type };
+ dat_stream->write((const char *)structure_info, 4);
}
/*************************************************
@@ -804,14 +804,14 @@
{
int trie_size = std::distance(trie.nodes_begin(), trie.nodes_end());
- const char structure_info[7] = { 0xFF,
- 0xFF,
- 0xFF,
- database_type,
- (trie_size ) & 0xFF,
- (trie_size >> 8 ) & 0xFF,
- (trie_size >> 16) & 0xFF};
- dat_stream->write(structure_info, 7);
+ const unsigned char structure_info[7] = { 0xFF,
+ 0xFF,
+ 0xFF,
+ database_type,
+ (trie_size ) & 0xFF,
+ (trie_size >> 8 ) & 0xFF,
+ (trie_size >> 16) & 0xFF};
+ dat_stream->write((const char *)structure_info, 7);
}
/** Convert location info into on-disk format
--- End Message ---
--- Begin Message ---
Source: geoip
Source-Version: 1.6.11-3
We believe that the bug you reported is fixed in the latest version of
geoip, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Patrick Matthäi <[email protected]> (supplier of updated geoip package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Mon, 06 Nov 2017 14:56:05 +0100
Source: geoip
Binary: libgeoip1 libgeoip-dev geoip-bin
Architecture: source amd64
Version: 1.6.11-3
Distribution: unstable
Urgency: medium
Maintainer: Patrick Matthäi <[email protected]>
Changed-By: Patrick Matthäi <[email protected]>
Description:
geoip-bin - IP lookup command line tools that use the GeoIP library
libgeoip-dev - Development files for the GeoIP library
libgeoip1 - non-DNS IP-to-country resolver library
Closes: 878024
Changes:
geoip (1.6.11-3) unstable; urgency=medium
.
* Bump Standards-Version to 4.1.1 (no changes required).
* Add patch from Steve Langasek to fix compatibility with g++7. Much thanks!
Closes: #878024
* Use secure homepage URI.
Checksums-Sha1:
cf57b6712f0a753144303bbc55bd8e92fe9050e7 1860 geoip_1.6.11-3.dsc
4ea4af2116903db0359c67d3d41ea4b9c1a22467 22320 geoip_1.6.11-3.debian.tar.xz
085c2897ff879d802d0f262cb07dd0695821d6c0 237472
geoip-bin-dbgsym_1.6.11-3_amd64.deb
c32bb24c39ce8303fd78e03af95d2b8e5da5d202 67328 geoip-bin_1.6.11-3_amd64.deb
1487c3ebb4a00fb45382f5afdee6125e0e7935d1 7000 geoip_1.6.11-3_amd64.buildinfo
1d0d3ab32c25f7ad1226df490a56fc45ca8e690e 98532 libgeoip-dev_1.6.11-3_amd64.deb
455c6ffe241e151c04ad098d724d3b2e8abc6f3b 136884
libgeoip1-dbgsym_1.6.11-3_amd64.deb
2db14b17ec4d983151f1084aeff85cda50a7e04b 89748 libgeoip1_1.6.11-3_amd64.deb
Checksums-Sha256:
a7ba2d089173c9774b61a598367e8944fec78200399e84e2e4b11ec5cc793016 1860
geoip_1.6.11-3.dsc
c3a704cbeb83c9df2006b404de91d3a0e45d3a99c36a9f530c33747c4c59b7c8 22320
geoip_1.6.11-3.debian.tar.xz
966c4f9dbc0955cc4c2981c9f4dc3864fa133dbd97d8a116d97325446214775d 237472
geoip-bin-dbgsym_1.6.11-3_amd64.deb
b5cb6d6ab904f4f28b07d1905f992f94fcb73b9c712962be2988098efbc86b4c 67328
geoip-bin_1.6.11-3_amd64.deb
c0e346f19ddface9a808dd4e700a705a9ea6dfdd989bf1798489da20c695948e 7000
geoip_1.6.11-3_amd64.buildinfo
29eddb723b14694e64bcf5ee734f70034a5d47e2db1aa8f54f15ecbd06ca01ed 98532
libgeoip-dev_1.6.11-3_amd64.deb
5b6a8b86f42e02d7681a1f58500369516ea5e92ff288958a1b90ec036003e47e 136884
libgeoip1-dbgsym_1.6.11-3_amd64.deb
10ccc0c698d580ba3b9786f414953acf1ecfbfb43fdee354213847eb631c8ac1 89748
libgeoip1_1.6.11-3_amd64.deb
Files:
d92c1bde736788b40f1f95e5caa6beb9 1860 net optional geoip_1.6.11-3.dsc
93ac29c8bffa31dfeb0002f119f95902 22320 net optional
geoip_1.6.11-3.debian.tar.xz
b712d2380c281b1a6934786cb8643ed6 237472 debug optional
geoip-bin-dbgsym_1.6.11-3_amd64.deb
c615968695d461197a598742d83962c4 67328 net optional
geoip-bin_1.6.11-3_amd64.deb
1f6aa3e8abdf1c1267c58ee128f928d6 7000 net optional
geoip_1.6.11-3_amd64.buildinfo
d8d61467d62f5607488d6defb81bf82a 98532 libdevel optional
libgeoip-dev_1.6.11-3_amd64.deb
7daf654e2b3bbe4658ca906b820193dd 136884 debug optional
libgeoip1-dbgsym_1.6.11-3_amd64.deb
316911bbab2830d996103be195bb896e 89748 libs optional
libgeoip1_1.6.11-3_amd64.deb
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEWKA9xYJCWk3IuQ4TEtmwSpDL2OQFAloAbkkACgkQEtmwSpDL
2OSSgBAAkRwy19TNUb6bWscxcrP+WVX6YaJ3N6YsPMblO+BlK2SMIv0MAoaCCrmD
D3Mev9hu8r1Owmw+ZXeV5gmpwLohplo37q+CmON/8YUchdc9cyJycwH69LAaLBmc
8s4j1Ca4OD4XvgFBBa7kVLGepZA+0dPvUcJqRz2HDA28eJ+/WS9Ip4lqZI3QuJ+8
BYfpvvxGgaT+w2E3OeTwvX57+sOiOicrJFOXGNR2mySEV53VB3dDy/n4YnzCXv9+
Y9WJwE0WVyd5BS0ciAhgB1wEuZL1rWXpoASwXlKL64yI/9Jr+Y1tODF5HYEMndRe
NQTMFOhm51QZ3S/NB0c5pWnpvscq+3ie8UaWe/bDoDk1IqHPXv03IyGxPqMJtuns
a0D0QsS4XlgN/zF9/iZf+KhMAp/CK5c6ExbaQMJ3DEI80pBnSeJbTZqnlEevRbz+
iA+mpkS5iVC2xjE65e60h3CMsge+qTsQGF1dA7aLVqPFQ9g4Jx7e6zaee8dccgCD
hTvHeotAXHXgdjL0sR2ScSgts7Qjr0pUk3FSXhLGiHjqC+A0sdpBVKGfy5yLohuV
i2EJ/tg7jULtEhzgm+7t3XgsIKG6bBnTUeCl69MJNfyq8IDE5LNHnrwH4ujvVKNR
U6xw3tRYgWxF+C+AiJvoAlNFjuSrw40rGEpmEjTshUjifK3d1ZI=
=Ml1L
-----END PGP SIGNATURE-----
--- End Message ---
