Your message dated Sat, 18 Nov 2017 18:08:29 +0100
with message-id <87tvxrldki....@logic.part.iki.fi>
and subject line Re: Bug#688594: Conflicting types of ConfigureParams due to 
wrong include order
has caused the Debian Bug report #688594,
regarding Conflicting types of ConfigureParams due to wrong include order
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
688594: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=688594
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: hatari
Version: 1.6.2-1

While building the package using our research compiler infrastructure we noticed
that ConfigureParams was declared with conflicting types for src/audio.c (and
possibly others) vs. src/debug/evaluate.c when building in build-winuae:
ENABLE_WINUAE_CPU, as set in config.h, must be consistently seen before
configuration.h, but note the following order of includes:

audio.c:

#include "main.h"
#include "audio.h"
#include "configuration.h"  (includes config.h)



evaluate.c

#include "configuration.h"
...
#include "main.h"  (includes config.h)


As the storage sizes of the two structs are entirely different, this may lead to
arbitrary undefined behaviour when accessing ConfigureParams.

Best,
Michael

Attachment: pgpE788O1TEQw.pgp
Description: PGP signature


--- End Message ---
--- Begin Message ---
fixed 688594 2.0.0+dfsg-1
thanks

--- End Message ---

Reply via email to