Your message dated Sun, 17 Dec 2017 22:49:52 +0000
with message-id <[email protected]>
and subject line Bug#880388: fixed in mrpt 1:1.5.5-1
has caused the Debian Bug report #880388,
regarding mrpt: Please don't use unaligned access on ARM
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
880388: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=880388
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: mrpt
Version: 1:1.5.3-1
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu bionic ubuntu-patch
Hi José Luis,
The new upstream release of mrpt fails to build on armhf in Ubuntu, because
it assumes unaligned reads are allowed. This is not a portable assumption;
specifically, on armhf this may raise a SIGBUS depending on the CPU and the
kernel configuration.
The Ubuntu infrastructure does raise SIGBUS, so I've uploaded the attached
patch to Ubuntu to fix the failure. Please consider applying this in Debian
as well, where it make affect some number of users even if it doesn't
trigger on Debian infrastructure.
Thanks,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
[email protected] [email protected]
diff -Nru mrpt-1.5.3/debian/patches/no-unaligned-access
mrpt-1.5.3/debian/patches/no-unaligned-access
--- mrpt-1.5.3/debian/patches/no-unaligned-access 1969-12-31
16:00:00.000000000 -0800
+++ mrpt-1.5.3/debian/patches/no-unaligned-access 2017-10-30
23:29:50.000000000 -0700
@@ -0,0 +1,19 @@
+Description: use alignment-safe buffers for our timevals.
+ Casting a char* to anything larger is not universally safe due to alignment
+ constraints on some platforms. So declare our buffer in terms of a 64-bit
+ type to ensure architecture-appropriate alignment from the compiler.
+Author: Steve Langasek <[email protected]>
+
+Index: mrpt-1.5.3/libs/base/include/mrpt/utils/CTicTac.h
+===================================================================
+--- mrpt-1.5.3.orig/libs/base/include/mrpt/utils/CTicTac.h
++++ mrpt-1.5.3/libs/base/include/mrpt/utils/CTicTac.h
+@@ -28,7 +28,7 @@
+ void Tic(); //!< Starts the stopwatch. \sa Tac
+ double Tac(); //!< Stops the stopwatch. \return Returns the
ellapsed time in seconds. \sa Tic
+ private:
+- unsigned char largeInts[64];
++ unsigned long long largeInts[8];
+ }; // End of class def.
+
+ } // End of namespace
diff -Nru mrpt-1.5.3/debian/patches/series mrpt-1.5.3/debian/patches/series
--- mrpt-1.5.3/debian/patches/series 1969-12-31 16:00:00.000000000 -0800
+++ mrpt-1.5.3/debian/patches/series 2017-10-30 23:29:38.000000000 -0700
@@ -0,0 +1 @@
+no-unaligned-access
--- End Message ---
--- Begin Message ---
Source: mrpt
Source-Version: 1:1.5.5-1
We believe that the bug you reported is fixed in the latest version of
mrpt, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
José Luis Blanco Claraco <[email protected]> (supplier of updated mrpt
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Fri, 01 Dec 2017 07:13:14 +0100
Source: mrpt
Binary: mrpt-doc libmrpt-base1.5 libmrpt-opengl1.5 libmrpt-gui1.5
libmrpt-obs1.5 libmrpt-maps1.5 libmrpt-hwdrivers1.5 libmrpt-graphslam1.5
libmrpt-vision1.5 libmrpt-tfest1.5 libmrpt-topography1.5 libmrpt-detectors1.5
libmrpt-slam1.5 libmrpt-nav1.5 libmrpt-hmtslam1.5 libmrpt-kinematics1.5
libmrpt-graphs1.5 libmrpt-dev mrpt-common mrpt-apps
Architecture: source
Version: 1:1.5.5-1
Distribution: unstable
Urgency: medium
Maintainer: José Luis Blanco Claraco <[email protected]>
Changed-By: José Luis Blanco Claraco <[email protected]>
Description:
libmrpt-base1.5 - Mobile Robot Programming Toolkit - base library
libmrpt-detectors1.5 - Mobile Robot Programming Toolkit - detectors library
libmrpt-dev - Mobile Robot Programming Toolkit - Development headers
libmrpt-graphs1.5 - Mobile Robot Programming Toolkit - graphs library
libmrpt-graphslam1.5 - Mobile Robot Programming Toolkit - graphslam library
libmrpt-gui1.5 - Mobile Robot Programming Toolkit - gui library
libmrpt-hmtslam1.5 - Mobile Robot Programming Toolkit - hmtslam library
libmrpt-hwdrivers1.5 - Mobile Robot Programming Toolkit - hwdrivers library
libmrpt-kinematics1.5 - Mobile Robot Programming Toolkit - kinematics library
libmrpt-maps1.5 - Mobile Robot Programming Toolkit - maps library
libmrpt-nav1.5 - Mobile Robot Programming Toolkit - nav library
libmrpt-obs1.5 - Mobile Robot Programming Toolkit - obs library
libmrpt-opengl1.5 - Mobile Robot Programming Toolkit - opengl library
libmrpt-slam1.5 - Mobile Robot Programming Toolkit - slam library
libmrpt-tfest1.5 - Mobile Robot Programming Toolkit - tfest library
libmrpt-topography1.5 - Mobile Robot Programming Toolkit - topography library
libmrpt-vision1.5 - Mobile Robot Programming Toolkit - vision library
mrpt-apps - Mobile Robot Programming Toolkit - Console and GUI applications
mrpt-common - Mobile Robot Programming Toolkit - Example datasets and files
mrpt-doc - Mobile Robot Programming Toolkit - Documentation and examples
Closes: 880388
Changes:
mrpt (1:1.5.5-1) unstable; urgency=medium
.
* New version of upstream sources.
* Fix SIGBUS in armhf (Closes: #880388).
* debian/copyright: Updated to machine-readable format.
* debian/rules: disable generating Doxygen caller graphs in doc pkg.
* debian/rules: provide build-indep, test-indep, and install-indep targets.
Checksums-Sha1:
b7d6c3929f8e2c8c22eeeff2a0827f82ca7d6617 3090 mrpt_1.5.5-1.dsc
01b623fe1055b61db86118e509dc17c737c166cf 24202822 mrpt_1.5.5.orig.tar.gz
0e39e2525e9726e4a099521e2a5893cddd13b0d7 17724 mrpt_1.5.5-1.debian.tar.xz
33cd0a0ef961a4035fc77027a1399fee177fc157 21030 mrpt_1.5.5-1_source.buildinfo
Checksums-Sha256:
a89fe8d66b8a2f51399507193cf47c2d81a7dd60ae178610083266a12005026f 3090
mrpt_1.5.5-1.dsc
76000a6024ddde24b9f0d9813cd17b1780f4fbd3246e784a12596d67451f1315 24202822
mrpt_1.5.5.orig.tar.gz
36481a8deabcd9a58ad9d5ee26d8a4ba76616223ccdf80f30b261c8ae0b59056 17724
mrpt_1.5.5-1.debian.tar.xz
0dd2e4307c99419ff6e97766c320a4c1974bc8c47fe41860a18389ceebbddd4e 21030
mrpt_1.5.5-1_source.buildinfo
Files:
89636d4d957753d9f5a2d9c5f26c09d2 3090 science optional mrpt_1.5.5-1.dsc
5f235da8865acf9e161e1def407933a4 24202822 science optional
mrpt_1.5.5.orig.tar.gz
2be21523d15ee316d86da7921d0efd03 17724 science optional
mrpt_1.5.5-1.debian.tar.xz
489e84160b472f91ea1aca2a94d76165 21030 science optional
mrpt_1.5.5-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEE1Uw7+v+wQt44LaXXQc5/C58bizIFAlo274QACgkQQc5/C58b
izIQwAf/Zdsm1jlaRwrWuEl49mvCsNiTE6Q+0eCWwvSF6atHwjL3v9bjBoTVI4aW
VcNrVooQvTqHuKZewfQ3xLGjRfT4EYxBdjfYz8qMugXJHHJ5PJy7f5xeitKKMkMY
12j9hWgpMBzi5LCpI8b7h8UW+SyJPqtWJOkJLTgDBFUwi6xJIBA8C68F0Nzu+VjX
Wrdji3fcza9/gK1Iz9ksZuP1xgJDXn2UIapJuMOov8dih0X4FrZTQzMJLz5O/i/7
pa43meEnxK8Hw0VQRK3ystS4CCVSKc48jmJHftc7b9Bo0Jx2mcZHjFJLfRzgzgn4
2BFAHbc20oWzNPw2ztnC+t91Q8TN1g==
=njCH
-----END PGP SIGNATURE-----
--- End Message ---
