Your message dated Thu, 4 Jan 2018 20:52:54 -0500
with message-id <20180105015254.2qk76gbzgor2r...@zeta.ryanak.ca>
and subject line Closing
has caused the Debian Bug report #279230,
regarding rxvt: rclock icon geometry option broken
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
279230: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=279230
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: rxvt
Version: 1:2.6.4-6.2
Severity: normal
Tags: patch



-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.4.22
Locale: LANG=C, LC_CTYPE=C

Versions of packages rxvt depends on:
ii  base-passwd               3.5.7          Debian base system master password
ii  libc6                     2.3.2.ds1-12   GNU C Library: Shared libraries an
ii  libx11-6                  4.3.0.dfsg.1-8 X Window System protocol client li
ii  xlibs                     4.3.0.dfsg.1-1 X Window System client libraries m

-- no debconf information

The icon geometry option was not parsed correctly on the command line.  
The parser doesn't like the "#" option.  I don't know why.  Is this a 
bash problem?  I changed the option to "-ig".  See diff below.  I am 
mailing the edited rclock.c to the rxvt maintainer and Debian rxvt 
package maintainer in a separate mail.


*** rclock.c    Thu Aug  8 00:32:14 2002
--- rclock-tn.c Sun Oct 31 17:40:21 2004
***************
*** 213,218 ****
--- 213,219 ----
  #endif
  #ifdef ICONWIN
        { "-iconic",            "start iconic" },
+       { "-ig wxh+x+y",        "icon geometry: size and position" },
  #endif
  #ifdef ADJUST_TIME
        { "-adjust +/-ddhhmm",  "adjust clock time" },
***************
*** 225,231 ****
        { "-mailspawn cmd",     "execute `cmd` when clock is clicked" },
  #endif
  #endif
!       { "#geom",              "icon window geometry" }
     };
  
     fprintf (stderr, "\nUsage v" VERSION ":\n  " APL_NAME " [options]\n\n"
--- 226,232 ----
        { "-mailspawn cmd",     "execute `cmd` when clock is clicked" },
  #endif
  #endif
!       { }
     };
  
     fprintf (stderr, "\nUsage v" VERSION ":\n  " APL_NAME " [options]\n\n"
***************
*** 337,346 ****
         case '-':
           break;
  
-        case '#':
- #ifdef ICONWIN
-          rs_iconGeometry = opt;   /* drop */
- #endif
         default:
           continue;
           break;
--- 338,343 ----
***************
*** 349,359 ****
        if (*opt == 'd' && val)         display_name = val;     /* "d", 
"display" */
        else if (*opt == 'g' && val)    rs_geometry = val;      /* "g", 
"geometry" */
  #ifdef ICONWIN
!       else if (*opt == 'i')   /* "ic", "iconic" */
          {
             iconic_state = IconicState;
             i--;       /* no argument */
          }
  #endif
        else if (!strcmp (opt, "fg") && val)    rs_color [fgColor] = val;
        else if (!strcmp (opt, "bg") && val)    rs_color [bgColor] = val;
--- 346,361 ----
        if (*opt == 'd' && val)         display_name = val;     /* "d", 
"display" */
        else if (*opt == 'g' && val)    rs_geometry = val;      /* "g", 
"geometry" */
  #ifdef ICONWIN
!       /* Start iconic, provide icon geometry, edited by tnetter */
!       else if (!strncmp (opt, "ic", 2))
          {
             iconic_state = IconicState;
             i--;       /* no argument */
          }
+       else if (!strcmp (opt, "ig") && val)
+         {
+            rs_iconGeometry = val;   /* drop */
+         }
  #endif
        else if (!strcmp (opt, "fg") && val)    rs_color [fgColor] = val;
        else if (!strcmp (opt, "bg") && val)    rs_color [bgColor] = val;
***************
*** 955,961 ****
                * I believe this should be drawn always so it does not get
                * "swept away" by the minute hand.
      */
! #ifdef REMINDERS && DATE_ON_CLOCK_FACE
     if( show_date)
       {
        char date[10];
--- 957,964 ----
                * I believe this should be drawn always so it does not get
                * "swept away" by the minute hand.
      */
! #ifdef REMINDERS 
! #ifdef DATE_ON_CLOCK_FACE
     if( show_date)
       {
        char date[10];
***************
*** 968,973 ****
--- 971,977 ----
          date, strlen(date));
       }
  #endif
+ #endif
  
     if (full_redraw)
       {


--- End Message ---
--- Begin Message ---
Thank you for your bug report. As rxvt has been replaced by rxvt-unicode in
Debian, I am closing this bug. If you can still reproduce this bug with urxvt,
please feel free to reopen this bug and reassign it to the rxvt-unicode package.

Best wishes,
Ryan

-- 
|_)|_/  Ryan Kavanagh      | GPG: 4E46 9519 ED67 7734 268F
| \| \  https://ryanak.ca/ |      BD95 8F7B F8FC 4A11 C97A

Attachment: signature.asc
Description: PGP signature


--- End Message ---

Reply via email to