Your message dated Mon, 15 Jan 2018 10:35:51 +0000
with message-id <[email protected]>
and subject line Bug#886578: fixed in mate-user-share 1.18.0-2
has caused the Debian Bug report #886578,
regarding mate-user-share FTCBFS: wrongly uses pkg-config
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
886578: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886578
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: mate-user-share
Version: 1.18.0-1.1
Tags: patch upstream
User: [email protected]
Usertags: rebootstrap
mate-user-share fails to cross build from source, because it wrongly
uses pkg-config. The attached patch fixes all the issues and makes it
cross build. Let me briefly discuss the hunks:
* Using AC_PATH_PROG results in not considering $ac_tool_prefix. This
generally breaks cross compilation. AC_PATH_TOOL is an improvement,
but PKG_PROG_PKG_CONFIG is the correct upstream macro to use.
* Using PKG_CHECK_MODULES inside an if can break later PKG_CHECK_MODULES
relying on the AC_REQUIRE part being run. AS_IF ensures that
requirements are run before the condition.
* Running a bare pkg-config again misses $ac_tool_prefix.
Helmut
Index: mate-user-share-1.18.0/configure.ac
===================================================================
--- mate-user-share-1.18.0.orig/configure.ac
+++ mate-user-share-1.18.0/configure.ac
@@ -24,7 +24,7 @@
AM_DISABLE_STATIC
AM_PROG_LIBTOOL
AC_PATH_XTRA
-AC_PATH_PROG(PKG_CONFIG, pkg-config, no)
+PKG_PROG_PKG_CONFIG
AC_TYPE_PID_T
AC_TYPE_SIGNAL
@@ -53,13 +53,13 @@
BLUETOOTH_PKG="mate-bluetooth-1.0 >= 1.2.0"
AC_ARG_ENABLE(bluetooth, AS_HELP_STRING([--disable-bluetooth],[compile without bluetooth support]),,enable_bluetooth=no)
-if test "x$enable_bluetooth" = "xyes"; then
+AS_IF([test "x$enable_bluetooth" = "xyes"],[
PKG_CHECK_MODULES(BLUETOOTH, $BLUETOOTH_PKG)
AC_DEFINE(HAVE_BLUETOOTH, 1, [Set to true if mate-bluetooth support is available])
-else
+],[
BLUETOOTH_PKG=""
AC_MSG_WARN([Bluetooth support is disabled.])
-fi
+])
AM_CONDITIONAL(USE_BLUETOOTH, [test "$enable_bluetooth" = "yes"])
GLIB_REQUIRED_VERSION=2.36.0
@@ -144,7 +144,7 @@
PKG_CHECK_MODULES(EXTENSION,
libcaja-extension >= 1.17.1 $BLUETOOTH_PKG)
if test "${ac_with_cajadir}" = ""; then
- ac_with_cajadir=`pkg-config --variable=extensiondir libcaja-extension`
+ ac_with_cajadir=`$PKG_CONFIG --variable=extensiondir libcaja-extension`
fi
AC_SUBST(CAJADIR)
AC_MSG_NOTICE([installing caja plugin in ${ac_with_cajadir}])
--- End Message ---
--- Begin Message ---
Source: mate-user-share
Source-Version: 1.18.0-2
We believe that the bug you reported is fixed in the latest version of
mate-user-share, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Mike Gabriel <[email protected]> (supplier of updated mate-user-share
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Mon, 15 Jan 2018 11:13:30 +0100
Source: mate-user-share
Binary: mate-user-share mate-user-share-common
Architecture: source
Version: 1.18.0-2
Distribution: unstable
Urgency: medium
Maintainer: Debian+Ubuntu MATE Packaging Team <[email protected]>
Changed-By: Mike Gabriel <[email protected]>
Description:
mate-user-share - User level public file sharing via WebDAV or ObexFTP
mate-user-share-common - User level public file sharing via WebDAV or ObexFTP
(common file
Closes: 886578
Changes:
mate-user-share (1.18.0-2) unstable; urgency=medium
.
[ Vangelis Mouhtsis ]
* debian/control:
+ Bump Standards-Version: to 4.1.3. No changes needed.
+ Rename pretty name of our team -> Debian+Ubuntu MATE Packaging Team.
+ Update Maintainer: field to debian-mate ML on lists.debian.org.
+ Temporarily have pkg-mate-team ML under Uploaders:.
.
[ Mike Gabriel ]
* debian/patches:
+ Add 0001_build-use-correct-macros-to-fix-cross-build.patch. Fix
pkg-config
originated FTCBFS. (Closes: #886578).
* debian/watch:
+ Use secure URL for obtaining upstream sources.
Checksums-Sha1:
a016f8a86a915138243c8ba0cff5d2931472b05c 2582 mate-user-share_1.18.0-2.dsc
fb95eb5fe4e1ccf31732738b8d7ffb5208f5770c 7956
mate-user-share_1.18.0-2.debian.tar.xz
a110ee4111e87407fee1edd86b743c31b7276650 15179
mate-user-share_1.18.0-2_source.buildinfo
Checksums-Sha256:
21a006dfba28361f0bc8c78ccf3c0aef59a5291cab86a3b4daa2c2188f310af0 2582
mate-user-share_1.18.0-2.dsc
adeaeb537a71b673e7e690766ace41eef4be71714f90ff7bb9899186a078818d 7956
mate-user-share_1.18.0-2.debian.tar.xz
8597e49bf7526799a31e7694e6565d9981d2a61a80375ed7a699a8853a24b0b6 15179
mate-user-share_1.18.0-2_source.buildinfo
Files:
c87a6f5e61c1078ef9a29f586becc378 2582 x11 optional mate-user-share_1.18.0-2.dsc
e19c28fae7c46e6d7cf4f421ce26400d 7956 x11 optional
mate-user-share_1.18.0-2.debian.tar.xz
60e8de798579b3dfadfdcd2419e6b303 15179 x11 optional
mate-user-share_1.18.0-2_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJJBAEBCAAzFiEEm/uu6GwKpf+/IgeCmvRrMCV3GzEFAlpcgMIVHHN1bndlYXZl
ckBkZWJpYW4ub3JnAAoJEJr0azAldxsxmhIP/2G6V6191RW44v/IAngBo0GZn/H6
/R5LEXGEAm9yRBsOas+EQX512AB8J1sZ184lJM7J+jsJ5qMkI8gX+JFCtfRMqYvx
H1MRpkEjLHiL47bFF/GuAeMO33vr2ZTbfa/9sPeuNvXIdoYwgS4kx+X58lHrh+ik
GUgMnM6Y1j2pixS/2l2AOSLPFc6DxDHZTILOh01jOrukztRoEb7aLe2JO/DPHI+N
69TgDxVQdTk2xiIxjRBflT9LRV3ChTza51+xX2XhHmYXCPcsBhfmVwUxyW5WZxRr
W8reUYY1zvVirRj+fLJ/hzGuNB1hrvSsT4mNBUgb6Tpfv//Kg/EIYwbnaNrsUSfp
RXoeiFFdD7KYZDk5sX3zxUADciE4WNtE8AA9olV4214YYnq/qMcdoipatNC+cpje
YTrxm25cgohRynvVVaApcgHbF6iH61CTT3LN5/63zhKo+EyN48T/IrI+aByg2GC0
hIXSaTn/TaKbLjADyEnHQ5bPFZC25BEqwHcKV9rDyyor5XA0s/KKLUw8paIGB8ih
5hXWJZzHuP+zuf1ssuKUO82OzooufVdNudVwcwQ6dTcpo0eHZ04Mo6SwdY33T3Uw
jR0juD2D2OQMX/FUoR9otxcBCDw4nD/rTr102ZPndY8/S32Inw7DTvFaGka0yodT
tbObHRcV1ZvMAF+6
=/Unn
-----END PGP SIGNATURE-----
--- End Message ---
