Your message dated Mon, 15 Jan 2018 16:22:14 +0000
with message-id <[email protected]>
and subject line Bug#883489: fixed in fwupdate 10-2
has caused the Debian Bug report #883489,
regarding fwupdate FTCBFS: multiple reasons
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
883489: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=883489
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: fwupdate
Version: 9-3
Tags: patch
User: [email protected]
Usertags: rebootstrap
fwupdate fails to cross build from source for a number of reasons:
1. It uses the build architecture objcopy, because dh_auto_build passes
neither OBJCOPY nor CROSS_COMPILE. While the CROSS_COMPILE variable
is somewhat general, it's not as widely adopted. dh_auto_build
explicitly sets tools such as CC or PKG_CONFIG. Explicitly passing
CROSS_COMPILE makes this part work.
2. The upstream build system hard codes the use of the build
architecture pkg-config. While it considers CROSS_COMPILE for other
tools (including CC, LD and OBJCOPY) it fails to do so for
pkg-config. I think this is an upstream bug and it should allow
substituting pkg-config just like the other tools.
3. It derives FWUP in efi/Makefile from ARCH and ARCH from CC.
Unfortunately, dh_auto_install doesn't pass CC (only dh_auto_build
does). Thus FWUP differs between build and install and thus tries to
build more stuff. An easy way to solve this is to simply pass
CROSS_COMPILE to make install as well.
After fixing all of the above, fwupdate cross builds successfully.
Please consider applying the attached patch.
Helmut
diff --minimal -Nru fwupdate-9/debian/changelog fwupdate-9/debian/changelog
--- fwupdate-9/debian/changelog 2017-11-06 16:17:16.000000000 +0100
+++ fwupdate-9/debian/changelog 2017-12-04 17:10:48.000000000 +0100
@@ -1,3 +1,12 @@
+fwupdate (9-3.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix FTCBFS: (Closes: #-1)
+ + Pass CROSS_COMPILE to make.
+ + Make pkg-config substitutable.
+
+ -- Helmut Grohne <[email protected]> Mon, 04 Dec 2017 17:10:48 +0100
+
fwupdate (9-3) unstable; urgency=medium
* Disable "Linux Firmware Updater" boot entry after installation
diff --minimal -Nru fwupdate-9/debian/patches/0003-cross.patch
fwupdate-9/debian/patches/0003-cross.patch
--- fwupdate-9/debian/patches/0003-cross.patch 1970-01-01 01:00:00.000000000
+0100
+++ fwupdate-9/debian/patches/0003-cross.patch 2017-12-04 17:10:48.000000000
+0100
@@ -0,0 +1,39 @@
+Index: fwupdate-9/Make.defaults
+===================================================================
+--- fwupdate-9.orig/Make.defaults
++++ fwupdate-9/Make.defaults
+@@ -3,6 +3,7 @@
+ CC = $(CROSS_COMPILE)gcc
+ LD = $(CROSS_COMPILE)ld
+ OBJCOPY = $(CROSS_COMPILE)objcopy
++PKG_CONFIG = $(CROSS_COMPILE)pkg-config
+ READELF = eu-readelf
+ XGETTEXT = xgettext
+ prefix ?= /usr/
+Index: fwupdate-9/linux/Makefile
+===================================================================
+--- fwupdate-9.orig/linux/Makefile
++++ fwupdate-9/linux/Makefile
+@@ -18,11 +18,11 @@
+ PJONES =
+ BIN_CCLDFLAGS = $(foreach lib,$(BIN_LIBS),-l$(lib)) \
+ $(foreach pklib,$(PKLIBS), \
+- $(shell pkg-config --libs-only-l --libs-only-other $(pklib))) \
++ $(shell $(PKG_CONFIG) --libs-only-l --libs-only-other
$(pklib))) \
+ $(LDFLAGS) -pie -fPIE -Wl,-z,relro,-z,now -L.
+ LIB_CCLDFLAGS = $(foreach lib,$(LIB_LIBS),-l$(lib)) \
+ $(foreach pklib,$(PKLIBS), \
+- $(shell pkg-config --libs-only-l --libs-only-other $(pklib))) \
++ $(shell $(PKG_CONFIG) --libs-only-l --libs-only-other
$(pklib))) \
+ $(LDFLAGS) -shared -fPIC -Wl,-z,relro,-z,now
+
+ ifeq ($(HAVE_LIBSMBIOS),yes)
+@@ -36,7 +36,7 @@
+ -DLOCALEDIR=\"$(localedir)\" -D_GNU_SOURCE \
+ -DFWUP_EFI_DIR_NAME=\"$(EFIDIR)\" \
+ -I$(TOPDIR)/linux/include -iquote$(TOPDIR)/include/ \
+- $(foreach pklib,$(PKLIBS), $(shell pkg-config --cflags $(pklib))) \
++ $(foreach pklib,$(PKLIBS), $(shell $(PKG_CONFIG) --cflags $(pklib))) \
+ $(PJONES)
+
+ BINTARGETS=fwupdate
diff --minimal -Nru fwupdate-9/debian/patches/series
fwupdate-9/debian/patches/series
--- fwupdate-9/debian/patches/series 2017-11-06 16:09:37.000000000 +0100
+++ fwupdate-9/debian/patches/series 2017-12-04 17:10:48.000000000 +0100
@@ -2,3 +2,4 @@
0001-Fix-sprintf-formatting-for-Boot.patch
0001-efi-delete-boot-entry-before-apply-capsule.patch
0002-efi-delete-the-boot-path-from-the-BootOrder-list.patch
+0003-cross.patch
diff --minimal -Nru fwupdate-9/debian/rules fwupdate-9/debian/rules
--- fwupdate-9/debian/rules 2017-11-06 16:13:23.000000000 +0100
+++ fwupdate-9/debian/rules 2017-12-04 17:10:48.000000000 +0100
@@ -1,7 +1,7 @@
#!/usr/bin/make -f
# -*- makefile -*-
export DEB_BUILD_MAINT_OPTIONS = hardening=+all
-DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)
+include /usr/share/dpkg/architecture.mk
EFIDIR ?= $(shell dpkg-vendor --query vendor | awk '{ print tolower($$0) }')
PODATE := $(shell dpkg-parsechangelog --show-field Date | xargs -0 date --utc
"+%Y-%m-%d %H:%M%z" --date)
@@ -24,7 +24,8 @@
datadir=/var/cache/ \
localedir=/usr/share/locale/ \
GNUEFIDIR=\$${prefix}/lib \
- EFIDIR=$(EFIDIR)
+ EFIDIR=$(EFIDIR) \
+ CROSS_COMPILE=$(DEB_HOST_GNU_TYPE)-
sed 's,#EFIDIR#,$(EFIDIR),' \
debian/fwupdate.postrm.in > debian/fwupdate.postrm
sed 's,#EFIDIR#,$(EFIDIR),' \
@@ -42,7 +43,8 @@
datadir=/var/cache/ \
localedir=/usr/share/locale/ \
GNUEFIDIR=\$${prefix}/lib \
- EFIDIR=$(EFIDIR)
+ EFIDIR=$(EFIDIR) \
+ CROSS_COMPILE=$(DEB_HOST_GNU_TYPE)-
chmod -x ${buildroot}/boot/efi/EFI/$(EFIDIR)/*.efi
cp debian/scripts/install.in ${buildroot}/usr/lib/fwupdate/install
sed -i 's,#EFIDIR#,$(EFIDIR),' ${buildroot}/usr/lib/fwupdate/install
--- End Message ---
--- Begin Message ---
Source: fwupdate
Source-Version: 10-2
We believe that the bug you reported is fixed in the latest version of
fwupdate, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Mario Limonciello <[email protected]> (supplier of updated fwupdate
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Mon, 15 Jan 2018 09:59:03 -0600
Source: fwupdate
Binary: libfwup-dev fwupdate libfwup1
Architecture: source amd64
Version: 10-2
Distribution: unstable
Urgency: medium
Maintainer: Debian EFI <[email protected]>
Changed-By: Mario Limonciello <[email protected]>
Description:
fwupdate - Tools to manage UEFI firmware updates
libfwup-dev - Development headers for libfwup
libfwup1 - Library to manage UEFI firmware updates
Closes: 883489 887290
Changes:
fwupdate (10-2) unstable; urgency=medium
.
* debian/control: Depends on e2fsprogs (Closes: #887290)
* debian/rules: fix FTCBFS (Closes: #883489)
Checksums-Sha1:
6b2b22e41f75e058da7630a62b196f1fc52e0f8a 2262 fwupdate_10-2.dsc
ae67c130a45469745c8610a9445d0da5a368f169 8652 fwupdate_10-2.debian.tar.xz
08f76bc66bddd7305518b1e2a6ad3f91ba132131 10076 fwupdate-dbgsym_10-2_amd64.deb
c82500dbb5bdbe95c7687c5c192e00fe79151544 6670 fwupdate_10-2_amd64.buildinfo
f9bb8f180649018ea1dc2ef4800e2ee22ae16a91 42880 fwupdate_10-2_amd64.deb
a3e1f8002eeaf0d05b14ff571418d6fbbeb43d67 6688 libfwup-dev_10-2_amd64.deb
5e782484019367df80b39efdb8e4ea36c3486e86 41260 libfwup1-dbgsym_10-2_amd64.deb
b0008c3afb63848d6c9fc88f89977ae1952cc398 20072 libfwup1_10-2_amd64.deb
Checksums-Sha256:
89160615978cb4e74474bea28bfdb7b153bc18eca938d0fa4b612d592ba0cff2 2262
fwupdate_10-2.dsc
4ec7200d24daab28f303681539df2a08c1e79c16e67fbf438a0456f6bc19c42b 8652
fwupdate_10-2.debian.tar.xz
32a49e7be9f705c38f7e514535618c6a71c62633435144703d592e30f17e101a 10076
fwupdate-dbgsym_10-2_amd64.deb
5cda1e684525ccc96f5d2b08a4781f03c782afbfbba57ac0565a13ba657e97f2 6670
fwupdate_10-2_amd64.buildinfo
2ba40d409feafce044f8ab95993d4650cbda2069ff16bec2521f31c1d699a753 42880
fwupdate_10-2_amd64.deb
b3eac265af3e51ae34dfb5748852dde323a8527510aefe647078a0350cedb8a7 6688
libfwup-dev_10-2_amd64.deb
ec3f2817f0ad511d9154144ecc741c2fdeb268107fb638484776eb9ae8c59d12 41260
libfwup1-dbgsym_10-2_amd64.deb
e9794319d6e205afd9c9e2c5967c8b44cc4960710fadf745ad9eb28540365f01 20072
libfwup1_10-2_amd64.deb
Files:
700149cecb143e8a050a650d671f5cdb 2262 libs optional fwupdate_10-2.dsc
fcd77524db1e1486e8a70af99dc1f954 8652 libs optional fwupdate_10-2.debian.tar.xz
3882d7f18d4c666d920ff4c989fb80bb 10076 debug optional
fwupdate-dbgsym_10-2_amd64.deb
36057cd823b74289f67f2cfc5e9171de 6670 libs optional
fwupdate_10-2_amd64.buildinfo
372a129d10d3a93bb3fdee7f5f04bba6 42880 admin optional fwupdate_10-2_amd64.deb
daeea0496607b8f16c90fd3e75bbe464 6688 libdevel optional
libfwup-dev_10-2_amd64.deb
cfcd681d99d7cb0896c4b312b7e37ed3 41260 debug optional
libfwup1-dbgsym_10-2_amd64.deb
17b0048b8bc4f4816bf3fab9c250254d 20072 libs optional libfwup1_10-2_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBCgAGBQJaXNHuAAoJEC0ZLKYkdwJ2ODsP/iRFSC1Cq4BcaUDR2q05J67W
cXqIEojncHFUtoh4W38Ld14zbsZ+58k+yiWN57YF+7CXzzTuohuj9FLw2SxllJDU
XhqySxJBfMoGBt+k/ccdBaFliQfdtVYlNtF5L4V7mw4V93M4zt/jJoBLBnSqPhCI
9uCxMSrW8ld69HWQnDPOjU3NW5nkUGDmugmF1bXy9+8e4lr0Grdohh84frrkZK+n
6CeqVBRYuTxuq+sdqvzWq5stz/Q8U3aY+z1ZpwMOhGaC9qusJftHZqIN5DDovOSg
8MSQ3NMczHyNTFP3AxmgSRXGuZLlNh7m1zGqcE5hCxt1OWUXyhlsM28AEhbHZb6j
tOUh5F2mSbpqkrcN7uULWPJrXTRzDDg5VZauYvHFLiYQj3nIVTljlxkzpIy36pA4
TpPV/ujzITsPxQ8UJwKUFsW7VIy3FI8N88gr7Y9AohZO+MkfHPiHZF4XIfnuj7UW
8jTSFYFeD1tdVQVoS8FJdElJCc8SGFWnuxCE2h8I1p0crGCfhPMeg7hnVb3I/7R+
mqcL85UzPMxrtBSDul5OO4UE6Lxwilh1PIDkfw1p3JMEFzrKb2eZyqMCP7doHhoR
IytwBU0TtJxUHPmigy1d8fe8up8k2BqLIEhmXpxb1tFRmS8VcrVnHNtLLXT94BWw
9aYD2/GW2BvHCyfqjjLy
=brhR
-----END PGP SIGNATURE-----
--- End Message ---
