Your message dated Thu, 01 Mar 2018 11:50:21 +0000
with message-id <[email protected]>
and subject line Bug#888601: fixed in iaxmodem 1.2.0~dfsg-3
has caused the Debian Bug report #888601,
regarding iaxmodem: FTBFS with debhelper/11.1 due to empty build target
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
888601: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=888601
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: iaxmodem
Version: 1.2.0~dfsg-2
Severity: serious
Tags: patch

Hi,

The iaxmodem package FTBFS with debhelper/11.1 as it has an empty
build target.  This is caused by debhelper had a bug in its handling
of "explicitly defined rules targets" that has now been fixed.

Previously, this happened to work because dpkg-buildpackage would
invoke "debian/rules build" (which would be a no-op) followed by
"fakeroot debian/rules binary".  During the binary target, dh's
suboptimal handling would run the build commands.


The solution is trivial but less pretty; explicitly define "build"
with the same content as the "%:" target (or rename the "build" folder
and drop the ".PHONY" target).  I have attached a patch for this.

There is also an optional patch (0002) that removes the now deprecated
"autotools-dev" sequence.  The default dh sequence replaces it without
any (additional) changes required in Debian stable and
oldstable-backports.


More details can be found in:
 * #886901 comment #35
 * #887688 comment #37
 * #880840

Apologies for the inconvenience.

Thanks,
~Niels
>From 564d7a1e68b082e63e0e1dc9c0009e9498428e79 Mon Sep 17 00:00:00 2001
From: Niels Thykier <[email protected]>
Date: Sat, 27 Jan 2018 15:40:03 +0000
Subject: [PATCH 1/2] Avoid empty build target

The dh sequencer as of debhelper/11.1 is stricter with this in order
to solve #880840 (where debhelper would fail to handle such targets
correctly).

Signed-off-by: Niels Thykier <[email protected]>
---
 debian/rules | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/debian/rules b/debian/rules
index 3ed5dd9..f3d0450 100755
--- a/debian/rules
+++ b/debian/rules
@@ -40,6 +40,11 @@ URL := 
http://heanet.dl.sourceforge.net/iaxmodem/iaxmodem-$(UPVERSION).tar.gz
 %:
        dh $@ --with-autotools_dev
 
+# The build target must not be empty.  Sadly because of how make
+# works, we have do duplicate the target in this case.
+build:
+       dh $@ --with-autotools_dev
+
 override_dh_auto_configure:
        # Check that problematic files have been removed prior to packaging
        ( [ ! -e lib/spandsp/src/spandsp/mmx.h ] && \
-- 
2.15.1

>From 0ff7844ebf40bd23c51662cbd0c66e232d87be4b Mon Sep 17 00:00:00 2001
From: Niels Thykier <[email protected]>
Date: Sat, 27 Jan 2018 16:05:36 +0000
Subject: [PATCH 2/2] Drop deprecated autotools-dev sequence

Signed-off-by: Niels Thykier <[email protected]>
---
 debian/control | 2 +-
 debian/rules   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/debian/control b/debian/control
index 95dde20..a8df0cf 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,7 @@ Section: comm
 Priority: optional
 Maintainer: Debian VoIP Team <[email protected]>
 Uploaders: Tzafrir Cohen <[email protected]>
-Build-Depends: debhelper (>= 9), libtiff-dev | libtiff4-dev, autotools-dev
+Build-Depends: debhelper (>= 9), libtiff-dev | libtiff4-dev
 Build-Conflicts: libiax-dev, libspandsp-dev
 Standards-Version: 3.8.0
 Homepage: http://iaxmodem.sourceforge.net/
diff --git a/debian/rules b/debian/rules
index f3d0450..49df162 100755
--- a/debian/rules
+++ b/debian/rules
@@ -38,12 +38,12 @@ UPFILENAME := iaxmodem_$(UPVERSION).orig.tar.gz
 URL := http://heanet.dl.sourceforge.net/iaxmodem/iaxmodem-$(UPVERSION).tar.gz
 
 %:
-       dh $@ --with-autotools_dev
+       dh $@
 
 # The build target must not be empty.  Sadly because of how make
 # works, we have do duplicate the target in this case.
 build:
-       dh $@ --with-autotools_dev
+       dh $@
 
 override_dh_auto_configure:
        # Check that problematic files have been removed prior to packaging
-- 
2.15.1


--- End Message ---
--- Begin Message ---
Source: iaxmodem
Source-Version: 1.2.0~dfsg-3

We believe that the bug you reported is fixed in the latest version of
iaxmodem, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joerg Dorchain <[email protected]> (supplier of updated iaxmodem package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 1 Mar 2018 10:28:36 +0100
Source: iaxmodem
Binary: iaxmodem
Architecture: source
Version: 1.2.0~dfsg-3
Distribution: unstable
Urgency: low
Maintainer: Debian VoIP Team <[email protected]>
Changed-By: Joerg Dorchain <[email protected]>
Description:
 iaxmodem   - software modem with IAX2 connectivity
Closes: 857906 888601
Changes:
 iaxmodem (1.2.0~dfsg-3) unstable; urgency=low
 .
   * Fix build rules (Closes: #888601)
   * Added myself to uploaders
   * update vcs fields
   * Bumped standards: initscript, rules file
   * recompile fixes bug (Closes: #857906)
Checksums-Sha1:
 b1f080d33ebe83e4e8a6aa5bcfffba2e206831e2 2064 iaxmodem_1.2.0~dfsg-3.dsc
 7bf7f13c8a057e63a0d3e4ca0edbce7b25471a85 8156 
iaxmodem_1.2.0~dfsg-3.debian.tar.xz
 f47086bd635d3d1ab7c48e553ee70c0e34a6f0b5 6144 
iaxmodem_1.2.0~dfsg-3_amd64.buildinfo
Checksums-Sha256:
 ec9dfa79586fa6aadca6ed5970a1d162de1bb65ded71b267c8337f088dcfb5eb 2064 
iaxmodem_1.2.0~dfsg-3.dsc
 b35ecc1a5e436a0f60c938877f2c75ff9e22317feb97b2f8639b0b188a942a04 8156 
iaxmodem_1.2.0~dfsg-3.debian.tar.xz
 02a4c10a4ad9e0e59e1673e8c4a33c1f8bb9c9496ab2b05f056dc1e8f8cc86a2 6144 
iaxmodem_1.2.0~dfsg-3_amd64.buildinfo
Files:
 ea70b7e4a9de10ab01dc5edd37a1623b 2064 comm optional iaxmodem_1.2.0~dfsg-3.dsc
 ed8bee56638fd2f7809a08c63a3ec93f 8156 comm optional 
iaxmodem_1.2.0~dfsg-3.debian.tar.xz
 2448f6fe28970a3f8a78b3bee94c9b47 6144 comm optional 
iaxmodem_1.2.0~dfsg-3_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE1uAexRal3873GVbTd1B55bhQvJMFAlqX4swACgkQd1B55bhQ
vJMVfg//T2EzWsNwDZEvCZX82jAKaYdybafwbLMeKaohihhLNyRoPuw3+iDwqRTR
ry9nfR+cs1NIeP2ak/OGpFbLZ6zkGsJsqjyYzymelCcWeqsoU4CyQcLuGXTe3ZOK
0FXRoZjygWL26d1V3qq+K7MUhbjfurLXKRMY/OhcOUyXC1Lhsw392xRByRXP6lJV
HVC0u5LpjFCxckpIaDFK/LgbxDZqm4J8he9XMOLxdt4R+GwmRYTErgGj1LZRg2ZF
HP837Q1bhDVIWHbaPCNIUqqYedXt7Q6wTmtO9/EBkmXoAJtuUBTZi7QEs5ymsYuw
59g59GoRF/hNwusUV1jCCpqnMUZ06lU04CTNWs/Srvs56PTpzcyDJEiQUe15lU8V
CxC/qZekNSl/F/zhuufwTOYg9M0+AWDDZx6UihkDr1k7YlAnIw0h1Zh+eyQ8ENVF
RjxOoCui5uf/7twwQfvdzvjUlFKaWpQBFSF/3N1PCb7ssWp6AbbZxTS24QQDGrMR
RY1qUL2yUjx21n8kOwtohitZLYp/meKeh9TDA2fHoQExt5INFq5tfAhuuzD6GBt5
t+7UU50xmfr82LjpzifDNT10hOXS7sTqTxvGQ/hATQkC+p2zAjDGGJZotS+CHviF
YMX3BetAVRtvFdfCYapISz+KeIJKGVMVoXdyQGvpRfGlyG9cB7w=
=JpVt
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to