Your message dated Sun, 18 Mar 2018 21:19:35 +0000
with message-id <[email protected]>
and subject line Bug#893000: fixed in c-blosc 1.14.2+ds1-1
has caused the Debian Bug report #893000,
regarding c-blosc: Add upstream patch for unaligned access
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
893000: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=893000
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: c-blosc
Version: 1.14.0+ds1-1
Severity: important
Tags: patch
Hi Daniel,
After your update of the package to 1.14.0 (thanks for being so quick!),
it was synced to Ubuntu's bionic-proposed, where it failed building on
armhf due to an alignment bug.
The bug only manifested itself in the Ubuntu build, because of the way
they have their ARM building infrastructure set up (ARMv7 chroot on
ARMv8 hardware).
The bug was quickly fixed [1] upstream, and mwhudson @ #ubuntu-release
kindly verified [2] the fix on his Ubuntu porter box.
Attached is a debdiff that adds the upstream patch to the package.
Sorry for the trouble, but would be great if a new version could be
released.
Thanks in advance,
Elvis
[1]
https://github.com/Blosc/c-blosc/commit/8a84d51487eed81431b0fa488805a62c2d8f0163
[2] https://github.com/Blosc/c-blosc/issues/223#issuecomment-373320351
-- System Information:
Debian Release: buster/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 4.13.0-36-generic (SMP w/4 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968), LANGUAGE=C
(charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /usr/bin/dash
Init: unable to detect
diff -Nru c-blosc-1.14.0+ds1/debian/changelog
c-blosc-1.14.0+ds1/debian/changelog
--- c-blosc-1.14.0+ds1/debian/changelog 2018-03-12 17:01:18.000000000 +0000
+++ c-blosc-1.14.0+ds1/debian/changelog 2018-03-15 10:26:45.000000000 +0000
@@ -1,3 +1,9 @@
+c-blosc (1.14.0+ds1-1.1) UNRELEASED; urgency=medium
+
+ * Add fix-unaligned-access.patch.
+
+ -- Elvis Stansvik <[email protected]> Thu, 15 Mar 2018 10:26:45 +0000
+
c-blosc (1.14.0+ds1-1) unstable; urgency=medium
* New upstream release:
diff -Nru c-blosc-1.14.0+ds1/debian/patches/fix-unaligned-access.patch
c-blosc-1.14.0+ds1/debian/patches/fix-unaligned-access.patch
--- c-blosc-1.14.0+ds1/debian/patches/fix-unaligned-access.patch
1970-01-01 00:00:00.000000000 +0000
+++ c-blosc-1.14.0+ds1/debian/patches/fix-unaligned-access.patch
2018-03-15 10:26:45.000000000 +0000
@@ -0,0 +1,38 @@
+From 8a84d51487eed81431b0fa488805a62c2d8f0163 Mon Sep 17 00:00:00 2001
+From: Francesc Alted <[email protected]>
+Date: Thu, 15 Mar 2018 09:32:34 +0000
+Subject: [PATCH] [FIX] Do not use unaligned access when copying. Fixes #223.
+
+---
+ blosc/fastcopy.c | 8 +++++---
+ 1 file changed, 5 insertions(+), 3 deletions(-)
+
+diff --git a/blosc/fastcopy.c b/blosc/fastcopy.c
+index 3c933b2..8e1b0d8 100644
+--- a/blosc/fastcopy.c
++++ b/blosc/fastcopy.c
+@@ -64,9 +64,13 @@ static inline unsigned char *copy_7_bytes(unsigned char
*out, const unsigned cha
+ }
+
+ static inline unsigned char *copy_8_bytes(unsigned char *out, const unsigned
char *from) {
++#if defined(BLOSC_STRICT_ALIGN)
+ uint64_t chunk;
+ memcpy(&chunk, from, 8);
+ memcpy(out, &chunk, 8);
++#else
++ *(uint64_t *) out = *(uint64_t *) from;
++#endif
+ return out + 8;
+ }
+
+@@ -449,9 +453,7 @@ unsigned char *fastcopy(unsigned char *out, const unsigned
char *from, unsigned
+ case 16:
+ return copy_16_bytes(out, from);
+ case 8:
+- *(uint64_t *) out = *(uint64_t *) from;
+- out += 8;
+- return out;
++ return copy_8_bytes(out, from);
+ default: {
+ }
+ }
diff -Nru c-blosc-1.14.0+ds1/debian/patches/series
c-blosc-1.14.0+ds1/debian/patches/series
--- c-blosc-1.14.0+ds1/debian/patches/series 2018-03-12 16:14:26.000000000
+0000
+++ c-blosc-1.14.0+ds1/debian/patches/series 2018-03-15 10:26:45.000000000
+0000
@@ -0,0 +1 @@
+fix-unaligned-access.patch
--- End Message ---
--- Begin Message ---
Source: c-blosc
Source-Version: 1.14.2+ds1-1
We believe that the bug you reported is fixed in the latest version of
c-blosc, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Daniel Stender <[email protected]> (supplier of updated c-blosc package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 18 Mar 2018 21:40:02 +0100
Source: c-blosc
Binary: libblosc-dev libblosc1
Architecture: source
Version: 1.14.2+ds1-1
Distribution: unstable
Urgency: medium
Maintainer: Daniel Stender <[email protected]>
Changed-By: Daniel Stender <[email protected]>
Closes: 893000
Description:
libblosc1 - high performance meta-compressor optimized for binary data
libblosc-dev - high performance meta-compressor optimized for binary data
(devel
Changes:
c-blosc (1.14.2+ds1-1) unstable; urgency=medium
.
* New upstream release (Closes: #893000).
Checksums-Sha1:
f59545265088b2e55705e72cddb3826298738e20 1989 c-blosc_1.14.2+ds1-1.dsc
a00c7206de404fcd3c4e252cf0285e281a2b8e57 91132 c-blosc_1.14.2+ds1.orig.tar.xz
0e56fe953eea996970afc25452b1a6ee5b01832f 4852
c-blosc_1.14.2+ds1-1.debian.tar.xz
Checksums-Sha256:
d9c1d55bbf1a86c7d04ee8a462fc93c35017158a5a38e90f0235123cc2be56cd 1989
c-blosc_1.14.2+ds1-1.dsc
82a563a2514ea87825320db1cb6abd061cfcf4420d32a583262887b3ae7f15e6 91132
c-blosc_1.14.2+ds1.orig.tar.xz
c30e28893adf1a74a17a0a19731a44080cf71b035a5d250195ba84f5e65279c4 4852
c-blosc_1.14.2+ds1-1.debian.tar.xz
Files:
9ba2e534d61daf4b8a2ecb6d5454f58f 1989 libs optional c-blosc_1.14.2+ds1-1.dsc
8b015aaf60d55e65021b8404db3ab468 91132 libs optional
c-blosc_1.14.2+ds1.orig.tar.xz
da167a208fb53a278b5f32feb4c95d27 4852 libs optional
c-blosc_1.14.2+ds1-1.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEERsscqJ6jt0N2dh25FeCa9N9RgsgFAlquz8UACgkQFeCa9N9R
gsgUqhAAi/YgQB0LO9ufR9M1g9UhpU698U2xkT1GNsGFi8lUYGECei7p/PR6NenS
afG2egcqnkjhKevhB7gmG2D4b3t7/7hy3U/IgCp5bAPYiJhA168/dt00u8nKafX0
zTRpkCNE2rIjH1u0ey0tLMlcHYVg1fdpJDjZsbCA480yVVXYn01WUf7FzW2NJTZL
GMIZv18Apr2SOObfJPw445+8b1+VtplleoZoErCTtDbYA61Ituh2gFq9UnZcNUsI
Ul2CMdxMaxiFnig6HlozrVrXZSnTorCKyK8NaHC8g/46GKSA7/+4S9joh6fxDDTw
X2hARUV2gbJMLVDWa5QBLixLvwzOpZtL4RCAiofZPedLgaiScr1AhZo0tiWVYyF+
HcMlmuOhe+cajSe52Q6OmZRBN4xHCH76YDYyR9BG4CMzKbTlaRylI1lI/67QKVof
B6wsOvsSHCCysPfbVkHDRy9+WCsY4nkcq/CSJ0AEBwg0XuAYr/VOpZEVvM1QcDml
axCCbfHUxla6bAV/5ydjWDQwtpI5ArLTa94SIRZ18O4370MBrMCEjrFL3yXj/711
bUyvjYhh+gF5xKagXEulLsfWDRGNSC8JG4L0va2Mobc+mqC1z0GrdqYNkTjDh/ax
uCsjJ+QTXYQCF/9sd/5YeYbiB32ughv8tWdCHK6VdMFjlmR4oB8=
=AkpF
-----END PGP SIGNATURE-----
--- End Message ---
