Your message dated Fri, 30 Mar 2018 09:05:48 +0000
with message-id <[email protected]>
and subject line Bug#893407: fixed in ftools-fv 5.4+dfsg-4
has caused the Debian Bug report #893407,
regarding ftools-fv: Consider migration to Itcl 4
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
893407: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=893407
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: ftools-fv
Version: 5.4+dfsg-2
Severity: wishlist
Tags: patch

Dear Maintainer,

I would like to switch the iwidgets4 package to Itcl/Itk 4 (currently they are
using version 3). I've already uploaded iwidgets4 4.1.0-2 which depend on
tcl-itcl4 and tk-itk4 into experimental for testing. And I'd like you to test
fvtools-fv with it.

Attached is a minimal patch which makes ftools-fv building and runnig. Can you
upload fvtools-fv to experimental as well, test it and report any bugs in 
Itcl/Ik 4
you'd found in this setup? (One bug is already found and reported upstream,
its workaround is include into the patch).

The patch looks like NMU, but I don't plan to do the upload. Though I'd like
to switch Iwidgets to Itcl/Itk 4 before the buster's release. Can you help me
with it?

-- System Information:
Debian Release: 9.4
  APT prefers stable-debug
  APT policy: (500, 'stable-debug'), (500, 'proposed-updates'), (500, 
'stable'), (500, 'oldstable'), (1, 'experimental'), (1, 'unstable'), (1, 
'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.14.0-0.bpo.3-amd64 (SMP w/12 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- no debconf information
diff -Nru ftools-fv-5.4+dfsg/debian/changelog 
ftools-fv-5.4+dfsg/debian/changelog
--- ftools-fv-5.4+dfsg/debian/changelog 2016-09-13 14:25:06.000000000 +0300
+++ ftools-fv-5.4+dfsg/debian/changelog 2018-03-18 17:26:22.000000000 +0300
@@ -1,3 +1,13 @@
+ftools-fv (5.4+dfsg-2.1) experimental; urgency=low
+
+  * Non-maintainer upload.
+  * Relax the Itcl version requirement to allow version 4 to be loaded.
+  * Depend on Itcl and Itk indirectly through Iwidgets.
+  * Remove a call to [fvPref save] during initial objects creation because
+    it causes crash with Itcl 4.
+
+ -- Sergei Golovan <[email protected]>  Sun, 18 Mar 2018 17:26:22 +0300
+
 ftools-fv (5.4+dfsg-2) unstable; urgency=low
 
   * Update standards-version to 3.9.8 (no changes)
diff -Nru ftools-fv-5.4+dfsg/debian/control ftools-fv-5.4+dfsg/debian/control
--- ftools-fv-5.4+dfsg/debian/control   2016-09-13 14:24:45.000000000 +0300
+++ ftools-fv-5.4+dfsg/debian/control   2018-03-18 17:26:22.000000000 +0300
@@ -16,7 +16,7 @@
 
 Package: ftools-fv
 Architecture: all
-Depends: ftools-pow, itcl3, itk3, iwidgets4, ${misc:Depends}, ${shlibs:Depends}
+Depends: ftools-pow, iwidgets4, ${misc:Depends}, ${shlibs:Depends}
 Conflicts: fv
 Replaces: fv
 Suggests: saods9, xpa-tools
@@ -33,9 +33,7 @@
 Package: ftools-pow
 Architecture: any
 Multi-Arch: same
-Depends: itcl3,
-         itk3,
-         iwidgets4,
+Depends: iwidgets4 (>= 4.1.0-2),
          tcl-fitstcl,
          tix,
          ${misc:Depends},
diff -Nru ftools-fv-5.4+dfsg/debian/patches/itcl4.patch 
ftools-fv-5.4+dfsg/debian/patches/itcl4.patch
--- ftools-fv-5.4+dfsg/debian/patches/itcl4.patch       1970-01-01 
03:00:00.000000000 +0300
+++ ftools-fv-5.4+dfsg/debian/patches/itcl4.patch       2018-03-18 
17:26:22.000000000 +0300
@@ -0,0 +1,28 @@
+Author: Sergei Golovan
+Description: Patch relaxes the loaded Itcl version. This means
+ that Itcl 4 can be used. Also, it removes a call to [fvPref save]
+ which causes a crach with Itcl 4.
+Bug: https://core.tcl.tk/itcl/tktview?name=15f7db53b9
+
+--- a/ftools/guis/fv/class/fvWinKeeper.tcl
++++ b/ftools/guis/fv/class/fvWinKeeper.tcl
+@@ -148,7 +148,7 @@
+          if { $xpaFlag == "NOT_AVAILABLE" } {
+             # $itk_component(displayFrame) entryconfigure 0 -state disabled
+             set ::fvPref::imgDisplayer "POW"
+-            fvPref save
++            #fvPref save
+          }
+       } else {
+          $itk_component(displayFrame) entryconfigure 0 -state normal 
+--- a/tcltk/pow/PowInit.c
++++ b/tcltk/pow/PowInit.c
+@@ -108,7 +108,7 @@
+     return TCL_ERROR;
+   }
+ 
+-  Tcl_PkgRequire(interp, "Itcl", "3.0", 0);
++  Tcl_PkgRequire(interp, "Itcl", NULL, 0);
+ 
+ #if defined(MAC_TCL) && defined(PLUGIN)
+ 
diff -Nru ftools-fv-5.4+dfsg/debian/patches/series 
ftools-fv-5.4+dfsg/debian/patches/series
--- ftools-fv-5.4+dfsg/debian/patches/series    2015-09-02 11:22:56.000000000 
+0300
+++ ftools-fv-5.4+dfsg/debian/patches/series    2018-03-18 17:26:22.000000000 
+0300
@@ -7,3 +7,4 @@
 fv_fix_initial_menubar.patch
 fv_fix_startup.patch
 fvtmp.patch
+itcl4.patch

--- End Message ---
--- Begin Message ---
Source: ftools-fv
Source-Version: 5.4+dfsg-4

We believe that the bug you reported is fixed in the latest version of
ftools-fv, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ole Streicher <[email protected]> (supplier of updated ftools-fv package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 30 Mar 2018 10:40:56 +0200
Source: ftools-fv
Binary: ftools-fv ftools-pow
Architecture: source
Version: 5.4+dfsg-4
Distribution: unstable
Urgency: medium
Maintainer: Debian Astro Team <[email protected]>
Changed-By: Ole Streicher <[email protected]>
Description:
 ftools-fv  - Tool for viewing and editing FITS format files
 ftools-pow - Curve plotting and image display interface tool
Closes: 893407 894019
Changes:
 ftools-fv (5.4+dfsg-4) unstable; urgency=medium
 .
   * Switch back to unstable
   * Adjust patches for use with `gbp pq`
   * Don't remove pkgindex.tcl on `make clean` (Closes: #894019)
   * Remove version requirement for iwidgets4 (Closes: #893407)
Checksums-Sha1:
 ea8800f990e319845186b9351b326c632620576a 2091 ftools-fv_5.4+dfsg-4.dsc
 1e820af7ef8e7e70965725f31697061330e12121 13648 
ftools-fv_5.4+dfsg-4.debian.tar.xz
Checksums-Sha256:
 08966b4ad050e4cdca6dad251d8d094a83e553f19b37919e22193635141c0088 2091 
ftools-fv_5.4+dfsg-4.dsc
 a0bc641eae99bb07de989f95210019be651783be6d6520ea7b20ede1e9ddcb97 13648 
ftools-fv_5.4+dfsg-4.debian.tar.xz
Files:
 205a9e03d7a9ed38494c83e237a7d199 2091 science optional ftools-fv_5.4+dfsg-4.dsc
 2108780d0ba337f54d00151cb1601cbe 13648 science optional 
ftools-fv_5.4+dfsg-4.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE7/BpV0Ra2/h0L3qtmk9WvbkOGL0FAlq9+akACgkQmk9WvbkO
GL1R3w//ZF0fAnzJEeu6httmovg8CSUctMOs4DIurbnAVV4T2CoPSylHxQLkmJAw
7ielmhBJtnn0SA+FWSl5yC1KxfBWgsyxEs5LalVW6XtPjo5j3LoVZpc2BKsUamSb
LExFn2mrSr/bkj+gOA+2gqzITWpn/jnSNM5ug8p5BM5G/Oyi4myKEtt5RmMnXIsa
GEtfcxbmitdnDdC83oY6Zo0LRdPUkti452aNnOWo5/kKC8qAhsFPSamyB5Mq1QUz
HumhMmopxtp7ESpv1MFl4nEi7jWi1zXnKiyYQi1V9urjzYJU6vfFwjuwWnUzEbvP
GDihOEYTTLpZ9Xx3iNBiu0uqx81RjrDzxAxP6TwkGUnSLiPC+R/iWrtglfI03cPX
zBi8881LDjOK5BMirMwVl/LdZHJ8WIQpnRgbQDHE0orFnvMk2991wrjPTGg7nhmG
+yYztFzO0U41HmqjBuwWiLdk8AA7JJI4H5iCOF2ynyOdAMbiQv372Bbw7X3SoeoY
kW6iuumG3jx+f+tB5CszOSIYkMAxtxjbb5ozEqb/Zisz8ilI8+87oEbAoZYCkJAD
9zky3MFkrnQLnq14b5eq7EQH9Oxt9eDwGrX9o90SHF9pP33QGjQLUY9QMFirhG3e
/8A+H1zrQjZlqJKyJCAbFKEMv8HQmy78mDML6WFSAIRuYFtqu6A=
=ITpc
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to