Your message dated Sat, 07 Apr 2018 15:26:08 +0000
with message-id <e1f4pje-000awv...@fasolo.debian.org>
and subject line Bug#823133: fixed in subversion 1.10.0~rc2-1
has caused the Debian Bug report #823133,
regarding subversion FTBFS on Alpha: misaligned strings in the test suite
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
823133: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=823133
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: subversion
Version: 1.9.4-1
Severity: important
Justification: fails to build from source (but built in the past)
Tags: patch
User: debian-al...@lists.debian.org
Usertags: alpha

subversion FTBFS on Alpha due to a test suite failure [1]:

START: utf-test
PASS:  lt-utf-test 1: test is_valid/last_valid
PASS:  lt-utf-test 2: test last_valid/last_valid2
PASS:  lt-utf-test 3: test svn_utf_cstring_to_utf8_ex2
PASS:  lt-utf-test 4: test svn_utf_cstring_from_utf8_ex2
PASS:  lt-utf-test 5: test svn_utf__normcmp
PASS:  lt-utf-test 6: test svn_utf__glob
PASS:  lt-utf-test 7: test svn_utf__fuzzy_escape
PASS:  lt-utf-test 8: test svn_utf__is_normalized
svn_tests: E235000: In file 
'/«PKGBUILDDIR»/subversion/tests/libsvn_subr/utf-test.c' line 807: assertion 
failed (0 == strcmp(result->data, tc->result))
FAIL:  lt-utf-test 9: test svn_utf__utf{16,32}_to_utf8
END: utf-test
ELAPSED: utf-test 0:00:00.603655

This failure occurs because the test suite allocates char aligned
strings in function test_utf_conversions() of file
subversion/tests/libsvn_subr/utf-test.c and passes those strings
to functions svn_utf__utf16_to_utf8() and svn_utf__utf32_to_utf8()
which are defined (in file subversion/libsvn_subr/utf.c) to take
apr_uint32_t * and apr_uint16_t * args respectively.  On
architectures with strict alignment requirements this is undefined
behaviour.  On Alpha, gcc likes to add bugs..., I mean, _optimise_
code, when the args are declared to be aligned by using a particular
CPU load instruction that neither traps nor gives correct results
if the args are not actually aligned.

I attach a patch that aligns the test strings in utf-test.c to be
aligned to apr_uint32_t (i.e. 32-bit alignment).  With that patch
subversion builds successfully to completion on Alpha.

Cheers
Michael.

[1] 
https://buildd.debian.org/status/fetch.php?pkg=subversion&arch=alpha&ver=1.9.4-1&stamp=1461928473
Index: subversion-1.9.4/subversion/tests/libsvn_subr/utf-test.c
===================================================================
--- subversion-1.9.4.orig/subversion/tests/libsvn_subr/utf-test.c       
2016-05-01 21:05:58.763536825 +1200
+++ subversion-1.9.4/subversion/tests/libsvn_subr/utf-test.c    2016-05-01 
21:05:58.755722518 +1200
@@ -745,7 +745,7 @@
   {
     svn_boolean_t sixteenbit;
     svn_boolean_t bigendian;
-    const char *source;
+    const _Alignas(apr_int32_t) char *source;
     const char *result;
   } tests[] = {
 

--- End Message ---
--- Begin Message ---
Source: subversion
Source-Version: 1.10.0~rc2-1

We believe that the bug you reported is fixed in the latest version of
subversion, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 823...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
James McCoy <james...@debian.org> (supplier of updated subversion package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 07 Apr 2018 11:09:43 -0400
Source: subversion
Binary: subversion libsvn1 libsvn-dev libsvn-doc libapache2-mod-svn 
python-subversion subversion-tools libsvn-java libsvn-perl ruby-svn
Architecture: source
Version: 1.10.0~rc2-1
Distribution: experimental
Urgency: medium
Maintainer: James McCoy <james...@debian.org>
Changed-By: James McCoy <james...@debian.org>
Description:
 libapache2-mod-svn - Apache Subversion server modules for Apache httpd
 libsvn-dev - Development files for Apache Subversion libraries
 libsvn-doc - Developer documentation for libsvn
 libsvn-java - Java bindings for Apache Subversion
 libsvn-perl - Perl bindings for Apache Subversion
 libsvn1    - Shared libraries used by Apache Subversion
 python-subversion - Python bindings for Apache Subversion
 ruby-svn   - Ruby bindings for Apache Subversion
 subversion - Advanced version control system
 subversion-tools - Assorted tools related to Apache Subversion
Closes: 823133
Changes:
 subversion (1.10.0~rc2-1) experimental; urgency=medium
 .
   * New upstream pre-release
     + Fix test failure on alpha due to unaligned memory access. (Closes:
       #823133)
   * control: Set Rules-Requires-Root to no
   * dav_svn.conf: Clarify wording about SVNPath/SVNParentPath (LP: #917147)
   * Enable libsvn-java on ia64
   * Update upstream signing keys
   * rules:
     + Move install-javahl-java rule to install-arch
     + Ensure Perl binding shared libs are writable before deleting RPATH
   * subversion-tools: Change exim4 | m-t-a Recommends to default-mta | m-t-a
   * Declare compliance with Policy 4.1.4, no changes required
Checksums-Sha1:
 f80746070690a18e2d4d0007fffb8824bf99706c 3461 subversion_1.10.0~rc2-1.dsc
 44d224ad63f3bdef33bb1dbca67609b2d936cf58 11339099 
subversion_1.10.0~rc2.orig.tar.gz
 52597cfe84da009c010e66a6715ab7b925d748eb 4233 
subversion_1.10.0~rc2.orig.tar.gz.asc
 3a7e83e6928a35ed475737ef1f20d602d31a0d43 2399964 
subversion_1.10.0~rc2-1.debian.tar.xz
 2a7c9d7952fe321cb68b1c27a04918d69534dcfc 17855 
subversion_1.10.0~rc2-1_source.buildinfo
Checksums-Sha256:
 19917b2b3e63ed59560820b1092a8d946ce54573e1cf68d7461975849c34ef6c 3461 
subversion_1.10.0~rc2-1.dsc
 784bfc7401340333f6c96a60f1f483fb74f781fb9a6e82f285ac9a11fa850677 11339099 
subversion_1.10.0~rc2.orig.tar.gz
 bc7f2226e6f4e84c8bd1fbfbd8ac942b54012d826bba5a14660e5ac21ed3e607 4233 
subversion_1.10.0~rc2.orig.tar.gz.asc
 ae9d93ee0242f17958f013b3fa19c28c3b62fb818985c05be339f27af36807ac 2399964 
subversion_1.10.0~rc2-1.debian.tar.xz
 583f52d3ca55b967793f4c4e42902401f0559c241506289c9e94ffe065c98efa 17855 
subversion_1.10.0~rc2-1_source.buildinfo
Files:
 631418fa65615b78e921ecbdaaef4dbf 3461 vcs optional subversion_1.10.0~rc2-1.dsc
 32a23bcaa0bcacc4094db25338104e96 11339099 vcs optional 
subversion_1.10.0~rc2.orig.tar.gz
 6ea567667928c8414e3db3647e114b56 4233 vcs optional 
subversion_1.10.0~rc2.orig.tar.gz.asc
 beb2e9c45d3dc20eed8a52170fe298d9 2399964 vcs optional 
subversion_1.10.0~rc2-1.debian.tar.xz
 58cebceb5e77bef9d9869c5baa8a8178 17855 vcs optional 
subversion_1.10.0~rc2-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQKoBAEBCgCSFiEEkb+/TWlWvV33ty0j3+aRrjMbo9sFAlrI32lfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDkx
QkZCRjRENjk1NkJENURGN0I3MkQyM0RGRTY5MUFFMzMxQkEzREIUHGphbWVzc2Fu
QGRlYmlhbi5vcmcACgkQ3+aRrjMbo9v0Cw//d3DGgKO+gV6SG1jLQg7KUpfr7hsj
hxl8bfW7rwSbhBqtMEMwvAnOd6X4gpnBzb/oeVy1jxztWdz64RAPE2kMF80dP3NE
2TXh9/xjgwXt5jRclE0qEfKgYtiobKNKydU40McjJ7obTQSK/0rJ0x1OVv+cypoW
r92HYBNnFlvvMCGXrxXPwLjbCkItGTYw70L6f//zzD4ESwp606IK6TG99S+YWScX
uAC5HGrErsOgjEiGoozwGv+j7ly012aQlwFmX2JU3zAEPpASe3zRgAcWLcBfe4cR
ICTLaNp3wqOlQWwtk2L3/Zkk1h/v5td8P/cOq93NIBsdtJ8NlDvtQ7pqBL+xrBXP
icKNSaVWXiSANdcQtPJ0+2FrBWOejO+bQpXX+TXW2/a3lwZ6J3L3R8ySCQkVNquf
arY2fNPOuwVxEuUO3ZmV0i6Z4HZwDPG+qtNnt5juxarHDd8ouvZ5eos3lgsckUcC
Onc8z18T3VESk73DwzDfZU0BjlJLAXsjgzpt3CqJp0lnxA/dMS7cV+T5VTOfIIFI
ueo6tKwzIx1ngcr+cTeKX3fywwEpNlXcE4Dp7+NOAU7Qkj+wHBizV1DTZzFdGdv5
HRptgWFVSRiDN3CoITNs/WIFTOGnqqodaO09snKO01xbYWbzuNZU7z2kOXagVdLF
UcuBrm1IcSbSDVQ=
=UXdq
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to