Your message dated Mon, 09 Apr 2018 15:13:57 +0000
with message-id <e1f5yux-0002xq...@fasolo.debian.org>
and subject line Bug#893778: fixed in fio 3.5-1
has caused the Debian Bug report #893778,
regarding Github issue: Debian fio patch comments
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
893778: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=893778
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: fio
Version: 3.1-1
Severity: wishlist

sitsofe provided various suggestions and comments in an github issue¹. This
is a copy of it, in order to reference it in the changelog of the package.
I disabled issues on the github mirror of the packaging repo in order to
encourage people to use the Debian bugtracker. Putting all the comments in
one bug report to save the time.

[1] https://github.com/teamix/fio-debian/issues/1

Thank you sitsofe for those suggestions.

sitsofe commented on 2 Nov 2017:

- 
https://github.com/teamix/fio-debian/blob/master/debian/patches/fix-ftbfs-with-libmtd.h
  looks redundant now.

- 
https://github.com/teamix/fio-debian/blob/master/debian/patches/makefile-hardening
  is interesting. Red Hat took a different approach of disabling all 
optimisations
  and then using EXTFLAGS -
  
https://src.fedoraproject.org/rpms/fio/blob/b2a49f5d98c612228ba34fc9018a1ecd72472590/f/fio.spec#_35
  (I'm just noting the different approach - I'd say there's is slightly more 
risky but didn't require a patch...)

- 
https://github.com/teamix/fio-debian/blob/master/debian/patches/reproducible-build
  Making the build reproducible should already in there via axboe/fio@785e49c
  for 3.1 and later.

- One potential suggestion - did you want to ship the fio.service off to
  the "installable services" location so systemctl enable works?

sitsofe commented on 4 Nov 2017:

One more suggestion - if you have the flex and bison packages available
at build time fio will gain the ability to perform some arithmetic operations
(http://fio.readthedocs.io/en/latest/fio_doc.html#job-file-parameters ).
I would guess these could go in the Build-Depends line of
https://github.com/teamix/fio-debian/blob/master/debian/control .

sitsofe commented on 5 Nov 2017: 

- You may want to add libnuma-dev to the Build-Depends so NUMA control
  is available (see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=861554
  but there's a warning there it's not available on all platforms).

- You may want to optionally add glusterfs-common to Build-Depends
  so the Gluster ioengine is built.

- I don't know if it's possible but you may want to make some existing
  Build-Depends optional dependent on the platform (e.g. there's no
  libaio-dev package on non-Linux platforms like HURD or kFreeBSD - 
  https://buildd.debian.org/status/package.php?p=fio&suite=unstable ).

- You probably want export V = 1 in the debian/rules file otherwise
  make won't show much compiler output. This would address the
  compiler-flags-hidden build warning mentioned on
  https://qa.debian.org/bls/packages/f/fio.html .

Thanks,
Martin

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.16.0-rc6-tp520-btrfstrim-nolpm-quiescev2+ (SMP w/4 CPU cores; 
PREEMPT)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE= 
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages fio depends on:
ii  libaio1      0.3.111-1
ii  libc6        2.27-2
ii  libibverbs1  17.1-1
ii  librados2    10.2.5-7.2
ii  librbd1      10.2.5-7.2
ii  librdmacm1   17.1-1
ii  python       2.7.14-4
ii  zlib1g       1:1.2.8.dfsg-5

fio recommends no packages.

Versions of packages fio suggests:
ii  gfio                  3.5-1
ii  gnuplot               5.2.2+dfsg1-2
ii  gnuplot-qt [gnuplot]  5.2.2+dfsg1-2
ii  python-scipy          0.19.1-2

-- no debconf information

--- End Message ---
--- Begin Message ---
Source: fio
Source-Version: 3.5-1

We believe that the bug you reported is fixed in the latest version of
fio, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 893...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Martin Steigerwald <martin.steigerw...@proact.de> (supplier of updated fio 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 09 Apr 2018 13:45:59 +0200
Source: fio
Binary: fio gfio
Architecture: source amd64
Version: 3.5-1
Distribution: unstable
Urgency: medium
Maintainer: Martin Steigerwald <martin.steigerw...@proact.de>
Changed-By: Martin Steigerwald <martin.steigerw...@proact.de>
Description:
 fio        - flexible I/O tester
 gfio       - flexible I/O tester - gui frontend
Closes: 861554 872321 893778
Changes:
 fio (3.5-1) unstable; urgency=medium
 .
   * Imported upstream version 3.5.
   * Install systemd service file for running fio as a service, disabled
     by default (also see #893778).
   * Install sysvinit script for running fio as a service, disabled by
     default. Thanks to KatolaZ from Devuan project for helpful hint.
     Does not install any symlinks currently (see #894084).
   * patches:
     - Refreshed.
     - fix-ftbfs-with-libmtd.h: Removed. Implemented upstream (also see
     #893778).
     - makefile-hardening: Allow adding hardening options to CPPFLAGS as
       well.
     - reproducible-build: Removed. Implemented upstream (also see #893778
       and upstream commit 785e49c659023df1735bff195ad4ba133ebd23a7).
     - genfio-interpreter: Keep /bin/bash as interpreter, no usrmerge (yet).
   * changelog, rules: Removed trailing white spaces as lintian suggests.
   * compat: Switched debhelper compat level from 9 to 11 as lintian and
     debhelper manpage recommend.
   * control:
     - Switched Vcs URLs from Alioth to Salsa as I migrated the repo.
     - Bumped standards version to 4.1.4. No changes needed.
     - Updated build dependency to debhelper version 11 or later.
     - Added build dependency for libnuma1 for all architectures, except
       armhf and armel, where this library is not available (Closes: #861554,
       also see #893778).
     - Added build dependencies bison and flex to enable arithmetic
       calculations in fio jobs (see #893778, also see fio manpage,
       JOB FILE PARAMETERS).
     - Added build dependency for the fio GlusterFS engine (see #893778).
     - Disable build dependency for libaio for all platforms except Linux,
       to enable build on non-Linux platforms like Hurd (see #893778).
     - Change binary dependency to python2.7 as all the python scripts use
       this version.
   * rules:
     - Enable verbose build to allow tools like blhc to check for
       hardening flags for compiler and linker (see #893778).
     - Enable all hardening build flags, not just bindnow.
   * docs: Removed tools/fio_latency2csv.py, not in upstream source anymore.
   * copyright: Switched copyright format URL to https as Lintian suggests.
   * Implemented all suggestions from sitsofe´s Debian patch comments I
     decided to implement (Closes: #893778).
   * README.Debian: Added a note about fio´s weird usage of units in job
     files and parseable output (Closes: #872321).
Checksums-Sha1:
 e4e0cfb042cdebc90942a3543c06e1e13f1b5fae 1993 fio_3.5-1.dsc
 0d86a7a65f93c2e19e15ba5e39eb972b941435d0 729544 fio_3.5.orig.tar.gz
 20556f8138aa10d5b6d4243c6e1811b7fdd10380 19860 fio_3.5-1.debian.tar.xz
 44faece0bcd3d7099ddd2405fa26eb672485e4fe 1626688 fio-dbgsym_3.5-1_amd64.deb
 fe04edb5a8c50b619d98516261eb06c949cc7d88 12581 fio_3.5-1_amd64.buildinfo
 9518e7fe398397de131bdf88cc61bf37aa3afdce 490268 fio_3.5-1_amd64.deb
 502512efff5b9e268900eff96e345114fea8c35e 1673988 gfio-dbgsym_3.5-1_amd64.deb
 7af286f7c7b06c52ce3bf65732fef26ffd4a4519 372608 gfio_3.5-1_amd64.deb
Checksums-Sha256:
 4e6f760dd777ce68cca08896e760e59e43bd9d468718306239dcf5119075e550 1993 
fio_3.5-1.dsc
 32679a89e620c958d422ac3cafe9a08bd4adaaaa39613ad7ce180233aa1d8636 729544 
fio_3.5.orig.tar.gz
 2b8efb663f974cd92bf0865b8e19f3483e8ccaeaa9a9b367e77e42bc19530ed3 19860 
fio_3.5-1.debian.tar.xz
 7b246b73847276efb18318026d432adf777940674fb70e8340ef442de947294c 1626688 
fio-dbgsym_3.5-1_amd64.deb
 5bc3f9899990baa0928f94c792c6009a1df11c982b70337eefc5a9ec4d954b2b 12581 
fio_3.5-1_amd64.buildinfo
 8dd450b104e3817116e45766531c1ab0c5adbf5ce8be4c352982a5e8feb8a259 490268 
fio_3.5-1_amd64.deb
 3e4f422b2ac432298c591d5ddc0d2a66b822e24a632d650606f682568dd4048c 1673988 
gfio-dbgsym_3.5-1_amd64.deb
 25e6307dcae3ff919b92fc2a2b040e32581c09f44f8566f94d8ae97386bde4e3 372608 
gfio_3.5-1_amd64.deb
Files:
 c0ff710be4f1bea6ede43aca98cb8656 1993 utils optional fio_3.5-1.dsc
 ad9f143754d6bf843658cd9d05b19d3a 729544 utils optional fio_3.5.orig.tar.gz
 f08a105334a55ff307438403f64bbf70 19860 utils optional fio_3.5-1.debian.tar.xz
 2b7e689a5e2baceb826ccec58f8f5c78 1626688 debug optional 
fio-dbgsym_3.5-1_amd64.deb
 3e2a33681850b359f76bdb06ade6343b 12581 utils optional fio_3.5-1_amd64.buildinfo
 0a207dd62d96ef682f1baef5882ea742 490268 utils optional fio_3.5-1_amd64.deb
 e7b28c48dbb34755cd71ace07f3261bc 1673988 debug optional 
gfio-dbgsym_3.5-1_amd64.deb
 ca53c8a14d26cf990ba0900c203da2a6 372608 utils optional gfio_3.5-1_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEfAcX+forK514ixQbptwk2dokk9EFAlrLcQEACgkQptwk2dok
k9HkBxAAgBWx0+QRP9slVHrzHbaqgiDUSQ6s/j9Iwov0s7IeBQo1hr+A7Fx/Q06A
qHKXKLcKcOHt1O9uz5jyXqubZm74DpTr//4NcIDGDVxPLOxTGYgOOf3V6NHbkrO7
bByZ/2HvFu/dNFjdDLtVJEAwLEA30EYWITX0bB8RdD0+G7voNSKg34Rff1o66yUv
S00kpKxljUyj1daHjU5p61BxYaDZWkW/3ZimWeVYh8SMMbzZ3MAqKLwAnYip6qN+
oAE98ZLaWdvbh5qJCa4J29fO1LqcYummKHZClBGFCCAHxQH0fNWP5SfHBOb186PY
P3Yxwfl0SK4Wn+cQ5qU62I5g5D2wQaui58XN/gkIWaYabL3Qpr9fZNxKGZK8Lo4G
+4/0BuWZ3+X6opsSmBFFUAkC5f4LZbnlIaAJP6Gf01nDNK967Ezw+0GpjmwYQdSX
nJcFPuN2l0odCyc2yfcjfrmDQzGoB7Fv3QFfHT9fPU68mxnXjAiJHO9AmQx1Pk6I
Lp9YwanzQbuItPDcRBKbUKl2Qy+FO/ubBckuOU6Jwbi7ElAMefGg9X8b1pIMDWPJ
Nin4R2bQ2MyfodfLEuG8t5teK51qeSignPxPE1YzmaQ2DILX0Jx0FM6EpWdYoT1e
2m2oMJQ8IY4DZNcgfCZ2Cczw3ZLb+bfE50htQ1coP0bfhimMofg=
=/mZ/
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to