Your message dated Fri, 20 Apr 2018 01:49:47 +0000 with message-id <[email protected]> and subject line Bug#896132: fixed in thermald 1.7.0-6 has caused the Debian Bug report #896132, regarding thermald uninitialised member causes loss of temperature control to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 896132: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=896132 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: thermald Version: 1.7.0-5 Severity: critical Tags: patch Justification: breaks the whole system Dear Maintainer, 0002-Don-t-keep-on-reading-a-sensor-if-the-temperature-is.patch, added in 1.7.0-5, introduces a new cthd_sensor data member temp_unreadable but fails to initialise it. This causes nondeterministic behaviour. If any bits of the uninitialised boolean are nonzero, it will be evaluate to true, and the sensor will be silently disabled, causing loss of temperature control. This bug is critical because loss of temperature control risks physical hardware damage. Attached patch initialises temp_unreadable to restore temperature control. Kind regards, Ben. -- System Information: Debian Release: buster/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 4.15.0-2-amd64 (SMP w/8 CPU cores) Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8), LANGUAGE=en_GB:en (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages thermald depends on: ii libc6 2.27-3 ii libdbus-1-3 1.12.6-2 ii libdbus-glib-1-2 0.110-2 ii libgcc1 1:8-20180414-1 ii libglib2.0-0 2.56.1-2 ii libstdc++6 8-20180414-1 ii libxml2 2.9.4+dfsg1-6.1 ii lsb-base 9.20170808 thermald recommends no packages. thermald suggests no packages. -- Configuration Files: /etc/thermald/thermal-conf.xml changed: <?xml version="1.0"?> <ThermalConfiguration> <Platform> <Name>Passive control of CPU temperature</Name> <ProductName>*</ProductName> <Preference>QUIET</Preference> <ThermalZones> <ThermalZone> <Type>cpu</Type> <TripPoints> <TripPoint> <Temperature>80000</Temperature> <type>passive</type> </TripPoint> </TripPoints> </ThermalZone> </ThermalZones> </Platform> </ThermalConfiguration> -- no debconf information--- src/thd_sensor.cpp.orig 2018-04-20 10:23:54.571949701 +1200 +++ src/thd_sensor.cpp 2018-04-20 10:24:17.291460842 +1200 @@ -28,7 +28,7 @@ cthd_sensor::cthd_sensor(int _index, std::string control_path, std::string _type_str, int _type) : index(_index), type(_type), sensor_sysfs(control_path.c_str()), sensor_active( - false), type_str(_type_str), async_capable(false), virtual_sensor(false), thresholds(0) { + false), type_str(_type_str), async_capable(false), virtual_sensor(false), temp_unreadable(false), thresholds(0) { }
--- End Message ---
--- Begin Message ---Source: thermald Source-Version: 1.7.0-6 We believe that the bug you reported is fixed in the latest version of thermald, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Colin King <[email protected]> (supplier of updated thermald package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Fri, 20 Apr 2018 02:08:23 +0100 Source: thermald Binary: thermald Architecture: source amd64 Version: 1.7.0-6 Distribution: unstable Urgency: medium Maintainer: Colin King <[email protected]> Changed-By: Colin King <[email protected]> Description: thermald - Thermal monitoring and controlling daemon Closes: 896132 Changes: thermald (1.7.0-6) unstable; urgency=medium . [ Ben Caradoc-Davies ] * Fix non-initialized temp_unreadable (Closes: #896132) - fixes regression caused by previous fix, initialise temp_unreadable to restore temperature control. Checksums-Sha1: a84ca118b46ad78aa56b1511a47d415402296bae 1812 thermald_1.7.0-6.dsc a0b11c53e05f2cf93cec589d53274fdc70448322 8828 thermald_1.7.0-6.debian.tar.xz a5b1469964f3f3156d422f7a30838cd93fe0bba5 1887732 thermald-dbgsym_1.7.0-6_amd64.deb eff0e6530476575f8f5e10410653988260d5ec1b 6758 thermald_1.7.0-6_amd64.buildinfo 5147156953d35130e2bc35539dac96042ad22f5e 189092 thermald_1.7.0-6_amd64.deb Checksums-Sha256: 61e9ce303f470a7f2dbc5cee2f1d26df37302ecb388373f547df39c70280029b 1812 thermald_1.7.0-6.dsc 822066473f73d0fd4624616907901860263217515698703385cad14854606f68 8828 thermald_1.7.0-6.debian.tar.xz 71511f24af94894c2de8243cf7f9f72adbcc8a0dde980c362083cf344f452421 1887732 thermald-dbgsym_1.7.0-6_amd64.deb 9e9ce130235b6e5bf51a4104fad8d4aa0b5e93a02805d86160bacfa881b6f29b 6758 thermald_1.7.0-6_amd64.buildinfo c7ee19ef16c0d9dfc931baa89ae63c0c387cbe2fd0761eded0b9f2ad0f539103 189092 thermald_1.7.0-6_amd64.deb Files: 0192d792d8bc273c5710dca014248daf 1812 admin optional thermald_1.7.0-6.dsc 3b8389b2f1ca0c8b81e476e427179f3b 8828 admin optional thermald_1.7.0-6.debian.tar.xz 2018f6955cc3bbf833508269f238d360 1887732 debug optional thermald-dbgsym_1.7.0-6_amd64.deb d41f14e9de1efaaac977b5693fb64192 6758 admin optional thermald_1.7.0-6_amd64.buildinfo 113d0dd3fe4a96a8500f4b7a7fcd1c0c 189092 admin optional thermald_1.7.0-6_amd64.deb -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEcGLapPABucZhZwDPaMKH38aoAiYFAlrZQMMACgkQaMKH38ao AibINQ/+Jk/YkhkNd/+N9yDs4sL7tJARf0KeJIiJieZeNNYZppLa4/w5HH9+yN5y NNBYmse/HefF63duarPPMUtUx8tbQeqg/306YqErkNJxQroZLju9i4pp7fgym4ea kmUy9JVHHRBg/SfR/f7wml9YpEyBHOSHrBkOjjBgwUGIcNy1Hfz6bLljaxF3KS3M EeWyfP7LOIh1C0BTCK/d+lUEx7yn1NecCYWrfeLV2P93pb3BXSUYAYld3PoRHswb 68LbUr7s/msTZm4GWi2VtxYwZn8e7qiQu+Tx/RZb6NAVXcLqvrFeNiwfYeYU1D/q F9XT2Yv6dVWzQ/EU2rZvegAaliCX9hBH8TbT0zP8R12crx2HQHcVFbC6pZiXF6X+ oll7fbboKEETvyHzNaW6hfHC/x88pu56fpfIRZaEBTbyxQj9gArsWSXqIxdbFMvM 8OKxuSGWeVVC890keoAwV0/rQ8efA3clrGZ5H1C4n63xtwfJCvGqdcU26SCq3SnC Lu49E0kkfmluOvR8sMCZMB4iBASnk1du73dnQwvt3O6F8rdHFtL63Fqn3vTfFw/m 01v/xcUbjs2aWnz2LsYpgHYoBY0gLfVWLVI/UCjYtG7nEw+nJGEtg4mQ7RKD9Duj xbNi3Ee2Bn1grlQUcDAn3zwaa2Qm6/xpC3aN3v+DjKueP2kmOAM= =dblr -----END PGP SIGNATURE-----
--- End Message ---
