Your message dated Mon, 23 Apr 2018 04:34:24 +0000
with message-id <[email protected]>
and subject line Bug#882595: fixed in simple-cdd 0.6.6
has caused the Debian Bug report #882595,
regarding Support relative paths for all_extras option
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
882595: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=882595
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: simple-cdd
Version: 0.6.5
Tags: patch
Hi,
after spending an entire afternoon figuring out why simple-cdd wasn't including
my extra files, I stepped through the code and noticed that simple-cdd assumes
paths in PROFILE.extras to be absolute (and also fails silently, if the files
aren't there...)
Because all other file references (e.g. "local_packages") are relative, this is
extremely unintuitive. The fact that this behavior is undocumented doesn't
help, either.
Therefore, I propose files beginning with a '/' to be treated as absolute,
otherwise prepend the working directory of simple-cdd.
Patch attached.
Greetings
Jack
From c1d209417d21b4485da228c384e403f8ac6fec2a Mon Sep 17 00:00:00 2001
From: Jack Henschel <[email protected]>
Date: Fri, 24 Nov 2017 13:00:31 +0100
Subject: [PATCH] Add support for relative paths for "all_extras" and document
the change
Signed-off-by: Jack Henschel <[email protected]>
---
build-simple-cdd | 5 ++++-
simple-cdd.conf.detailed | 2 ++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/build-simple-cdd b/build-simple-cdd
index 5da6284..f06ddbc 100755
--- a/build-simple-cdd
+++ b/build-simple-cdd
@@ -136,7 +136,10 @@ class SimpleCDD:
for pathname in self.find_profile_files("{}.extra".format(p)):
# include the extra file itself, as well as the contents it references
self.env.append("all_extras", pathname)
- self.env.append("all_extras", self.read_list_file(pathname))
+ for f in self.read_list_file(pathname):
+ if f[0] != '/':
+ f = os.path.join(self.env.get("simple_cdd_dir"), f)
+ self.env.append("all_extras", f)
self.env.append("exclude_files", scdd.find_profile_files("{}.excludes".format(p)))
# Create our private GPG keyring unless we have been asked to use the
diff --git a/simple-cdd.conf.detailed b/simple-cdd.conf.detailed
index 7a851a0..0d1a1d4 100644
--- a/simple-cdd.conf.detailed
+++ b/simple-cdd.conf.detailed
@@ -57,6 +57,8 @@
# Extra files to include onto the CD
# These will get copied to /simple-cdd dir on the CD
+# Paths starting with '/' are interpreted as absolute, otherwise relative
+# to the currect directory.
#all_extras=""
# Generate a simple package repository on the CD with the debs cited
--
2.15.0
signature.asc
Description: OpenPGP digital signature
--- End Message ---
--- Begin Message ---
Source: simple-cdd
Source-Version: 0.6.6
We believe that the bug you reported is fixed in the latest version of
simple-cdd, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Vagrant Cascadian <[email protected]> (supplier of updated simple-cdd package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 22 Apr 2018 21:13:56 -0700
Source: simple-cdd
Binary: simple-cdd python3-simple-cdd simple-cdd-profiles
Architecture: source
Version: 0.6.6
Distribution: unstable
Urgency: medium
Maintainer: Simple-CDD Developers <[email protected]>
Changed-By: Vagrant Cascadian <[email protected]>
Description:
python3-simple-cdd - python3 modules for Simple-CDD
simple-cdd - create customized debian-installer CDs
simple-cdd-profiles - simple-cdd profile selection (udeb)
Closes: 879642 882595 894209
Changes:
simple-cdd (0.6.6) unstable; urgency=medium
.
[ Jack Henschel ]
* Add support for relative paths for "all_extras" and document the
change (Closes: #882595).
.
[ Vagrant Cascadian ]
* Add a workaround for arm64 not including kernel params with older
versions of debian-cd.
* Patch debian-cd apt configuration to allow unsigned repositories.
(Closes: #879642)
* Set DEBVERSION based on CODENAME by getting release information from
distro-info-data (Closes: #894209).
* Finish transition away from "wget" by naming "wget" methods to
"download".
* Change variable name wget_debian_mirror to files_debian_mirror.
* debian/control:
- Set Priority to optional.
- Update to Standards-Version 4.1.4.
- Add Build-Depends on dh-python.
- Update Vcs-* to use salsa.debian.org.
- Update Maintainer field.
* Update to debhelper compatibility level 11.
* Use dpkg pkg-info.mk include file to get the package version in
debian/rules.
* debian/copyright:
- Update to use https url for the Copyright-Format.
- Update years on copyright information.
Checksums-Sha1:
33ae58c0a8a0cec656f26e8d203c22b5e4b2262d 1852 simple-cdd_0.6.6.dsc
2ace77fbfd43aedee2cd0de0b451272ffa3d5b1b 43368 simple-cdd_0.6.6.tar.xz
8030f4f2d95720e95fecebbae5b645019eedf449 6665 simple-cdd_0.6.6_amd64.buildinfo
Checksums-Sha256:
487429bd989d31cd0c3855a15f0fdf013ba82deae8a393925e2fe5ee76bf8766 1852
simple-cdd_0.6.6.dsc
7e46c988c2deae4512ba1334250ed43633007670e8eeedf9c39d65331ebb50d4 43368
simple-cdd_0.6.6.tar.xz
04c526e293265a8faf40ac27e86d27ededd973716fc572c448e0039ac9292ae8 6665
simple-cdd_0.6.6_amd64.buildinfo
Files:
286c1d765d2ef6b32695f27ab6b603f9 1852 misc optional simple-cdd_0.6.6.dsc
9449a840d9e8dff5babf6923d454f2a3 43368 misc optional simple-cdd_0.6.6.tar.xz
43baae5ba9eb3cafb1561543e0f950b1 6665 misc optional
simple-cdd_0.6.6_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJHBAEBCgAxFiEEcDardHbDotegGFCHt4uC1IFLkbYFAlrdXrETHHZhZ3JhbnRA
ZGViaWFuLm9yZwAKCRC3i4LUgUuRtqmCD/9YedRBed36g6o36Ha7NHFj/nOjLdBz
nVdPHQoYxWxBmVfe5PWFSdf/Qe7TUaMMQ/BVkEoXY8BnWeZa1ZnnNwXkYzzDBVET
SyzwVba2e895T3l5X/JcOrA96iggZvB+wjLxsBYxEK0VyLMbGZit4Gc9MNlLSVa0
nRb3s5OhQc7HuU7HY4VOkfqzVHEo5ylRVXOKJuWpZR9hTfeUSJjeE+31GqMwHz8g
A8oh08mpygwzn5qr7uAdBvCUmv7nMNtV+wcxVe99AnH8OiSeX71wiq7rca/T7n1w
3E19rAcgm94gbYNQ3+cVzE21rT0Kv1uDJhsmZtQzA7ov84b0Ks1r2PyQpy6vurlk
dyjIwGtiUQinOFIdVXk2RhPyaQDM0NGo6CglRhINFZ+dvEHcghEGfbpFMi8muRmP
t6v5kR/usVcv82WtjDCsbMOY7i5kp2vqIANp+QDcfgZCpAkh2d8/yNG/ewTQWRvi
QhNbjErO8ouBATG269/oYKHsXnIC2dDyAf8q40nwS8w3wX5NfkGIRcBJjZpd+vrD
4ytnJFdwcmNu4Ncfq65P8w3QAS8XWSg6WggrND+FymQVzwt/eubdvi44Nd3VZ8hT
Z01arTfJWPF53NH/Fhvdk0Lq0JtAikO5qAV5UsKEpaKtzcLPGL2VtlT7/7/1i08C
ASE09wZ4HtIpEA==
=lmjh
-----END PGP SIGNATURE-----
--- End Message ---
