Your message dated Tue, 29 May 2018 23:30:59 +0200
with message-id <[email protected]>
and subject line Re: PDFPC Regression Bug
has caused the Debian Bug report #899336,
regarding pdf-presenter-console: [regression] movies are no longer recognized!
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
899336: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=899336
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: pdf-presenter-console
Version: 4.1.2-1
Severity: important
Hello,
I've just tested pdf-presenter-console/4.1.2-1 from Debian unstable.
It seems to fix bug #888677, as intended.
However, it appears to have a major regression (maybe caused by
collateral damage of the fix for bug #888677 ?!?): it no longer
recognizes movies in PDF pages. They are no longer clickable
in the presenter screen or in the audience screen.
Downgrading to pdf-presenter-console/4.1-4 makes movies work again.
I could even argue that this regression is big enough to justify a
"grave" severity for this bug report, as I think pdf-presenter-console
should not migrate to Debian testing after losing the really useful
movie-playing feature! It would be major step back!
Please raise the severity, if you agree with my reasoning.
Please forward this bug report upstream as soon as possible,
and/or revert the upstream change that introduced this regression.
Thanks for your time!
P.S.: after taking a look at the code, I wonder whether the regression
is maybe caused by the fact that, in file
pdfpc/src/classes/metadata/pdf.vala ,
the "page.remove_annot(a);" line has been added outside the
switch block:
List<Poppler.AnnotMapping> anns = page.get_annot_mapping();
foreach(unowned Poppler.AnnotMapping am in anns) {
var a = am.annot;
switch (a.get_annot_type()) {
case Poppler.AnnotType.TEXT:
case Poppler.AnnotType.FREE_TEXT:
case Poppler.AnnotType.HIGHLIGHT:
case Poppler.AnnotType.UNDERLINE:
case Poppler.AnnotType.SQUIGGLY:
if (note_text.length > 0) {
note_text += "\n";
}
note_text += a.get_contents();
break;
}
// Remove the annotation to avoid its rendering
page.remove_annot(a);
}
This means that, maybe, all annotations are removed, including
SCREEN and MOVIES ones, which should instead be preserved for
movie playing support... ?!?
Should the "page.remove_annot(a);" line be moved between
"note_text += a.get_contents();" and "break;", perhaps?
-- System Information:
Debian Release: buster/sid
APT prefers testing
APT policy: (800, 'testing'), (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 4.16.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages pdf-presenter-console depends on:
ii libatk1.0-0 2.28.1-1
ii libc6 2.27-3
ii libcairo-gobject2 1.15.10-3
ii libcairo2 1.15.10-3
ii libfribidi0 0.19.7-2
ii libgdk-pixbuf2.0-0 2.36.11-2
ii libgee-0.8-2 0.20.1-1
ii libglib2.0-0 2.56.1-2
ii libgstreamer-plugins-base1.0-0 1.14.0-2
ii libgstreamer1.0-0 1.14.0-1
ii libgtk-3-0 3.22.29-3
ii libpango-1.0-0 1.42.0-1
ii libpangocairo-1.0-0 1.42.0-1
ii libpoppler-glib8 0.63.0-2
ii libx11-6 2:1.6.5-1
Versions of packages pdf-presenter-console recommends:
ii gstreamer1.0-gtk3 1.14.0-4
pdf-presenter-console suggests no packages.
-- no debconf information
--- End Message ---
--- Begin Message ---
Source: pdf-presenter-console
Source-Version: 4.1.2-2
On Wed, 23 May 2018 19:56:49 +0200 Andreas Bilke wrote:
> Please see
> https://github.com/pdfpc/pdfpc/commit/21e4efb3afe325fe7e2f800d1c22fd1bc28bc3d7
>
> (I saw that i referenced the wrong bug report id in the commit message.)
Hello Andreas,
the patch has been integrated in the Debian package.
I've just tested pdf-presenter-console/4.1.2-2 (from Debian unstable)
and I can confirm that it appears to fix the regression on the movie
playing support.
Thanks a lot for reacting quickly (and thanks to Barak for uploading
the new revision of the Debian package).
I am closing the bug report about the movie playing regression.
Bye!
--
http://www.inventati.org/frx/
There's not a second to spare! To the laboratory!
..................................................... Francesco Poli .
GnuPG key fpr == CA01 1147 9CD2 EFDF FB82 3925 3E1C 27E1 1F69 BFFE
pgp80OD2SDxQt.pgp
Description: PGP signature
--- End Message ---
