Your message dated Tue, 26 Jun 2018 07:03:52 +0000
with message-id <[email protected]>
and subject line Bug#632665: fixed in cdpr 2.4-2
has caused the Debian Bug report #632665,
regarding ftbs with ld --as-needed
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
632665: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=632665
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: cdpr
Version: 2.4-1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: origin-ubuntu oneiric ubuntu-patch

the package cdpr fails to build when using the linker flag --as-needed
This is caused by the libraries being placed before the objects which
need the symbols on the command line. So the library symbols are not
registered as needed.
See the log in the ubuntu bug:
https://bugs.launchpad.net/ubuntu/+source/cdpr/+bug/803174

Attached patch fixes this issue by using ordering the command line
correctly.

Description: fix build with ld --as-needed
 when building with ld --as-needed libraries must be placed
 after object files needing them on the command line so the symbols
 of the libraries are registered as needed.
Author: Julian Taylor <[email protected]>
Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/cdpr/+bug/803174
--- cdpr-2.4.orig/Makefile
+++ cdpr-2.4/Makefile
@@ -16,7 +16,7 @@ CFLAGS = -Wall -W -O2
 # Build for Solaris with the pcap headers/libs one dir up
 #CFLAGS = -DSOLARIS -Wall -I. -I../libpcap-0.7.1 -L../libpcap-0.7.1 -ggdb
 
-LDFLAGS = -lpcap
+LIBS = -lpcap
 
 # Build for Solaris
 #LDFLAGS = -lsocket -lnsl -lpcap
@@ -33,7 +33,7 @@ conffile.o: conffile.c cdp.h cdpr.h
 	gcc -c $(CFLAGS) conffile.c
 
 cdpr: cdpr.o cdprs.o conffile.o
-	gcc $(LDFLAGS) -o cdpr cdpr.o cdprs.o conffile.o
+	gcc $(LDFLAGS) -o cdpr cdpr.o cdprs.o conffile.o $(LIBS)
 
 install: all
 	mkdir -p $(DESTDIR)$(prefix)/sbin/

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
--- Begin Message ---
Source: cdpr
Source-Version: 2.4-2

We believe that the bug you reported is fixed in the latest version of
cdpr, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Matt Zagrabelny <[email protected]> (supplier of updated cdpr package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 25 Jun 2018 16:02:40 -0500
Source: cdpr
Binary: cdpr
Architecture: source amd64
Version: 2.4-2
Distribution: unstable
Urgency: medium
Maintainer: Matt Zagrabelny <[email protected]>
Changed-By: Matt Zagrabelny <[email protected]>
Description:
 cdpr       - Cisco Discovery Protocol Reporter
Closes: 632665 901066
Changes:
 cdpr (2.4-2) unstable; urgency=medium
 .
   * [895bdef] d/control replace priority extra with priority optional.
   * [202edaa] bump standards version
   * [a667541] bump debhelper compat level
   * [87086e0] remove versioned dependency for libpcap0.8-dev.
   * [811a051] update git repo to salsa.debian.org
   * [cf9615d] enable all hardening options
   * [0d80c19] comment out CFLAGS to allow dpkg-buildflags to set CFLAGS.
   * [79a3c5b] fix ftbs with ld --as-needed, closes: #632665.
   * [3900e99] Simplify Makefile, add CPPFLAGS for hardening,
     also closes: #901066.
   * [d6595fa] update URI for machine parsable copyright format 1.0
   * [cd7664e] update copyright year for debian/* files
   * [ebf169d] update GPL-2+ text in d/copyright
Checksums-Sha1:
 4ce46b0fa5309ac2c7b8fc8e5e9e0dd459f86d0e 1783 cdpr_2.4-2.dsc
 0ca444d5a5732116b55ddb06a5d1f07601b39ea2 4812 cdpr_2.4-2.debian.tar.xz
 c5cc69a85dad235c61be9182466d7119cdea6db7 22404 cdpr-dbgsym_2.4-2_amd64.deb
 cd837b3b46bba8adb8113d69bd585597922442bb 5758 cdpr_2.4-2_amd64.buildinfo
 c4a8833169419c37f64a13f1c806f315a17686c1 19524 cdpr_2.4-2_amd64.deb
Checksums-Sha256:
 f910e68465135a006c1900538e9e6cb0e70980414535f29146f68ebb8b7fef8e 1783 
cdpr_2.4-2.dsc
 b2a5a0f608f39cd36e4ab890a752256c018ec4f75379508fad2a08ef986bd1ab 4812 
cdpr_2.4-2.debian.tar.xz
 61f142c11d07333ebff4e0b29fb8c12bf13469c09a33c01c424de574306112f1 22404 
cdpr-dbgsym_2.4-2_amd64.deb
 6b31120e04737f095b75abfcdf89c6e5f309551b47593123b88b6552280db281 5758 
cdpr_2.4-2_amd64.buildinfo
 d7bbc179be0ad2b1fa2e38d4106b2939565c2bff19b3e1d9ac3e13021f373314 19524 
cdpr_2.4-2_amd64.deb
Files:
 17745e7f6d2bd786f49cacf7b012ef3c 1783 net optional cdpr_2.4-2.dsc
 c15c59ed87d0b5a9aa635644a1bbf5a8 4812 net optional cdpr_2.4-2.debian.tar.xz
 998c6052292cc6f92c72f0df7ce84e25 22404 debug optional 
cdpr-dbgsym_2.4-2_amd64.deb
 00bd5a7268203010e11067edc065da2d 5758 net optional cdpr_2.4-2_amd64.buildinfo
 7e82727fc6eced8994ce3f3191a094ee 19524 net optional cdpr_2.4-2_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEfAcX+forK514ixQbptwk2dokk9EFAlsx4QcACgkQptwk2dok
k9F3Rw//fvylF25STLzdFLVxcxyZ7nFugv3qoyFc2IiyvxjQaQ0tLq9SAWi8EwIb
rBpFiSA9hF8R7oS3pXH1YF8UnPTo6baBq9fK+Bwm36s8zdW6BztKaI8APwqAEPz/
8on/xJTvJUKugMhR4B8RUm41P+kROSRo6Mdj7wn5KbjdCAdga6huKLCjkxaHBl4D
2CPK+YY2JIhhnqluBFUPvqV2Bz5pahkSiZaGesfTQTDn/+ZSQ0Ywg/KAQr1FQYnt
8BJnqlRS7SsAbZ0Aj5K7mAiEo0GLmuBE2nuhNN4Upc5MyMX53Fk1x0c9y8LY85YF
WshJp1yC6pvRj8+h2uYmWDUavoB+b3Bot0SQtcqnlikgR1IW4OYqB0ty2nzxA1YL
gpyaWUsXF1hBQLTQPkXzLkIsgG2Q/0scyVK4lxqGTOejckji7xgprLgGAmqEKSsI
++lphxA1r77EHZ9zvyH+YJmO3pzslfodQ0UGxwfU+FiE0H+852lWq6O4amLaehim
Vo2QfLyvYqlg+pTKrpLAHvYiJLD3k07Ws4REoJOCrbZGChjVYiytZTTRm8DAOKvq
XphI5cuhDQ/dkWu0Qmq3mJ/vaY1+FbtP27ggacjEIRMNn4cFNdocs/EgVYM/Qeeq
y0axyiP5Mc1xYBqG3PFDeTvhywtztxW2tQQiqxwBsMjdSITTvts=
=7BPJ
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to