Your message dated Sun, 01 Jul 2018 19:34:59 +0000
with message-id <[email protected]>
and subject line Bug#758728: fixed in fakeroot 1.23-1
has caused the Debian Bug report #758728,
regarding Use getopt -T to test for GNU getopt
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
758728: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=758728
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: fakeroot
Version: 1.20-3
Severity: minor
Tags: patch

Hi,

(Forgot to send this earlier)

An user of fakeroot under a Dutch locale reported that fakeroot (and
fakeroot using apps) was broken under this locale:
https://bugs.launchpad.net/ubuntu/+source/fakeroot/+bug/1290069

This is because the fakeroot wrapper shell script attempts parsing of
the gettext --version output. One option would be to set locale to C
before parsing version output, but since the goal is to test whether
we have GNU getopt, and since there's a special -T flag to test this,
this is what the patch does.

(See attached debdiff and patch)

Cheers,
-- 
Loïc Minier
diff -Nru fakeroot-1.20/debian/changelog fakeroot-1.20/debian/changelog
--- fakeroot-1.20/debian/changelog      2014-03-24 05:52:53.000000000 +0100
+++ fakeroot-1.20/debian/changelog      2014-05-20 15:11:19.000000000 +0200
@@ -1,3 +1,10 @@
+fakeroot (1.20-3ubuntu3) utopic; urgency=medium
+
+  * New patch, getopt-gnu-test, use "getopt -T" to test for GNU getopt rather
+    than parsing the --version output which is locale specific; LP: #1290069.
+
+ -- Loïc Minier <[email protected]>  Tue, 20 May 2014 15:10:08 +0200
+
 fakeroot (1.20-3ubuntu2) trusty; urgency=medium
 
   * fix-xattr-prototypes.patch: Fix prototypes for xattr functions.
diff -Nru fakeroot-1.20/debian/patches/getopt-gnu-test.patch 
fakeroot-1.20/debian/patches/getopt-gnu-test.patch
--- fakeroot-1.20/debian/patches/getopt-gnu-test.patch  1970-01-01 
01:00:00.000000000 +0100
+++ fakeroot-1.20/debian/patches/getopt-gnu-test.patch  2014-05-20 
15:09:07.000000000 +0200
@@ -0,0 +1,24 @@
+Index: fakeroot-1.20/scripts/fakeroot.in
+===================================================================
+--- fakeroot-1.20.orig/scripts/fakeroot.in
++++ fakeroot-1.20/scripts/fakeroot.in
+@@ -43,15 +43,12 @@ export FAKED_MODE
+ 
+ libfound=no
+ 
+-GETOPTEST=`getopt --version`
+-case $GETOPTEST in
+-getopt*) # GNU getopt
++GETOPTTEST=`getopt -T`
++if test "$?" -eq 4; then # GNU getopt
+     FAKE_TEMP=`getopt -l lib: -l faked: -l unknown-is-real -l fd-base: -l 
version -l help -- +l:f:i:s:ub:vh "$@"`
+-    ;;
+-*) # POSIX getopt ?
++else
+     FAKE_TEMP=`getopt l:f:i:s:ub:vh "$@"`
+-    ;;
+-esac
++fi
+ 
+ if test "$?" -ne 0; then
+   usage
diff -Nru fakeroot-1.20/debian/patches/series 
fakeroot-1.20/debian/patches/series
--- fakeroot-1.20/debian/patches/series 2014-03-24 05:53:23.000000000 +0100
+++ fakeroot-1.20/debian/patches/series 2014-05-20 15:08:55.000000000 +0200
@@ -2,3 +2,4 @@
 Fix-FTBFS
 powerpc64le-support.patch
 fix-xattr-prototypes.patch
+getopt-gnu-test.patch
Index: fakeroot-1.20/scripts/fakeroot.in
===================================================================
--- fakeroot-1.20.orig/scripts/fakeroot.in
+++ fakeroot-1.20/scripts/fakeroot.in
@@ -43,15 +43,12 @@ export FAKED_MODE
 
 libfound=no
 
-GETOPTEST=`getopt --version`
-case $GETOPTEST in
-getopt*) # GNU getopt
+GETOPTTEST=`getopt -T`
+if test "$?" -eq 4; then # GNU getopt
     FAKE_TEMP=`getopt -l lib: -l faked: -l unknown-is-real -l fd-base: -l version -l help -- +l:f:i:s:ub:vh "$@"`
-    ;;
-*) # POSIX getopt ?
+else
     FAKE_TEMP=`getopt l:f:i:s:ub:vh "$@"`
-    ;;
-esac
+fi
 
 if test "$?" -ne 0; then
   usage

--- End Message ---
--- Begin Message ---
Source: fakeroot
Source-Version: 1.23-1

We believe that the bug you reported is fixed in the latest version of
fakeroot, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Clint Adams <[email protected]> (supplier of updated fakeroot package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 25 Jun 2018 12:52:49 -0400
Source: fakeroot
Binary: fakeroot libfakeroot
Architecture: source
Version: 1.23-1
Distribution: unstable
Urgency: medium
Maintainer: Clint Adams <[email protected]>
Changed-By: Clint Adams <[email protected]>
Description:
 fakeroot   - tool for simulating superuser privileges
 libfakeroot - tool for simulating superuser privileges - shared libraries
Closes: 758728 876053
Changes:
 fakeroot (1.23-1) unstable; urgency=medium
 .
   * Swedish man page translation from Sebastian Rasmussen.
     closes: #876053.
   * Patch from Loïc Minier to use getopt -T to test for GNU.
     closes: #758728.
   * Add autopkgtests.
Checksums-Sha1:
 021fd39ba017774f8e25b4d93240bc6d40949920 2082 fakeroot_1.23-1.dsc
 897c18d72811e5abddd384ae73566770be6e923b 298080 fakeroot_1.23.orig.tar.xz
 a87f1d8090cd7f0e1ce501db7ca953464fbc6aa9 208208 fakeroot_1.23-1.debian.tar.xz
Checksums-Sha256:
 fe633e19a18d720b1836426d90f63c837ec8f712042286be7ab6243ff51114a6 2082 
fakeroot_1.23-1.dsc
 009cd6696a931562cf1c212bb57ca441a4a2d45cd32c3190a35c7ae98506f4f6 298080 
fakeroot_1.23.orig.tar.xz
 e2ea80f2a2485f1970ae11711be61de86c8c56425c18660b00ba2e93197cd867 208208 
fakeroot_1.23-1.debian.tar.xz
Files:
 5313633a1e8db7da0d9556d683761535 2082 utils optional fakeroot_1.23-1.dsc
 b82c5e99b6365a838e73d05718083f6a 298080 utils optional 
fakeroot_1.23.orig.tar.xz
 ac041a2ed65a3536e213de60d45e713b 208208 utils optional 
fakeroot_1.23-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Comment: Debian!

iQKTBAEBCgB9FiEEdYHsh0BT5sgHeRubVZIzHhmdOKgFAls5Jy1fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDc1
ODFFQzg3NDA1M0U2QzgwNzc5MUI5QjU1OTIzMzFFMTk5RDM4QTgACgkQVZIzHhmd
OKiGBhAAiTNXKff1XxCjvF8a1z0gazO+LGiaVxV9idmrwjPHZKSdslr/irqcsN1A
WzptsJp3sLIicBuV8m7wIU15xfOJkS3WOcfiTD+/Mm9qkoDvZU+Qm5YxPmnOLseD
NjRR9yhyF0FZCo7qYGJwD33f2S4n3SDj5CFbD7heRUgBZQPShMZCmd2SjFPuKfSY
hExHM3InIDRRkCUoUXjAlAe79d+IvE9xMc2mR+d4GU0WUT5efjIIV4qLZjw/MYzI
Lh4bf8UTZPjA6cE9Cqk4N75vqHP88+/c52qXHVzd1x8FZt6ARKBUf93LEmBFRbtj
xFF2e03oeX3Uw+yFjTWn09t0zxLbIqio7qqAyUwOLnVkmMwZ0Ze4biPf3H6fSveW
y/NbZ/dRDpeL9WnvF6bECJTLK+/8s4zDiZtIJ6l8rGBP76L7/eNEs2Jdw88iVE2x
+lZLQfHfmGtsyTJ9GnIW5oZAZ4Kk1URx9mb+oyTtK98ASgBP6c6u+QEQYs8ddr4a
v130n8nEFl8xuvBtbsDZNLMb9oz98lCPc55qRGgKPtMeGmNUyok2xdJdbBkLT7Qz
VLdN2/UdAA3dA/L3l0+2xH4XeXjcYj43yj/Tp0rk9v0Pcz6aszO3EkXeCeO8FM62
DEzB7NifqUaLpWDzYY6wjl6u5f3X3fr9ey8twFJGYpFmJ5s5X/k=
=YUgA
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to