Your message dated Mon, 2 Jul 2018 19:51:49 +0200
with message-id <[email protected]>
and subject line Closing bugs missing bug number in changelog
has caused the Debian Bug report #862362,
regarding autopkgtest-virt-qemu: /dev/baseimage still causes problems for
/dev/disk/by-*
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
862362: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=862362
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: autopkgtest
Version: 4.4
Severity: normal
Tags: patch
The changes made for #842299 do not seem to be entirely reliable: I still
sometimes get /dev/disk/by-partlabel/* pointing to /dev/vdb* (the read-only
copy of the base image) rather than the expected /dev/vda* (the read/write
overlay). This is problematic for an embedded Debian derivative that I'm
working on, which uses those symlinks.
I wonder whether this might be a result of not explicitly waiting for the
shell prompt to be issued after previous commands on ttyS1, such that when
we wait for a shell prompt to synchronize after doing udev things, we are
actually seeing the shell prompt from some previous command. I haven't had
a chance to try/debug that yet though.
Since the base image is rarely used and clearly rather subtle, I think a
pragmatic approach to this might be to make it optional, as with the
attached patch.
Regards,
S
-- System Information:
Debian Release: 9.0
APT prefers testing-proposed-updates
APT policy: (500, 'testing-proposed-updates'), (500, 'stable-updates'), (500,
'unstable'), (500, 'testing'), (500, 'stable'), (100, 'experimental')
Architecture: amd64
(x86_64)
Foreign Architectures: i386
Kernel: Linux 4.9.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages autopkgtest depends on:
ii apt-utils 1.4.2
ii libdpkg-perl 1.18.23
ii procps 2:3.3.12-3
ii python3 3.5.3-1
ii python3-debian 0.1.30
Versions of packages autopkgtest recommends:
ii autodep8 0.8
Versions of packages autopkgtest suggests:
pn lxc <none>
pn lxd-client <none>
ii qemu-system 1:2.8+dfsg-4+b2
ii qemu-utils 1:2.8+dfsg-4+b2
ii schroot 1.6.10-3+b1
-- no debconf information
>From 886a33ef7d516945f9ff7dd730435ba59ffbacaf Mon Sep 17 00:00:00 2001
From: Simon McVittie <[email protected]>
Date: Thu, 11 May 2017 17:26:36 +0100
Subject: [PATCH] Only set up base image device if requested
Adding a second virtual disk with the same UUIDs, partition labels,
filesystem labels etc. can interfere with anything that mounts filesystems
post-boot, and the attempts to address this in #842299 do not seem to
have been completely successful. Nested virtualization is a rare thing
to need, so let's make this opt-in.
Signed-off-by: Simon McVittie <[email protected]>
---
virt/autopkgtest-virt-qemu | 22 +++++++++++++++-------
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/virt/autopkgtest-virt-qemu b/virt/autopkgtest-virt-qemu
index eb3b162..5d55d2d 100755
--- a/virt/autopkgtest-virt-qemu
+++ b/virt/autopkgtest-virt-qemu
@@ -88,6 +88,11 @@ def parse_args():
help='Enable debugging output')
parser.add_argument('--qemu-options',
help='Pass through arguments to QEMU command.')
+ parser.add_argument('--baseimage', action='store_true', default=False,
+ help='Provide a read-only copy of the base image at /dev/baseimage')
+ parser.add_argument('--no-baseimage', dest='baseimage',
+ action='store_false',
+ help='Provide a read-only copy of the base image at /dev/baseimage')
parser.add_argument('image', nargs='+',
help='disk image to add to the VM (in order)')
@@ -565,7 +570,8 @@ def hook_open():
# files; let QEMU run with the deleted inode
os.unlink(overlay)
setup_shell()
- setup_baseimage()
+ if args.baseimage:
+ setup_baseimage()
setup_shared(shareddir)
setup_config(shareddir)
make_auxverb(shareddir)
@@ -604,11 +610,12 @@ def hook_cleanup():
def hook_prepare_reboot():
- # Remove baseimage drive again, so that it does not break the subsequent
- # boot due to the duplicate UUID
- monitor = VirtSubproc.get_unix_socket(os.path.join(workdir, 'monitor'))
- monitor.send(b'device_del virtio-baseimage\n')
- VirtSubproc.expect(monitor, b'(qemu)', 10)
+ if args.baseimage:
+ # Remove baseimage drive again, so that it does not break the subsequent
+ # boot due to the duplicate UUID
+ monitor = VirtSubproc.get_unix_socket(os.path.join(workdir, 'monitor'))
+ monitor.send(b'device_del virtio-baseimage\n')
+ VirtSubproc.expect(monitor, b'(qemu)', 10)
def hook_wait_reboot():
@@ -618,7 +625,8 @@ def hook_wait_reboot():
wait_boot()
setup_shell()
setup_shared(shareddir)
- setup_baseimage()
+ if args.baseimage:
+ setup_baseimage()
def hook_capabilities():
--
2.11.0
--- End Message ---
--- Begin Message ---
Version: 5.4
-------- Forwarded Message --------
Subject: autopkgtest_5.4_source.changes ACCEPTED into unstable
Date: Mon, 02 Jul 2018 11:19:01 +0000
From: Debian FTP Masters <[email protected]>
To: Debian CI team <[email protected]>, Paul Gevers
<[email protected]>
Accepted:
Format: 1.8
Date: Mon, 02 Jul 2018 11:50:21 +0200
Source: autopkgtest
Binary: autopkgtest
Architecture: source
Version: 5.4
Distribution: unstable
Urgency: medium
Maintainer: Debian CI team <[email protected]>
Changed-By: Paul Gevers <[email protected]>
Description:
autopkgtest - automatic as-installed testing for Debian packages
Closes: 832751 851558 867081 897170 901643
Changes:
autopkgtest (5.4) unstable; urgency=medium
.
[ Simon McVittie ]
* README.package-tests.rst: Document AUTOPKGTEST_NORMAL_USER
* d/tests/lxd: Don't assume all test-runners set AUTOPKGTEST_NORMAL_USER
* qemu: Only set up base image device if requested
* qemu: Document --baseimage
* qemu: Update test for --baseimage no longer being the default
* qemu, lxc, lxd: Look for a user account in the 1000-59999 range
(Closes: #897170)
* qemu: Add a shortcut for running tests on an EFI-booted image
* doc: Describe how to parse Features, Restrictions, Classes
* Add support for flaky tests (Closes: #851558)
* Add support for tests declaring themselves to have been skipped
* autopkgtest(1): Document FLAKY as a possible summary status
.
[ Balint Reczey ]
* Fix bashism in retrying apt update
.
[ Paul Gevers ]
* Enable testing to continue after badpkg (Closes: #832751)
* adt_testbed.py fix missed piece of regular expression in commit a7e1dad
* d/tests/autopkgtest Update SchrootRunner
* runner/autopkgtest: Drop Ubuntu 12.04 fallback
* manpage: make ordering consistent with --help (Closes: #901643)
.
[ Julian Andres Klode ]
* ssh-setup/nova: Add support for keystone v3 auth (LP: #1767433)
.
[ Rafael Laboissiere ]
* Set Maintainer email address to [email protected]
.
[ Niko Tyni ]
* Add a couple of testcases for versioned provides support
* Ensure synthesized test dependencies are not satisfied by versioned
Provides
(Closes: #867081)
* Remove the old '(>= 0)' hack for ensuring '@' pulls in real packages
Checksums-Sha1:
1720155af7c18ae32212b2e6a0bde1a73b79e98b 1582 autopkgtest_5.4.dsc
f9b0c5ab38b22484d0176eec1f115bb0b369116b 173636 autopkgtest_5.4.tar.xz
Checksums-Sha256:
5ccc59ec2985b5557763764309867a6068f7139de3e9d06f1e43e240894b4aa4 1582
autopkgtest_5.4.dsc
c8c5c14298105d1798ce9a20a4f7d2b837279939a94da5fdc761111517575030 173636
autopkgtest_5.4.tar.xz
Files:
b12bae17fc3461b1d46d93bf4863c768 1582 devel optional autopkgtest_5.4.dsc
7abe82af7806ef1c477f0fb1be65b7c7 173636 devel optional
autopkgtest_5.4.tar.xz
Thank you for your contribution to Debian.
signature.asc
Description: OpenPGP digital signature
--- End Message ---
