Your message dated Sat, 11 Aug 2018 11:47:07 +0000
with message-id <e1fosmn-000frg...@fasolo.debian.org>
and subject line Bug#859157: fixed in multipath-tools 0.6.4-5+deb9u1
has caused the Debian Bug report #859157,
regarding multipath-tools: after bootup multipathd timeout on commands - 
requires daemon restart
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
859157: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=859157
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: multipath-tools
Version: 0.6.4-5.1
Severity: normal

Dear Maintainer,
multipathd does not respond to commands : list paths or list maps
returns "timed out".

The mutlipathd daemon when triggered by udev locks up in uev_add_path
per this locks is already helds by its caller uev_update_path.

Here in thread 5 uev_update_path and uev_add_path chain
 (note that in thread 4 checkerloop also waits for this lock).

(gdb) t a a bt

Thread 6 (Thread 0x7f922663c700 (LWP 545)):
#0  syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:38
#1  0x00007f9228bd3602 in ?? () from /usr/lib/x86_64-linux-gnu/liburcu.so.4
#2  0x00007f92289ba424 in start_thread (arg=0x7f922663c700) at 
pthread_create.c:333
#3  0x00007f922825c9bf in clone () at 
../sysdeps/unix/sysv/linux/x86_64/clone.S:105

Thread 5 (Thread 0x7f9229734700 (LWP 543)):
#0  __lll_lock_wait () at ../sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:135
#1  0x00007f92289bcb85 in __GI___pthread_mutex_lock (mutex=0x556fefc43080) at 
../nptl/pthread_mutex_lock.c:80
#2  0x0000556fedcbe42d in lock (a=0x556fefc43080) at ../libmultipath/lock.h:12
#3  uev_add_path (vecs=0x556fefc43080, uev=<optimized out>, uev=<optimized 
out>) at main.c:627
#4  0x0000556fedcbe9c9 in uev_update_path (uev=0x7f9220001510, 
vecs=0x556fefc43080) at main.c:998
#5  0x0000556fedcbecdb in uev_trigger (uev=0x7f9220001510, 
trigger_data=0x556fefc43080) at main.c:1146
#6  0x00007f92292091b2 in service_uevq (tmpq=tmpq@entry=0x7f9229733b10) at 
uevent.c:89
#7  0x00007f9229209280 in uevent_dispatch (uev_trigger=<optimized out>, 
trigger_data=<optimized out>) at uevent.c:145
#8  0x0000556fedcbc2cc in uevqloop (ap=0x556fefc43080) at main.c:1177
#9  0x00007f92289ba424 in start_thread (arg=0x7f9229734700) at 
pthread_create.c:333
#10 0x00007f922825c9bf in clone () at 
../sysdeps/unix/sysv/linux/x86_64/clone.S:105

Thread 4 (Thread 0x7f9229745700 (LWP 542)):
#0  __lll_lock_wait () at ../sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:135
#1  0x00007f92289bcb85 in __GI___pthread_mutex_lock (mutex=0x556fefc43080) at 
../nptl/pthread_mutex_lock.c:80
#2  0x0000556fedcbfb45 in lock (a=0x556fefc43080) at ../libmultipath/lock.h:12
#3  checkerloop (ap=0x556fefc43080) at main.c:1827
#4  0x00007f92289ba424 in start_thread (arg=0x7f9229745700) at 
pthread_create.c:333
#5  0x00007f922825c9bf in clone () at 
../sysdeps/unix/sysv/linux/x86_64/clone.S:105

Thread 3 (Thread 0x7f9229810700 (LWP 541)):
#0  0x00007f9228253611 in __GI_ppoll (fds=0x7f92180021e0, nfds=nfds@entry=1, 
timeout=<optimized out>, timeout@entry=0x556fedecc020 <sleep_time>, 
sigmask=sigmask@entry=0x7f922980fa60) at ../sysdeps/unix/sysv/linux/ppoll.c:39
#1  0x0000556fedcc13ba in ppoll (__ss=0x7f922980fa60, __timeout=0x556fedecc020 
<sleep_time>, __nfds=1, __fds=<optimized out>) at 
/usr/include/x86_64-linux-gnu/bits/poll2.h:77
#2  uxsock_listen (uxsock_trigger=0x556fedcbb520 <uxsock_trigger>, 
trigger_data=0x556fefc43080) at uxlsnr.c:204
#3  0x0000556fedcbbd5a in uxlsnrloop (ap=0x556fefc43080) at main.c:1239
#4  0x00007f92289ba424 in start_thread (arg=0x7f9229810700) at 
pthread_create.c:333
#5  0x00007f922825c9bf in clone () at 
../sysdeps/unix/sysv/linux/x86_64/clone.S:105

Thread 2 (Thread 0x7f9229851700 (LWP 540)):
#0  0x00007f922825354d in poll () at ../sysdeps/unix/syscall-template.S:84
#1  0x00007f9229209f3a in poll (__timeout=<optimized out>, __nfds=1, 
__fds=0x7f9229850a88) at /usr/include/x86_64-linux-gnu/bits/poll2.h:46
#2  uevent_listen (udev=0x556fefbec040) at uevent.c:515
#3  0x0000556fedcbc235 in ueventloop (ap=0x556fefbec040) at main.c:1166
#4  0x00007f92289ba424 in start_thread (arg=0x7f9229851700) at 
pthread_create.c:333
#5  0x00007f922825c9bf in clone () at 
../sysdeps/unix/sysv/linux/x86_64/clone.S:105

Thread 1 (Thread 0x7f9229746f00 (LWP 537)):
#0  pthread_cond_wait@@GLIBC_2.3.2 () at 
../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
#1  0x0000556fedcc0aba in child (param=<optimized out>) at main.c:2407
#2  0x0000556fedcbb0df in main (argc=<optimized out>, argv=0x7fff81f9a0d8) at 
main.c:2664


Attached is a hash workaround that move uev_add_path call after the locks are 
released.

This also helps with shutdown/reboot which was waiting a long while for 
multipathd to terminate
before killing it under systemd.


Best regards
Alban







-- Package-specific info:
/etc/multipath.conf does not exist.


-- System Information:
Debian Release: 9.0
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (500, 'testing'), (1, 
'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.10.0-trunk-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages multipath-tools depends on:
ii  init-system-helpers  1.47
ii  kpartx               0.6.4-5.1
ii  libaio1              0.3.110-3
ii  libc6                2.24-9
ii  libdevmapper1.02.1   2:1.02.137-2
ii  librados2            10.2.5-6
ii  libreadline7         7.0-2
ii  libsystemd0          232-22
ii  libudev1             232-22
ii  liburcu4             0.9.3-3
ii  lsb-base             9.20161125
ii  sg3-utils-udev       1.42-2
ii  udev                 232-22

multipath-tools recommends no packages.

Versions of packages multipath-tools suggests:
ii  multipath-tools-boot  0.6.4-5.1

-- no debconf information
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -994,9 +994,8 @@
                                pp->wwid_changed = 0;
                }
 
-               if (pp->initialized == INIT_REQUESTED_UDEV)
-                       retval = uev_add_path(uev, vecs);
-               else if (mpp && ro >= 0) {
+               if ((pp->initialized != INIT_REQUESTED_UDEV)
+                  && (mpp && ro >= 0)) {
                        condlog(2, "%s: update path write_protect to '%d' 
(uevent)", uev->kernel, ro);
 
                        if (mpp->wait_for_udev)
@@ -1010,6 +1009,9 @@
        }
 out:
        lock_cleanup_pop(vecs->lock);
+       if (pp)
+               if (pp->initialized == INIT_REQUESTED_UDEV)
+                       retval = uev_add_path(uev, vecs);
        if (!pp)
                condlog(0, "%s: spurious uevent, path not found", uev->kernel);
 

--- End Message ---
--- Begin Message ---
Source: multipath-tools
Source-Version: 0.6.4-5+deb9u1

We believe that the bug you reported is fixed in the latest version of
multipath-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 859...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Hofstaedtler <z...@debian.org> (supplier of updated multipath-tools 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 23 Jul 2018 06:16:34 +0000
Source: multipath-tools
Binary: multipath-tools kpartx multipath-tools-boot multipath-udeb kpartx-udeb
Architecture: source
Version: 0.6.4-5+deb9u1
Distribution: stretch
Urgency: medium
Maintainer: Debian DM Multipath Team <team+linux-blo...@tracker.debian.org>
Changed-By: Chris Hofstaedtler <z...@debian.org>
Description:
 kpartx     - create device mappings for partitions
 kpartx-udeb - create device mappings for partitions - udeb package (udeb)
 multipath-tools - maintain multipath block device access
 multipath-tools-boot - Support booting from multipath devices
 multipath-udeb - maintain multipath block device access - udeb package (udeb)
Closes: 859157 899615
Changes:
 multipath-tools (0.6.4-5+deb9u1) stretch; urgency=medium
 .
   [ Chris Hofstaedtler ]
   * Apply patch to avoid deadlock in udev triggers, based on upstream
     10704bae99cdcc809aaba0546017cb2eb416c551, with adaptions from
     Alban Browaeys <pra...@yahoo.com> for 0.6.
     (Closes: #859157)
   * Add myself to Uploaders:.
 .
   [ Ritesh Raj Sarraf ]
   * Use tracker as maintainer email address
   * Switch packaging repository to Salsa (Closes: #899615)
Checksums-Sha1:
 4c9379423063a3acf834bb1b54304def60cb3096 2635 
multipath-tools_0.6.4-5+deb9u1.dsc
 459f6bb39730d60811988f1804e6195eb75d4d59 32244 
multipath-tools_0.6.4-5+deb9u1.debian.tar.xz
 7f8c2c00669fd558c627ef7b41e6681b39c4c77d 7091 
multipath-tools_0.6.4-5+deb9u1_source.buildinfo
Checksums-Sha256:
 78ff45628da3cd474ef87a9056a06ca6577abe0c9db965d3d74f50d6f0a11f71 2635 
multipath-tools_0.6.4-5+deb9u1.dsc
 b516f85f569be84e082fad510e455dd04b8bdd137c60368e02b60602abec4507 32244 
multipath-tools_0.6.4-5+deb9u1.debian.tar.xz
 cb480292e29f1a0c0a994c8a2262cd9b4e936272ef87ab5e312b26f3ad763e74 7091 
multipath-tools_0.6.4-5+deb9u1_source.buildinfo
Files:
 b110b0742f9f112e86d028852df514c2 2635 admin extra 
multipath-tools_0.6.4-5+deb9u1.dsc
 f27e5ebe8dc8b8f6c15617dd119d50ba 32244 admin extra 
multipath-tools_0.6.4-5+deb9u1.debian.tar.xz
 d516b9532d5893db82f421b02dac1858 7091 admin extra 
multipath-tools_0.6.4-5+deb9u1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEfRrP+tnggGycTNOSXBPW25MFLgMFAltpbooACgkQXBPW25MF
LgOwUA/7BjYT0gwxoMgZxDWR/HJzDudtL0Hfr9O3nrH4+3Un9S50OCFB8OLEjGD7
HRnZbWL0Tm4us7MVU9TS0latbCCy180eVvI0S42oAkov6kjImur787FtCLu1zSzA
QCLEEOuf/G7wRYk8iBbSnL/6V8gKdpO9y2xg9X6rB/RSF2byW9nqUfe+lWPAeh8g
LU06mUgV8bvcHtzdqN/eOG//SPBcMGAZPlLjU+rxcxyWT0hzKD7xJQ7Z2UAtqCfw
94v7xs6D2+A5aesY0DLkTnBVDiPR6LI8G2iKunkK8FadGtlNxHUA4PdW6yDPfZ4D
Rjy/02mJFnAqwloskScbcoykzfwZ+qW5JsZRduIVyb9Lsc3hn3DGng4sI6xhE6rn
OfNbVGhHWjuNEmsGeebLUa15ueUpxhmKHvabmadkZyr8/hS5PzZCeN3ZX2RhNxS0
KuoAaxvkgEHJ8R4HCt/Us6h7rOQkw9UhzdxdgaW/cn5UFeJEvslYZX534eqLgU0K
OJ2hzsiI25thfLxozQlQDt1b/OufTCsHyd212qFt228hTxRwHNOH4p20BsMkywpc
v4w7HUu97+XWdPs0uARROP2onEfuHexQY7zZ6/17iw1ELACBW3WG5tCZtzui+++e
sCHzutesqzCo6pnzZGhnk5DNIU1CLKIaA9MTtALFr4dtMs5uW9I=
=2wFV
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to