Your message dated Tue, 14 Aug 2018 07:42:00 +0000
with message-id <[email protected]>
and subject line Re: Bug#904703: [Pkg-rust-maintainers] Bug#904703: Bug#904703:
Bug#904703: rustc: Please backport another sparc64 CABI fix
has caused the Debian Bug report #904703,
regarding rustc: Please backport another sparc64 CABI fix
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
904703: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=904703
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: rustc
Version: 1.27.2+dfsg1-1
Severity: normal
Tags: patch
User: [email protected]
Usertags: sparc64
Hello!
Rust upstream just fixed another bug in the sparc64 CABI [1]
which can result in miscompiled code. Since the patch is rather
trivial and affects sparc64 only, it would be good if we could
include it in the next upload.
Attaching the patch from upstream.
Thanks,
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - [email protected]
`. `' Freie Universitaet Berlin - [email protected]
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
>From 051eddd9a9067dcbdccef6bfd86301453bae42ad Mon Sep 17 00:00:00 2001
From: Petr Sumbera <[email protected]>
Date: Thu, 26 Jul 2018 03:58:00 -0700
Subject: [PATCH] sparc ABI issue - structure returning from function is
returned in 64bit registers
Fixes: #52638
---
src/librustc_target/abi/call/sparc64.rs | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/src/librustc_target/abi/call/sparc64.rs
b/src/librustc_target/abi/call/sparc64.rs
index 987f56e6f985..a58aebc2ff06 100644
--- a/src/librustc_target/abi/call/sparc64.rs
+++ b/src/librustc_target/abi/call/sparc64.rs
@@ -57,16 +57,7 @@ fn classify_ret_ty<'a, Ty, C>(cx: C, ret: &mut ArgType<'a,
Ty>)
let size = ret.layout.size;
let bits = size.bits();
if bits <= 256 {
- let unit = if bits <= 8 {
- Reg::i8()
- } else if bits <= 16 {
- Reg::i16()
- } else if bits <= 32 {
- Reg::i32()
- } else {
- Reg::i64()
- };
-
+ let unit = Reg::i64();
ret.cast_to(Uniform {
unit,
total: size
--- End Message ---
--- Begin Message ---
Version: 1.28.0+dfsg1-1
Ok, closing then.
John Paul Adrian Glaubitz:
> On 08/14/2018 05:34 AM, Ximin Luo wrote:
>> John Paul Adrian Glaubitz:
>>> On 07/26/2018 11:51 PM, John Paul Adrian Glaubitz wrote:
>>>> Rust upstream just fixed another bug in the sparc64 CABI [1]
>>>> which can result in miscompiled code. Since the patch is rather
>>>> trivial and affects sparc64 only, it would be good if we could
>>>> include it in the next upload.
>>>
>>> Forgot the reference for [1]:
>>>
>>>> https://github.com/rust-lang/rust/issues/52638
>>>
>>
>> Hi we are already carrying this patch as u-sparc64-cabi.patch, is there
>> another patch you want or is this bug obsolete in favour of #905795?
>
> You were not carrying this patch when I filed this bug report, it
> was not part of 1.27.0. It was added sometime for 1.28.0 in experimental,
> so someone just needs to close the bug report.
>
--
GPG: ed25519/56034877E1F87C35
GPG: rsa4096/1318EFAC5FBBDBCE
https://github.com/infinity0/pubkeys.git
--- End Message ---
