Your message dated Sun, 19 Aug 2018 10:16:50 +0200
with message-id <[email protected]>
and subject line Re: Bug#906617: autopkgtest: Please consider defining 
directory environment variables
has caused the Debian Bug report #906617,
regarding autopkgtest: Please consider defining directory environment variables
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
906617: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=906617
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: autopkgtest
Version: 5.5
Severity: normal

After reading through bug #870654 (requesting a trivial autopkgtest
example) and looking at the example at
https://ci.debian.net/doc/file.TUTORIAL.html, I have gleaned that
commands for autopkgtest are located through the $PATH environment
variable.

If the autopkgtest maintainers would consider defining DESTDIR and the
standard GNU variables for installation directories [see
https://www.gnu.org/prep/standards/html_node/Directory-Variables.html],
then a package built with Autotools ought to be able to perform CI
testing with a debian/tests/control file that only contains the line

     make installcheck

as long as the package has a working "make installcheck" implemented.
By supporting invocation of programs as ${DESTDIR}${bindir}/myprog,
that would also remove any ambiguity as to which file is being
executed during CI testing.  Similarly for package data file
selection, etc.

Therefore, please consider defining DESTDIR, bindir, etc. in the
autopkgtest environment.

I would be glad to take one of my packages that use Autotools and
experiment with the change for you if you make it.

If autopkgtest already does define DESTDIR, bindir, etc., then please
document that on the tutorial page cited above and I will try it with
my next upload of one of my Autotools-based packages.

You might or might not want to merge this bug with #906125, which also
requests environment variable definition, but this report and that are
different.

Thanks,


Paul Hardy

--- End Message ---
--- Begin Message ---
Hello Paul,

Paul Hardy [2018-08-18 14:51 -0700]:
> Package: autopkgtest
> Version: 5.5
> Severity: normal
> 
> After reading through bug #870654 (requesting a trivial autopkgtest
> example) and looking at the example at
> https://ci.debian.net/doc/file.TUTORIAL.html, I have gleaned that
> commands for autopkgtest are located through the $PATH environment
> variable.

This is true for things that autopkgtest calls to prepare the testbed, such as
calling apt and dpkg. It's not true for what tests do -- they can call programs
in whichever way they want.

> If the autopkgtest maintainers would consider defining DESTDIR and the
> standard GNU variables for installation directories [see
> https://www.gnu.org/prep/standards/html_node/Directory-Variables.html],
> then a package built with Autotools ought to be able to perform CI
> testing with a debian/tests/control file that only contains the line
> 
>      make installcheck
> 
> as long as the package has a working "make installcheck" implemented.

Nothing stops you from doing that right now. If you need some additional env
variables, the test can just set them, e. g. call "env FOO=bar make..."

> By supporting invocation of programs as ${DESTDIR}${bindir}/myprog,
> that would also remove any ambiguity as to which file is being
> executed during CI testing.  Similarly for package data file
> selection, etc.
> 
> Therefore, please consider defining DESTDIR, bindir, etc. in the
> autopkgtest environment.

This is totally against autopkgtest's intention - it's meant to test
*installed packages*, not build trees. At the time when autopkgtest normally
runs, you don't generally have a built tree (unless you request one, but having
to build the package is a rather high overhead), but have the built debs
installed. So if a package has a `make installcheck`, then please test the
binaries in /usr, i. e. what you would get with $DESTDIR=/.

Martin

--- End Message ---

Reply via email to