Your message dated Sun, 19 Aug 2018 10:29:30 +0100 with message-id <1534670970.902304.1478890928.21b58...@webmail.messagingengine.com> and subject line Re: Bug#886544: redis-server: Replacing set -e in sysvinit script has caused the Debian Bug report #886544, regarding redis-server: Replacing set -e in sysvinit script to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 886544: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886544 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: redis-server Version: 2:3.2.11-1~dotdeb+8.1 Severity: important Was https://github.com/lamby/pkg-redis/issues/14 Please consider replacing `set -e` with step-by-step error checking in SysVInit scripts. > Be careful of using set -e in init.d scripts https://www.debian.org/doc/debian-policy/#writing-the-scripts > Conforming scripts shall not specify the "exit on error" option (i.e. set -e) > when sourcing this file, > or calling any of the commands thus made available. http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptfunc.html BTW Using `/lib/init/init-d-script` produces a much nicer init script: ```bash #!/bin/sh # kFreeBSD do not accept scripts as interpreters, using #!/bin/sh and sourcing. if [ true != "$INIT_D_SCRIPT_SOURCED" ] ; then set "$0" "$@"; INIT_D_SCRIPT_SOURCED=true . /lib/init/init-d-script fi ### BEGIN INIT INFO # Provides: courier # Required-Start: courier-authdaemon $remote_fs $syslog # Required-Stop: $remote_fs $syslog # Default-Start: 2 3 4 5 # Default-Stop: 0 1 6 # Short-Description: courier service ### END INIT INFO # Author: Ondřej Surý <[email protected]> DAEMON="/usr/sbin/courier" DESC="courier service" PIDFILE="none" DO_START=yes do_start_cmd_override() { DAEMON_ARGS="start $DAEMON_ARGS" do_start_cmd } do_stop_cmd_override() { DAEMON_ARGS="stop $DAEMON_ARGS" do_start_cmd } ``` https://anonscm.debian.org/git/collab-maint/courier.git/tree/debian/courier-mta.courier.init Thank you.
--- End Message ---
--- Begin Message ---> > Gentle ping on this bug? > > Thank you. > > You may close it, as my wish was to have set -e -less Redis init script. (Closing...) Regards, -- ,''`. : :' : Chris Lamb `. `'` [email protected] / chris-lamb.co.uk `-
--- End Message ---
