Your message dated Wed, 22 Aug 2018 14:18:12 +0200
with message-id 
<caj2a_depb5ct3kagskjcunghgmo-nnpjwor38z7j7p763pt...@mail.gmail.com>
and subject line please change the two bash-scripts into POSIX-scripts
has caused the Debian Bug report #256275,
regarding please change the two bash-scripts into POSIX-scripts
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
256275: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=256275
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: logrotate
Version: 3.7-2
Severity: wishlist
Tags: patch

This very minor patch changes the two bash-scripts in logrotate into
POSIX shell-scripts.  This allows for minimal systems without bash
installed.


Regards: David Weinehall


diff -ur logrotate-3.7-old/test/mailer logrotate-3.7/test/mailer
--- logrotate-3.7-old/test/mailer       2003-09-22 22:11:12.000000000 +0300
+++ logrotate-3.7/test/mailer   2004-06-25 20:30:41.000000000 +0300
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 echo "$*" > mail-out
 cat >> mail-out
diff -ur logrotate-3.7-old/test/test logrotate-3.7/test/test
--- logrotate-3.7-old/test/test 2003-09-22 22:11:12.000000000 +0300
+++ logrotate-3.7/test/test     2004-06-25 20:31:03.000000000 +0300
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 LOGROTATE=../logrotate
 M="-m ./mailer"
@@ -7,7 +7,7 @@
 
 cleanup() {
     rm -f test*.log* anothertest*.log* state test-config. scriptout mail-out
-    rm -f $(ls | egrep '^test-config.[0-9]+$')
+    rm -f $(ls | grep -E '^test-config.[0-9]+$')
 
     [ -n "$1" ] && echo "Running test $1"
     return 0
@@ -106,7 +106,7 @@
            echo "file $file does not exist"
        fi
 
-       if [ -n "$co_compressed" -a "$co_compressed" != 0 ]; then
+       if [ -n "$co_compressed" ] && [ "$co_compressed" != 0 ]; then
                contents=`gunzip -c $file`
        else
                contents=`cat $file`


--- End Message ---
--- Begin Message ---
Only test-related files are written in bash and are explicitly marked
with #!/bin/bash.
Also I see no reason to advantage them to posix shell scripts.

--- End Message ---

Reply via email to