Your message dated Tue, 11 Sep 2018 12:00:15 +0000
with message-id <[email protected]>
and subject line Bug#906998: fixed in pushover 0.0.5+git20180909-1
has caused the Debian Bug report #906998,
regarding pushover: build compatibility with -Wl,--as-needed
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
906998: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=906998
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: pushover
Version: 0.0.5+git20180420-2
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu cosmic ubuntu-patch
Dear Gürkan,
The pushover package fails to build in Ubuntu because it supplies options to the
linker in the wrong order:
[...]
g++ -Wall -g -O2 `pkg-config --cflags SDL_image libpng sdl` `pkg-config --libs
SDL_image libpng sdl` -o build_tmp/assembler data/sources/assembler.cpp
[...]
/usr/bin/ld: /tmp/cc4HwHyA.o: in function `SavePNGImage(char*, SDL_Surface*)':
/<<BUILDDIR>>/pushover-0.0.5+git20180420/data/sources/pngsaver.h:44: undefined
reference to `png_create_write_struct'
/usr/bin/ld:
/<<BUILDDIR>>/pushover-0.0.5+git20180420/data/sources/pngsaver.h:54: undefined
reference to `png_create_info_struct'
/usr/bin/ld:
/<<BUILDDIR>>/pushover-0.0.5+git20180420/data/sources/pngsaver.h:63: undefined
reference to `png_set_longjmp_fn'
/usr/bin/ld:
/<<BUILDDIR>>/pushover-0.0.5+git20180420/data/sources/pngsaver.h:72: undefined
reference to `png_init_io'
/usr/bin/ld:
/<<BUILDDIR>>/pushover-0.0.5+git20180420/data/sources/pngsaver.h:73: undefined
reference to `png_set_IHDR'
/usr/bin/ld:
/<<BUILDDIR>>/pushover-0.0.5+git20180420/data/sources/pngsaver.h:95: undefined
reference to `png_write_info'
/usr/bin/ld:
/<<BUILDDIR>>/pushover-0.0.5+git20180420/data/sources/pngsaver.h:112: undefined
reference to `SDL_GetRGBA'
/usr/bin/ld:
/<<BUILDDIR>>/pushover-0.0.5+git20180420/data/sources/pngsaver.h:122: undefined
reference to `png_write_image'
/usr/bin/ld:
/<<BUILDDIR>>/pushover-0.0.5+git20180420/data/sources/pngsaver.h:129: undefined
reference to `png_write_end'
/usr/bin/ld:
/<<BUILDDIR>>/pushover-0.0.5+git20180420/data/sources/pngsaver.h:131: undefined
reference to `png_destroy_write_struct'
/usr/bin/ld:
/<<BUILDDIR>>/pushover-0.0.5+git20180420/data/sources/pngsaver.h:49: undefined
reference to `png_destroy_write_struct'
[...]
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:102: build_tmp/assembler] Error 1
[...]
(https://launchpad.net/ubuntu/+source/pushover/0.0.5+git20180420-2)
Per <https://wiki.ubuntu.com/ToolChain/CompilerFlags#A-Wl.2C--as-needed>,
libraries must be passed on the commandline after the objects which
reference them, otherwise they will be discarded by the linker, resulting in
errors such as the above.
I have uploaded the attached patch to pushover in Ubuntu. Please consider
applying it in Debian as well.
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
[email protected] [email protected]
diff -Nru pushover-0.0.5+git20180420/debian/patches/library-link-order.patch
pushover-0.0.5+git20180420/debian/patches/library-link-order.patch
--- pushover-0.0.5+git20180420/debian/patches/library-link-order.patch
1969-12-31 16:00:00.000000000 -0800
+++ pushover-0.0.5+git20180420/debian/patches/library-link-order.patch
2018-08-22 16:11:57.000000000 -0700
@@ -0,0 +1,27 @@
+Description: Ensure libraries linked are listed after objects using them
+ The Ubuntu toolchain uses -Wl,--as-needed by default, which causes
+ libraries to be dropped from the final binary if they aren't used. For
+ portability, make sure that libraries are always listed on the linker
+ commandline /after/ the objects that reference them.
+Author: Steve Langasek <[email protected]>
+Last-Modified: 2018-08-22
+
+Index: pushover-0.0.5+git20180420/Makefile
+===================================================================
+--- pushover-0.0.5+git20180420.orig/Makefile
++++ pushover-0.0.5+git20180420/Makefile
+@@ -94,12 +94,12 @@
+ $(CXX) $(CXXFLAGS) `$(PKG_CONFIG) --cflags $(PKGS)` $(DEF_VERSION)
$(DEF_DATADIR) -c -o $@ $<
+
+ pushover: $(FILES_O)
+- $(CXX) $(CXXFLAGS) `$(PKG_CONFIG) --libs $(PKGS)` $(LIBS) -o $@
$(FILES_O)
++ $(CXX) $(CXXFLAGS) -o $@ $(FILES_O) `$(PKG_CONFIG) --libs $(PKGS)`
$(LIBS)
+
+ .SECONDARY: build_tmp/assembler
+ build_tmp/assembler: data/sources/assembler.cpp data/sources/pngsaver.h
+ mkdir -p $(dir $@)
+- $(CXX) $(CXXFLAGS) `$(PKG_CONFIG) --cflags $(PKGS_ASSEMBLER)`
`$(PKG_CONFIG) --libs $(PKGS_ASSEMBLER)` -o $@ $<
++ $(CXX) $(CXXFLAGS) `$(PKG_CONFIG) --cflags $(PKGS_ASSEMBLER)` -o $@ $<
`$(PKG_CONFIG) --libs $(PKGS_ASSEMBLER)`
+
+ .SECONDARY: build_tmp/domino_images/done
+ build_tmp/domino_images/done: data/sources/domino.ini data/sources/*.pov
diff -Nru pushover-0.0.5+git20180420/debian/patches/series
pushover-0.0.5+git20180420/debian/patches/series
--- pushover-0.0.5+git20180420/debian/patches/series 2018-04-20
03:23:21.000000000 -0700
+++ pushover-0.0.5+git20180420/debian/patches/series 2018-08-22
16:10:23.000000000 -0700
@@ -5,3 +5,4 @@
sdl2
lua53-justdoit
disable-graphics-during-build
+library-link-order.patch
--- End Message ---
--- Begin Message ---
Source: pushover
Source-Version: 0.0.5+git20180909-1
We believe that the bug you reported is fixed in the latest version of
pushover, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Gürkan Myczko <[email protected]> (supplier of updated pushover package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 09 Sep 2018 13:55:07 +0200
Source: pushover
Binary: pushover pushover-data
Architecture: source all amd64
Version: 0.0.5+git20180909-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <[email protected]>
Changed-By: Gürkan Myczko <[email protected]>
Description:
pushover - Fun puzzle game with dominos
pushover-data - Fun puzzle game with dominos, music files
Closes: 897905 906998
Changes:
pushover (0.0.5+git20180909-1) unstable; urgency=medium
.
* New upstream version. (Closes: #897905, #906998)
* Bump standards version to 4.2.1.
* debian/control: fix typo in long description.
* debian/pushover.desktop: dropped, included upstream.
* Put music into a new package, pushover-data.
Checksums-Sha1:
15322aa54ab2b623300ad94d348ee50991c16088 2093 pushover_0.0.5+git20180909-1.dsc
bf47da083440924331278b19c576b6beffd9add9 36132080
pushover_0.0.5+git20180909.orig.tar.gz
d3a76d07eccca09e12bcca9aed6ff79e87cb1914 539884
pushover_0.0.5+git20180909-1.debian.tar.xz
0711c2d083d99387ebd64da447f300c392413652 32364884
pushover-data_0.0.5+git20180909-1_all.deb
06b105259f1a7656ae7603e16bf2609d5f9c23f6 2700884
pushover-dbgsym_0.0.5+git20180909-1_amd64.deb
a53e1ceb3c4036055ebf107eb353147f68ea912d 12044
pushover_0.0.5+git20180909-1_amd64.buildinfo
f0ef6de27d7b8694cf107d99ddc27c32c39dcec5 3537100
pushover_0.0.5+git20180909-1_amd64.deb
Checksums-Sha256:
62f162408beb5594ab185ffbedee72026e0bb506ad2fd3a3ac845e7c3c8d614a 2093
pushover_0.0.5+git20180909-1.dsc
6f318c19ea5a6be01fc2a4b1a8e74b1dd99cd7ef9828ecb3973e097ab3be7b24 36132080
pushover_0.0.5+git20180909.orig.tar.gz
d9e9e785151ae4c7cf86958f70aec75bc760820ee728b194f303a87015aa34bf 539884
pushover_0.0.5+git20180909-1.debian.tar.xz
6dc9ca9c35b211648ff0e714fa5745851a9c5ef1fb982b935c21f76ba39c15ae 32364884
pushover-data_0.0.5+git20180909-1_all.deb
4aea42f99569ed173ab16c9f2ef1cf1a34e3be6ea6ea71599b96087c3f1f5339 2700884
pushover-dbgsym_0.0.5+git20180909-1_amd64.deb
6756171e2697f4f7f5d264da4e2a9bd2c034f83c01afaf67d9f29e23fb770ecb 12044
pushover_0.0.5+git20180909-1_amd64.buildinfo
87edb0af6ceb1eb834530a9505cc273d66394ea038c48077145137a914462028 3537100
pushover_0.0.5+git20180909-1_amd64.deb
Files:
3db22e61df3d3ea80d6dcc367f2063cd 2093 games optional
pushover_0.0.5+git20180909-1.dsc
022531341daad2517a1e4f3fc1d69738 36132080 games optional
pushover_0.0.5+git20180909.orig.tar.gz
a790d0a0984ff3b2b81528aa7c25ee40 539884 games optional
pushover_0.0.5+git20180909-1.debian.tar.xz
e2be16f55854bc9973b55551abc0c0f0 32364884 games optional
pushover-data_0.0.5+git20180909-1_all.deb
429c6d901def971ccc38dfecbaa487cf 2700884 debug optional
pushover-dbgsym_0.0.5+git20180909-1_amd64.deb
0225e33702917ff7412638a3c279b203 12044 games optional
pushover_0.0.5+git20180909-1_amd64.buildinfo
4442b294e37f5a6b6bebb9687016e7c2 3537100 games optional
pushover_0.0.5+git20180909-1_amd64.deb
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEkjZVexcMh/iCHArDweDZLphvfH4FAluVQWQACgkQweDZLphv
fH7DSxAAhrkQeK3hPSlkLqYBawyKbArEhec8gkM1pEyTNyi/A6RbOPpV5nBBMR+W
2XnPmB0PszdfOW4Gfu+OLUrTlQSwclbA3cJfnbwve7kd+QT1V573K6pYagvEMx47
MG3QQPoSLnMNQilgyfDc5RSwv6QkWkBjOZkCIf0veW9aD7Eqw8tTL6WbzgNvn+h9
/zSMikWJyT3js8dRdTm1NsFEvhc4Ru8U8rr+iGPNSDTfhjlnXdzWD4DVaQ6i0zzM
I0x7ea7u5o+Xmo6IzECjyoYOnfD0LKHnGMXD20biTdfKf/P3fUy6PeQKSm+f1JT3
mI7dSYn5q69zSXqEwrCqnx2QNKhzsYLBuwOwZaZkE3+HB5MprW+ASWZq1BZtiUqO
mJT8stG3OUMrG3RI2WDZipxaVFP7QvIL68G5fMrKEAtW8HohFIHED6Z1OG2ncM7n
uGILdXi46Qmz325kDsgXFCYW+1bV/Z4OiUtuecZ3OiwfAt3kFLPO8yIukhRYZ3rl
gUOUQi0ObrnPjdqGqI32mejK1BdfWwq17wl+eBSQVjCflRmzGVBkPXG2nf7V5z3B
cRLYDMz9EP8Ks+WhYsmbXfxvhHgivyB8ZiY9dqka3cCFrRV79h/veJam6H689w4v
bPgHsbaz2AerkPhmwaavsr6TRwpKKrMjpIsjeo155Ymyr4Kkwa4=
=KYjD
-----END PGP SIGNATURE-----
--- End Message ---
