Your message dated Wed, 12 Sep 2018 22:09:20 +0000
with message-id <[email protected]>
and subject line Bug#908646: fixed in llvm-toolchain-7 1:7~+rc3-2
has caused the Debian Bug report #908646,
regarding llvm-toolchain-7: Inverted logic for POLLY_ENABLE and OPENMP_ENABLE
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
908646: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=908646
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: llvm-toolchain-7
Version: 1:7~+rc3-1
Severity: normal
Hello!
The logic used for toggling polly and openmp in the debian/rules
file is inverted. It's currently using the Makefile "filter-out"
function which I actually never noticed before:
ifeq (,$(filter-out $(DEB_HOST_ARCH), powerpc powerpcspe s390x))
POLLY_ENABLE=no
endif
From the GNU Make documentation [1].
"$(filter-out pattern…,text)"
"Returns all whitespace-separated words in text that do not match any
of the pattern words, removing the words that do match one or more.
This is the exact opposite of the filter function."
This means, that in our case above, "filter-out" will just remove
any strings matching "DEB_HOST_ARCH" in "powerpc powerpcpe s390x"
and then compare the resulting string with an empty string. So,
for example, if "DEB_HOST_ARCH" is "powerpc", the right string
will be reduced to "powerpcspe s390x" and then compared with
an empty string which will fail.
Thus, the ifeq-clause will never be true and POLLY_ENABLE will
never be disabled for the affected architectures. The same
applies to what is used for OPENMP_ENABLE.
If I replace "ifeq" with "ifneq" and "filter-out" with "filter",
the code works as intended and llvm-toolchain-6.0 builds fine for
on powerpc except that the dh_install step fails because of missing
cmake files:
dh_install --fail-missing
dh_install: Please use dh_missing --list-missing/--fail-missing instead
dh_install: This feature will be removed in compat 12.
dh_install: Cannot find (any matches for)
"usr/lib/llvm-6.0/lib/cmake/polly/*.cmake" (tried in ., debian/tmp)
dh_install: libclang-common-6.0-dev missing files:
usr/lib/llvm-6.0/lib/cmake/polly/*.cmake
dh_install: missing files, aborting
make[1]: *** [debian/rules:520: override_dh_install] Error 25
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:180: binary-arch] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary-arch subprocess returned
exit status 2
However, we would just have to adjust the corresponding install.in file
here to fix this issue. The behavior is the same with s390x.
I suggest the following patch for llvm-toolchain-7:
--- debian/rules.orig 2018-09-07 14:37:18.000000000 +0200
+++ debian/rules 2018-09-11 11:30:33.166678712 +0200
@@ -107,13 +107,13 @@
# Enable polly (or not)
POLLY_ENABLE=yes
-ifeq (,$(filter-out $(DEB_HOST_ARCH), powerpc powerpcspe s390x))
+ifneq (,$(filter $(DEB_HOST_ARCH), powerpc powerpcspe s390x))
POLLY_ENABLE=no
endif
# Enable openmp (or not)
OPENMP_ENABLE=yes
-ifeq (,$(filter-out $(DEB_HOST_ARCH), powerpc powerpcspe riscv64 sparc64
s390x))
+ifneq (,$(filter $(DEB_HOST_ARCH), powerpc powerpcspe riscv64 sparc64 s390x))
OPENMP_ENABLE=no
endif
And the same patch for llvm-toolchain-6.0 with the openmp
hunk removed.
Plus, something figured out for install.in. Probably some sed
magic in debian/rules.
Adrian
> [1] https://www.gnu.org/software/make/manual/html_node/Text-Functions.html
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - [email protected]
`. `' Freie Universitaet Berlin - [email protected]
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
--- End Message ---
--- Begin Message ---
Source: llvm-toolchain-7
Source-Version: 1:7~+rc3-2
We believe that the bug you reported is fixed in the latest version of
llvm-toolchain-7, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Gianfranco Costamagna <[email protected]> (supplier of updated
llvm-toolchain-7 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 12 Sep 2018 10:58:12 +0200
Source: llvm-toolchain-7
Binary: clang-7 clang-tools-7 clang-format-7 clang-tidy-7 clang-7-doc
libclang1-7 libclang-7-dev libclang-common-7-dev libfuzzer-7-dev python-clang-7
clang-7-examples libllvm7 llvm-7 llvm-7-runtime llvm-7-dev llvm-7-tools
llvm-7-doc llvm-7-examples lld-7 liblld-7 liblld-7-dev lldb-7 liblldb-7
python-lldb-7 liblldb-7-dev libomp-7-dev libomp5-7 libomp-7-doc libc++1-7
libc++-7-dev libc++abi1-7 libc++abi-7-dev
Architecture: source
Version: 1:7~+rc3-2
Distribution: unstable
Urgency: medium
Maintainer: LLVM Packaging Team <[email protected]>
Changed-By: Gianfranco Costamagna <[email protected]>
Description:
clang-7 - C, C++ and Objective-C compiler
clang-7-doc - C, C++ and Objective-C compiler - Documentation
clang-7-examples - Clang examples
clang-format-7 - Tool to format C/C++/Obj-C code
clang-tidy-7 - clang-based C++ linter tool
clang-tools-7 - clang-based tools for C/C++ developments
libc++-7-dev - LLVM C++ Standard library (development files)
libc++1-7 - LLVM C++ Standard library
libc++abi-7-dev - LLVM low level support for a standard C++ library
(development fi
libc++abi1-7 - LLVM low level support for a standard C++ library
libclang-7-dev - clang library - Development package
libclang-common-7-dev - clang library - Common development package
libclang1-7 - C interface to the clang library
libfuzzer-7-dev - Library for coverage-guided fuzz testing
liblld-7 - LLVM-based linker, library
liblld-7-dev - LLVM-based linker, header files
liblldb-7 - Next generation, high-performance debugger, library
liblldb-7-dev - Next generation, high-performance debugger, header files
libllvm7 - Modular compiler and toolchain technologies, runtime library
libomp-7-dev - LLVM OpenMP runtime - dev package
libomp-7-doc - LLVM OpenMP runtime - Documentation
libomp5-7 - LLVM OpenMP runtime
lld-7 - LLVM-based linker
lldb-7 - Next generation, high-performance debugger
llvm-7 - Modular compiler and toolchain technologies
llvm-7-dev - Modular compiler and toolchain technologies, libraries and header
llvm-7-doc - Modular compiler and toolchain technologies, documentation
llvm-7-examples - Modular compiler and toolchain technologies, examples
llvm-7-runtime - Modular compiler and toolchain technologies, IR interpreter
llvm-7-tools - Modular compiler and toolchain technologies, tools
python-clang-7 - Clang Python Bindings
python-lldb-7 - Next generation, high-performance debugger, python lib
Closes: 902847 908646
Changes:
llvm-toolchain-7 (1:7~+rc3-2) unstable; urgency=medium
.
[ John Paul Adrian Glaubitz ]
* Fix inverted logic in ifeq statement for POLLY_ENABLE
and OPENMP_ENABLE (Closes: #908646)
.
[ Gianfranco Costamagna ]
* Drop gnustep and gnustep-devel suggestions (Closes: #902847)
* Enable polly on s390x
* Disable omp on armel mips and mipsel for now
Checksums-Sha1:
6eea216efc4c2570e890149bfdb7b2b650ce3a15 7921 llvm-toolchain-7_7~+rc3-2.dsc
642d37e3374da5b9def4cda56ca3bc59290b9a57 73008
llvm-toolchain-7_7~+rc3-2.debian.tar.xz
b2dfd9f707feddfe52957d70fa44fdfbae21a028 22927
llvm-toolchain-7_7~+rc3-2_amd64.buildinfo
Checksums-Sha256:
e10f4a9612a5812b890260c00ee767ed07b7ca57f9e476dda0b182f5fc7a2cdd 7921
llvm-toolchain-7_7~+rc3-2.dsc
61143bddb7e911f9d2dae622314f2fb8fb3ef06c88a9446c5ea4440173605d69 73008
llvm-toolchain-7_7~+rc3-2.debian.tar.xz
c53a0516cd411d4549e289e44c1937b1f7e1c040fbcd7ae92987a3e41909b6fe 22927
llvm-toolchain-7_7~+rc3-2_amd64.buildinfo
Files:
e5e37f5d2c1849f25a13b078b56d1b01 7921 devel optional
llvm-toolchain-7_7~+rc3-2.dsc
64a8c76e6ac193af44c63d315f5cb09b 73008 devel optional
llvm-toolchain-7_7~+rc3-2.debian.tar.xz
e2577369ad8e2e5e0ec5692d24e24935 22927 devel optional
llvm-toolchain-7_7~+rc3-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEtg21mU05vsTRqVzPfmUo2nUvG+EFAluZimcACgkQfmUo2nUv
G+Fe2w//Qc0bi3R5RJ+I3P8Ebqs5W4OYtX4mpoJWuUkxuXX7Chts7Qo0o0cwIp3p
VBoarh8xyFtz07e38YWcXAJOrZIetrxXKyI3CShYP2Yio92qMLUc40NxDFaYx0yr
DTFty3TkY3MlDELvMzjAx5j9IF7VTQ/9fzsyFiKLGWGOPlWNgKXfNGwF+9c/xw3c
UflI+nwOoxisb1ftLrwOvmKegPiverNFgC90FgdWxJ/DgeqEISpOYuSpRQztrGsf
M2aCVeIVHKzAZR1rMWDl9TBQElKoCU5ZagQ8OmOhIMkle14ZnxXHQBIrdlsEkIcy
dyqA61i59FPbb34cJ/Xo8EvATnyLEg3O5Gv4J2QLFqmlwOFLf4/Lmfs8mWYbj6UU
ZcnbMA5prZtetB1IxTjKRsUTN32KQw56iXZ2A0Me9JsCyoxj23XvnqYsPsmhZKbI
VXU0/dZHwKYhIX1/f3ImUFe47WeHRDgEwF/qtR+kKBTxtpOBwd+h+TsBr+oRSnHR
odZemaRGS6pdBWVslNQ/AN8KF/CNl3KbXSzZnzF36zXVsYQFPZaoVjg2FJ67YcmL
t9vViARIdIMh1Zq8H6m2Na7rP7WW0idPGo1YkKQ7kwDZ+n16UyXFhASTGfQkeD0x
XK59Mnn+xu3PL1hZeryzgS4uEugTK0VLQZxWZtef8xJnFZHvQAo=
=3ECg
-----END PGP SIGNATURE-----
--- End Message ---
