Your message dated Sun, 21 Oct 2018 11:05:14 +0000
with message-id <[email protected]>
and subject line Bug#851266: fixed in hidapi-cffi 0.2.2-1
has caused the Debian Bug report #851266,
regarding hidapi-cffi: simplify debian/rules
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
851266: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=851266
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: src:hidapi-cffi
Version: 0.2.1-1
Severity: serious
Tags: patch
Justification: Policy 7.2

Upstream only declares

> setup_requires=['cffi >= 0.8']

But that's insufficient, it actually requires cffi at runtime, the first
line is:

> from cffi import FFI

It's worth noting that in Debian we split the cffi package from the
cffi-backend package. We assume that cffi packages are using the
out-of-line modes, and they only need the cffi-backend. So, when a
package declares cffi in install_requires, we generate a dependency on
the cffi-backend package.

But this package is using the in-line ABI mode (see [0] for an
explanation of the modes). So it will need an explicit dependency on
cffi, even if upstream fixes setup.py

[0]: https://cffi.readthedocs.io/en/latest/overview.html

Patch attached: dependencies.patch
Also, I noticed a bunch of things in debian/rules that pybulid can do
for you, so there's a second patch: pybulid.patch.

SR
diff -Nru hidapi-cffi-0.2.1/debian/control hidapi-cffi-0.2.1/debian/control
--- hidapi-cffi-0.2.1/debian/control	2015-06-25 13:35:38.000000000 -0700
+++ hidapi-cffi-0.2.1/debian/control	2016-09-06 22:04:59.000000000 -0700
@@ -7,14 +7,14 @@
 
 Package: python-hidapi
 Architecture: any
-Depends: ${misc:Depends}, ${python:Depends}, libhidapi-hidraw0 | libhidapi-libusb0
+Depends: ${misc:Depends}, ${python:Depends}, libhidapi-hidraw0 | libhidapi-libusb0, python-cffi (>= 0.8)
 Description: Python bindings for the HID API
  Python bindings for libhidapi for working with Human Interface Devices
  such as mouses and keyboards.
 
 Package: python3-hidapi
 Architecture: any
-Depends: ${misc:Depends}, ${python3:Depends}, libhidapi-hidraw0 | libhidapi-libusb0
+Depends: ${misc:Depends}, ${python3:Depends}, libhidapi-hidraw0 | libhidapi-libusb0, python3-cffi (>= 0.8)
 Description: Python bindings for the HID API
  Python bindings for libhidapi for working with Human Interface Devices
  such as mouses and keyboards.
diff -Nru hidapi-cffi-0.2.1/debian/clean hidapi-cffi-0.2.1/debian/clean
--- hidapi-cffi-0.2.1/debian/clean	1969-12-31 16:00:00.000000000 -0800
+++ hidapi-cffi-0.2.1/debian/clean	2016-09-06 22:04:59.000000000 -0700
@@ -0,0 +1 @@
+hidapi_cffi.egg-info/*
diff -Nru hidapi-cffi-0.2.1/debian/rules hidapi-cffi-0.2.1/debian/rules
--- hidapi-cffi-0.2.1/debian/rules	2015-06-25 13:08:50.000000000 -0700
+++ hidapi-cffi-0.2.1/debian/rules	2016-09-06 22:04:59.000000000 -0700
@@ -1,26 +1,6 @@
 #!/usr/bin/make -f
 
-# This file was automatically generated by stdeb 0.8.2 at
-# Thu, 09 Oct 2014 22:55:33 +0300
-PYTHONS:=$(shell pyversions -vr)
-PYTHON3S:=$(shell py3versions -vr)
 export PYBUILD_NAME=hidapi
+
 %:
 	dh $@ --with python2,python3 --buildsystem=pybuild
-
-override_dh_clean:
-	dh_clean -O--buildsystem=pybuild
-	rm -rf build
-	rm -rf __pycache__
-
-override_dh_install:
-	set -e ; for pyvers in $(PYTHONS); do \
-		python$$pyvers setup.py install --install-layout=deb \
-			--root $(CURDIR)/debian/python-hidapi; \
-	done
-	set -e ; for pyvers in $(PYTHON3S); do \
-		python$$pyvers setup.py install --install-layout=deb \
-			--root $(CURDIR)/debian/python3-hidapi; \
-	done
-	rm -rf $(CURDIR)/debian/python*-hidapi/usr/lib/python*/dist-packages/*.pth
-	rm -rf $(CURDIR)/debian/python*-hidapi/usr/lib/python3.*

--- End Message ---
--- Begin Message ---
Source: hidapi-cffi
Source-Version: 0.2.2-1

We believe that the bug you reported is fixed in the latest version of
hidapi-cffi, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Aigars Mahinovs <[email protected]> (supplier of updated hidapi-cffi package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 21 Oct 2018 12:47:21 +0300
Source: hidapi-cffi
Binary: python-hidapi python3-hidapi
Architecture: source amd64
Version: 0.2.2-1
Distribution: unstable
Urgency: low
Maintainer: Aigars Mahinovs <[email protected]>
Changed-By: Aigars Mahinovs <[email protected]>
Description:
 python-hidapi - Python bindings for the HID API
 python3-hidapi - Python bindings for the HID API
Closes: 851266 910993
Changes:
 hidapi-cffi (0.2.2-1) unstable; urgency=low
 .
   * New upstream release and add watch file (Closes: #910993)
   * Simplify debian/rules (Closes: #851266)
   * Updated standarts version
Checksums-Sha1:
 510c38b3950a993e11751dffc1feeb452a3fbc13 1948 hidapi-cffi_0.2.2-1.dsc
 a80d05e9869f0584a3046d5e58519046006d7c3c 3921 hidapi-cffi_0.2.2.orig.tar.gz
 0db6df342d1457404bd7253c3804f252b2d3bcb6 2116 hidapi-cffi_0.2.2-1.debian.tar.xz
 58c01c4a2dfe8a3bed65d2492575723fbbe73619 8675 
hidapi-cffi_0.2.2-1_amd64.buildinfo
 60860ad499717d261ae9d7d7be03f275d0c22184 6164 python-hidapi_0.2.2-1_amd64.deb
 89ae7c52360ccc8779c98a93adf8bd72dc861a98 6248 python3-hidapi_0.2.2-1_amd64.deb
Checksums-Sha256:
 c08ef6901f0c8f25687e50713eb65f5cbbc4328fca58b5b97b7a337e101b1075 1948 
hidapi-cffi_0.2.2-1.dsc
 a0fade6fbbeb8c4d1e8cbcaa9fc8b7f8dff6df2450e634417084441b97f54403 3921 
hidapi-cffi_0.2.2.orig.tar.gz
 298cdf3d53c375b2797c97a4a0e4c5b292c4170d95faefd7f8a21616251dd8ff 2116 
hidapi-cffi_0.2.2-1.debian.tar.xz
 7a4bfa1209cf4ecda169baeafbcfbaa111aa2030a6675bc0f752f3056cee9e88 8675 
hidapi-cffi_0.2.2-1_amd64.buildinfo
 04bace637e04cb608f1d52790b8019366def813962ffb37c5f806ff7c35c47a7 6164 
python-hidapi_0.2.2-1_amd64.deb
 55dc22ffdf69ab5571008becf4e9d241414eb92c46cc56e2e04634c5bd0573d5 6248 
python3-hidapi_0.2.2-1_amd64.deb
Files:
 5cd5cfafddfc1ada36e32b77d7eb4ed1 1948 python optional hidapi-cffi_0.2.2-1.dsc
 dccebe266914f2f78f3ad9162124120f 3921 python optional 
hidapi-cffi_0.2.2.orig.tar.gz
 2cd861c59a44f88f781352252fd3710b 2116 python optional 
hidapi-cffi_0.2.2-1.debian.tar.xz
 eb9b1c1591ac7830ed2903675aa4599e 8675 python optional 
hidapi-cffi_0.2.2-1_amd64.buildinfo
 fb5c7e85dd0444f84f18523094ae4e73 6164 python optional 
python-hidapi_0.2.2-1_amd64.deb
 769ba00dd674525bc9aca0fbc0491ec0 6248 python optional 
python3-hidapi_0.2.2-1_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQJIBAEBCAAyFiEEFmwrqIlWRDzdY39G+mQ7ph0ievsFAlvMWWoUHGFpZ2FyaXVz
QGRlYmlhbi5vcmcACgkQ+mQ7ph0ievuB1g//SkwN6ZtJiVBQ7FK9iDyKbUq5ENMj
/oYis09PmCB3sCs1IC+5rtN9RyUGxnRoskR1+qGdfdpblZS4TShYRm+ajRDSBGah
nPzAiZIjBQ/BlUMZmjPStYu+oA/A1zLrqeta2x2NLKWqA2e8lklnY85vtrzM9Wtv
Xi7tV7ChfEf+uRUPqpvwZyHqDwC3wNpFGA+HpJsRBO6UmwOzIdbARf7mgN4AXblM
WvgJYZ6Tyf6aNv22YWMh/wTh6X2nJ3ekyt23VC6BXlkrtT30850IEPKsEtjIf9az
gsixl7GgletKZzpZqrdAG7TUiMh1B7JVhU5CdlN4kxDk5UbPADeM/qprvod7YGY9
aCzWNBvjGnmcu16u9CHEsMng3EBrDtyMqLTM/XM50g2+3SlUY4WEmGAPtRR6ztuv
t8a28s4zyRyO8TAvNyIzadE5LUjltkrbPz1Vj7Jf26qbo7CxsDha6Av06xno+/wE
ZGDX2s+kJOGgvk8rn4codGROb4saCW8WvbulDm+UTAyaPAPrrqP0/i6BlGZMkMgR
qRkcoqvgnB2h6akjc3ObaW5xkiJjkY3Dy4n7Y3y6fBLG3xN6Vv8tiFx6aBTMQk5b
zWTBKw+RC0YVu7f8mUSqecrkietKFGO+HsyLDFzbZW/w/gf5U7Nzw75dQat2WjI4
WcbKtNstDamwg+w=
=J51K
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to