Your message dated Mon, 22 Oct 2018 10:51:55 +0000
with message-id <[email protected]>
and subject line Bug#911273: fixed in parted 3.2-23
has caused the Debian Bug report #911273,
regarding d-i does not display NVMe model strings
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
911273: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911273
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: parted
Version: 3.2-22
Severity: normal
Tags: patch, d-i
parted currently exposes the same generic model name for all NVMe devices:
# parted /dev/nvme0n1 -s print | grep Model
Model: NVMe Device (nvme)
That can make it difficult to distinguish devices in your system,
especially at install-time.
This is fixed upstream in the following commit, which applies to Debian's
package with only minor offset adjustments:
279bd554 Read NVMe model names from sysfs
-- System Information:
Debian Release: buster/sid
APT prefers unstable-debug
APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1,
'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.19.0-rc3-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages parted depends on:
ii libc6 2.27-6
ii libparted2 3.2-22
ii libreadline7 7.0-5
ii libtinfo6 6.1+20180714-1
parted recommends no packages.
Versions of packages parted suggests:
pn parted-doc <none>
-- no debconf information
>From 279bd5540a59e3bdc4e3702ff062f87fd842c0e9 Mon Sep 17 00:00:00 2001
From: dann frazier <[email protected]>
Date: Fri, 7 Sep 2018 13:31:15 -0600
Subject: [PATCH] Read NVMe model names from sysfs
parted currently shows the same generic model name for all NVMe devices:
# parted /dev/nvme0n1 -s print | grep Model
Model: NVMe Device (nvme)
If the model information is available in sysfs, display that instead:
# parted /dev/nvme0n1 -s print | grep Model
Model: THNSN5512GPU7 NVMe TOSHIBA 512GB (nvme)
Signed-off-by: Brian C. Lane <[email protected]>
---
libparted/arch/linux.c | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/libparted/arch/linux.c b/libparted/arch/linux.c
index 02d7a52c..7d83dfbb 100644
--- a/libparted/arch/linux.c
+++ b/libparted/arch/linux.c
@@ -1405,6 +1405,22 @@ init_sdmmc (PedDevice* dev)
return init_generic(dev, id);
}
+static int
+init_nvme (PedDevice* dev)
+{
+ int ret;
+ char *model = read_device_sysfs_file (dev, "model");
+
+ if (!model)
+ ret = init_generic (dev, _("NVMe Device"));
+ else {
+ ret = init_generic (dev, model);
+ free (model);
+ }
+
+ return ret;
+}
+
static PedDevice*
linux_new (const char* path)
{
@@ -1489,7 +1505,7 @@ linux_new (const char* path)
break;
case PED_DEVICE_NVME:
- if (!init_generic (dev, _("NVMe Device")))
+ if (!init_nvme (dev))
goto error_free_arch_specific;
break;
--
2.19.1
--- End Message ---
--- Begin Message ---
Source: parted
Source-Version: 3.2-23
We believe that the bug you reported is fixed in the latest version of
parted, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Colin Watson <[email protected]> (supplier of updated parted package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Mon, 22 Oct 2018 11:28:00 +0100
Source: parted
Binary: parted parted-udeb libparted2 libparted-fs-resize0 libparted2-udeb
libparted-fs-resize0-udeb libparted-i18n libparted-dev parted-doc
Architecture: source
Version: 3.2-23
Distribution: unstable
Urgency: medium
Maintainer: Parted Maintainer Team <[email protected]>
Changed-By: Colin Watson <[email protected]>
Description:
libparted-dev - disk partition manipulator - development files
libparted-fs-resize0 - disk partition manipulator - shared FS resizing library
libparted-fs-resize0-udeb - disk partition manipulator - FS resizing library
udeb (udeb)
libparted-i18n - disk partition manipulator - i18n support
libparted2 - disk partition manipulator - shared library
libparted2-udeb - disk partition manipulator - library udeb (udeb)
parted - disk partition manipulator
parted-doc - disk partition manipulator - documentation
parted-udeb - Manually partition a hard drive (parted) (udeb)
Closes: 911273
Changes:
parted (3.2-23) unstable; urgency=medium
.
* Cherry-pick upstream patch to read NVMe model names from sysfs (closes:
#911273).
Checksums-Sha1:
9950852d11d6c7652fbb9bd2cc6063cdec2c6962 2780 parted_3.2-23.dsc
ab8c3cc13953d4b5c84d5f85ef66c1a593fe8ef1 88152 parted_3.2-23.debian.tar.xz
edb54870867222275be9feda2d3ba132efb68f6c 5799 parted_3.2-23_source.buildinfo
Checksums-Sha256:
a4625742f101199ad40f09ba4aadd04717b460586a17372fc861da9d9b01e835 2780
parted_3.2-23.dsc
ecc2106cc54caa075669370d0deea9fe92d644781bc8cb58aae5b41a60f05acd 88152
parted_3.2-23.debian.tar.xz
022c1c02a404fb69e7d4ed36b4b1d1da3d3cb0cabe6978a1c84ecd7a51b4c63a 5799
parted_3.2-23_source.buildinfo
Files:
9841e7bbbeb04fcbd4d3e6881d11488f 2780 admin optional parted_3.2-23.dsc
45b02128d8d4e2894c487d417d555e54 88152 admin optional
parted_3.2-23.debian.tar.xz
2f5b0edf3ed1ce5fe9adab81bfa26d0c 5799 admin optional
parted_3.2-23_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEErApP8SYRtvzPAcEROTWH2X2GUAsFAlvNpkwACgkQOTWH2X2G
UAvtaQ/9Hf6Czkzs90pNXgBeeJd8lB9SKVYF0c7uHEzYZQm9KkvhFzw3uxf/FIb7
rYSxB5Z0VfbDMsozqA7fsAlU9Qpv6Ym8KqSygGVykyiVAP4dnpPmm15xHxq9ewOh
cOTybbsqrIiAwoNwYEVhQMApGHY6AMdPGACFhDrZjYJvUaBOq23OHe1ZjXNF7XHL
PMfwa/3y3vn3/VQQsqeP7sZhLzOYL/NOqFFmG+lDrCjW+XUuG0aTRqr97XH9AqzR
c720GtPT8ancWuAXHw7co4rreyQY13kuKVGS/00Q+UkOkDpZecz4QH+k5SDKUSxQ
wlNlovy7cKHYgIxEeE3cK6s/XOB5p/Q+52zv59jG1gWUAgqMhsX0Rm4SzRAC0Kr2
IDT1EpI1XmrbcOI9Xbc9dqq5natGpt5UsFZ1Ujm2LV4ztMaYNvGrb5o3JUkFnvod
yS8t4jQ8oNKbM0bafKLBcSir4bP0Pc5sC+jahOOFCw7MBHULBqyobPDzK3mYbs5o
NyOJIEKkBhCRoS5YiVIgDCrKeEqVCq68DCBSEO4ZPinGU+MEoSNlRbsT8xLrZJqu
McLUPifYHaEUrRl4DUE3H4i8Ri6u0BEezsa9jB6Xvw1yJDStKrPevbNzPQOx7+71
kMapKrClYmJYLXQY60v+VVnR+3Pex49OqdXROXf8v+Xhmy1H1OI=
=tU1O
-----END PGP SIGNATURE-----
--- End Message ---
