Your message dated Fri, 30 Nov 2018 11:04:06 +0000
with message-id <[email protected]>
and subject line Bug#914311: fixed in ccextractor 0.87+ds1-1
has caused the Debian Bug report #914311,
regarding To enable OCR & hard subtitle extraction or not to enable, that is 
the question
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
914311: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=914311
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: ccextractor
Version: 0.86+ds1-2
Severity: wishlist
Tags: patch

If ccextractor is to have OCR and hard subtitle extraction support,
then configure the build as needed, otherwise drop the extraneous
build dependencies and simplify the Debian build process (ie drop
dh_auto_build override).  Patches are attached to implement either
option.

In backporting ccextractor to Ubuntu 16.04/"Xenial" and
18.04/"Bionic", I noticed that though there are build dependencies on
FFmpeg, Tesseract, and Leptonica, there are no corresponding binary
package dependencies, which means they are either not linked or are
statically linked.  Reviewing the build logs it can be seen that
ccextractor is not linked with those libraries.

Tesseract and Leptonica are used for OCR support and they and FFmpeg
are used for hard subtitle extraction support.  Both features can be
enabled with:

configure --enable-ocr --enable-hardsubx

(It could be argued that "--enable-ocr" is unnecessary/redundant as
"--enable-hardsubx" sets both "HARDSUBX_IS_ENABLED" and
"OCR_IS_ENABLED" in the build process.)

I know that the documentation (ie docs/FFMPEG.TXT, docs/HARDSUBX.txt,
and docs/OCR.txt) is misleading in saying that "make ENABLE_XXX=yes"
enables support for a feature, and that might be why debian/rules has
the dh_auto_build override referencing "ENABLE_FFMPEG=yes
ENABLE_OCR=yes", but that is wrong (though OCR.md is fixed in upstream
Git commit e0b909a6).

For the details see configure.ac and Makefile.am, specifically
references to *_IS_ENABLED (or the lack thereof, ie FFMPEG_IS_ENABLED
doesn't appear in Makefile.am).

Corey
--
[email protected]
diff -urpd ccextractor-0.86+ds1~/debian/control ccextractor-0.86+ds1/debian/control
--- ccextractor-0.86+ds1~/debian/control	2018-11-22 00:39:12.643066392 +0000
+++ ccextractor-0.86+ds1/debian/control	2018-11-22 00:41:54.288813546 +0000
@@ -3,10 +3,8 @@ Section: utils
 Priority: optional
 Maintainer: Freexian Packaging Team <[email protected]>
 Uploaders: Sophie Brun <[email protected]>, Raphaël Hertzog <[email protected]>
-Build-Depends: debhelper (>= 11), libpng-dev, libavcodec-dev,
- libavformat-dev, libavutil-dev, libavfilter-dev, libleptonica-dev (>= 1.73~),
- libtesseract-dev (>= 4.00~), libutf8proc-dev, libcurl4-gnutls-dev, pkg-config,
- libfreetype6-dev
+Build-Depends: debhelper (>= 11), libpng-dev, libutf8proc-dev,
+ libcurl4-gnutls-dev, pkg-config, libfreetype6-dev
 Standards-Version: 4.2.1
 Homepage: https://www.ccextractor.org/
 Vcs-Git: https://salsa.debian.org/freexian-team/ccextractor.git
diff -urpd ccextractor-0.86+ds1~/debian/rules ccextractor-0.86+ds1/debian/rules
--- ccextractor-0.86+ds1~/debian/rules	2018-11-21 18:29:13.000000000 +0000
+++ ccextractor-0.86+ds1/debian/rules	2018-11-22 00:35:11.630423146 +0000
@@ -5,9 +5,6 @@ export DEB_BUILD_MAINT_OPTIONS = hardeni
 %:
 	dh $@ --with autoreconf --sourcedirectory=linux
 
-override_dh_auto_build:
-	dh_auto_build -- ENABLE_FFMPEG=yes ENABLE_OCR=yes
-
 override_dh_installchangelogs:
 	dh_installchangelogs docs/CHANGES.TXT
 
--- ccextractor-0.86+ds1~/debian/rules	2018-11-21 18:29:13.000000000 +0000
+++ ccextractor-0.86+ds1/debian/rules	2018-11-22 00:08:56.752344385 +0000
@@ -5,8 +5,8 @@ export DEB_BUILD_MAINT_OPTIONS = hardeni
 %:
 	dh $@ --with autoreconf --sourcedirectory=linux
 
-override_dh_auto_build:
-	dh_auto_build -- ENABLE_FFMPEG=yes ENABLE_OCR=yes
+override_dh_auto_configure:
+	dh_auto_configure -- --enable-ocr --enable-hardsubx
 
 override_dh_installchangelogs:
 	dh_installchangelogs docs/CHANGES.TXT

--- End Message ---
--- Begin Message ---
Source: ccextractor
Source-Version: 0.87+ds1-1

We believe that the bug you reported is fixed in the latest version of
ccextractor, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Raphaël Hertzog <[email protected]> (supplier of updated ccextractor package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 30 Nov 2018 11:45:16 +0100
Source: ccextractor
Binary: ccextractor
Architecture: source
Version: 0.87+ds1-1
Distribution: unstable
Urgency: medium
Maintainer: Freexian Packaging Team <[email protected]>
Changed-By: Raphaël Hertzog <[email protected]>
Description:
 ccextractor - fast closed captions extractor for MPEG and H264 files
Closes: 914311
Changes:
 ccextractor (0.87+ds1-1) unstable; urgency=medium
 .
   [ Corey Wright ]
   * Enable OCR and hard subtitle extraction through configure options.
     The environment variables passed to make are no longer used.
     (Closes: #914311)
 .
   [ Raphaël Hertzog ]
   * New upstream version 0.87+ds1
   * Update patches for new upstream version
   * Add extra include statement for tesseract headers
   * Update my maintainer email
Checksums-Sha1:
 6cda93dc845e9803409866bad05db88acb330f6b 1888 ccextractor_0.87+ds1-1.dsc
 c6758d1579e314f60216df5cc0ad17243cf085a8 1341456 
ccextractor_0.87+ds1.orig.tar.xz
 5755775dab4c63400e5695c2ef1116a97dc3b610 18432 
ccextractor_0.87+ds1-1.debian.tar.xz
 d8f787becca117c9bb76d943cf6b9f11dfacd16a 6361 
ccextractor_0.87+ds1-1_source.buildinfo
Checksums-Sha256:
 ef30208e888a900b28f749c533e045b662c913c6ea84a96f86959f24378cc3ea 1888 
ccextractor_0.87+ds1-1.dsc
 898d1f1edb2fc35fbfcd3fc4795ef6716517e1918f6a786953045f7c79687a7c 1341456 
ccextractor_0.87+ds1.orig.tar.xz
 51e01f551728da5ebbcbd225caa9a3b4613b26a457dc0aa3fbb2a1aec35bff34 18432 
ccextractor_0.87+ds1-1.debian.tar.xz
 8b568cd115d62265fc1e76ce9b9f0321f33418150b32f96ae69a20717b9868e5 6361 
ccextractor_0.87+ds1-1_source.buildinfo
Files:
 08c6c98722629c05abaa61b4aa7b6a40 1888 utils optional ccextractor_0.87+ds1-1.dsc
 d0162f5938f3efea93cd715b8353f085 1341456 utils optional 
ccextractor_0.87+ds1.orig.tar.xz
 cb7f377e28382bd603cc0b50ecfbee36 18432 utils optional 
ccextractor_0.87+ds1-1.debian.tar.xz
 aefed0b22c1cbf7ab642a0ec074832f3 6361 utils optional 
ccextractor_0.87+ds1-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----
Comment: Signed by Raphael Hertzog

iQEzBAEBCgAdFiEE1823g1EQnhJ1LsbSA4gdq+vCmrkFAlwBFkAACgkQA4gdq+vC
mrlliwgAnw3UqXnUOkTQY68HpZBEKEKoDMWsgWb3kguMqQlEmGrd4IvF16fBbuEX
TFNgAPgpTlav8WbKuFu+fqEm+LKUcwgUz+h7WZeljqhuvJYxs9bTQQc0tVP/77y/
pqKRhVZkPVeNcf8DcdRLEoECgK69lBusZhHHm4SeW1p2+zSqt0md935vz+qtnqGS
9X8u9jvxtdKJsOcG8OyrFkYtIDIcE9lR86afsAtnPIKxC5jlsrNQGZYTgL4K2t2y
4EGjx6fY7mdqDG2eeKsUbak0B+F0BcEdpIqXb9BKFrQ065aaJVPZy9b9ZbdvNxks
CvURlIIj1nLYqcfv5arUbJGsAMcU/A==
=8gMv
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to