Your message dated Sat, 01 Dec 2018 06:49:27 +0000
with message-id <[email protected]>
and subject line Bug#914937: fixed in edfbrowser 1.66+dfsg-2
has caused the Debian Bug report #914937,
regarding edfbrowser: fix dh_auto_configure overriding
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
914937: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=914937
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: edfbrowser
Version: 1.66+dfsg-1
Severity: minor
Tags: patch
Hi,
the current rules overrides dh_auto_build to run qmake manually again,
specifying build flags. OTOH, this runs qmake again, and it is not
needed with newer debhelper: using the DEB_<var>_MAINT_APPEND interface
of dpkg-buildflags will append the right flags when qmake is called by
the default dh_auto_configure invocation. Also, debhelper already
handles noopt in DEB_BUILD_OPTIONS already.
Hence, the attached patch simplifies rules a lot, dropping also
variables not needed (anymore).
Thanks,
--
Pino
--- a/debian/rules
+++ b/debian/rules
@@ -5,37 +5,19 @@
# export DEB_BUILD_MAINT_OPTIONS = hardening=+all
export DEB_BUILD_MAINT_OPTIONS = hardening=+bindnow
-DEB_HOST_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE )
-DEB_BUILD_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE )
-DEB_BUILD_ARCH_OS ?= $(shell dpkg-architecture -qDEB_BUILD_ARCH_OS )
-ARCH := $(shell dpkg-architecture -qDEB_BUILD_ARCH )
-
-Q_LDFLAGS:=$(shell dpkg-buildflags --get LDFLAGS) -Wl,--as-needed
-export Q_LDFLAGS
-
-# of course, qmake wants to do it its own way
-QMAKE_CXXFLAGS += $(CPPFLAGS) -Wall -Wshadow -Wextra -ggdb3
-ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
- QMAKE_CXXFLAGS_RELEASE = -O0
-else
- QMAKE_CXXFLAGS_RELEASE = -O2
-endif
+export DEB_LDFLAGS_MAINT_APPEND := -Wl,--as-needed
+export DEB_CXXFLAGS_MAINT_APPEND := -Wall -Wshadow -Wextra -ggdb3
export QT_SELECT=qt5
%:
dh $@
-override_dh_auto_build:
- qmake -makefile -after \
- QMAKE_CXXFLAGS="$(QMAKE_CXXFLAGS)" \
- QMAKE_CXXFLAGS_RELEASE="$(QMAKE_CXXFLAGS_RELEASE)" \
- QMAKE_LFLAGS="$(Q_LDFLAGS)"
+override_dh_auto_configure:
+ dh_auto_configure
# libpthread is only used indirectly; no need for linking against it
sed -i -e 's/-lpthread//' Makefile
- $(MAKE)
-
override_dh_clean:
test ! -f Makefile || $(MAKE) distclean
dh_clean
--- End Message ---
--- Begin Message ---
Source: edfbrowser
Source-Version: 1.66+dfsg-2
We believe that the bug you reported is fixed in the latest version of
edfbrowser, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Andreas Tille <[email protected]> (supplier of updated edfbrowser package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 01 Dec 2018 07:17:28 +0100
Source: edfbrowser
Binary: edfbrowser
Architecture: source
Version: 1.66+dfsg-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Med Packaging Team
<[email protected]>
Changed-By: Andreas Tille <[email protected]>
Description:
edfbrowser - viewer for biosignal storage files such as bdf and edf
Closes: 914937
Changes:
edfbrowser (1.66+dfsg-2) unstable; urgency=medium
.
* fix dh_auto_configure overriding (thanks for the patch to Pino Toscano)
Closes: #914937
Checksums-Sha1:
1bb0667b5c5f2c5842a49b95e8d285bf43d9e445 2074 edfbrowser_1.66+dfsg-2.dsc
25f336562de36cf9fdb87421471f31bb63594bdf 7836
edfbrowser_1.66+dfsg-2.debian.tar.xz
Checksums-Sha256:
43750e7089e7714b5ceb4e7cbb5b2db43c63b481ab3de74448d1c1a81649eb4e 2074
edfbrowser_1.66+dfsg-2.dsc
876f340e4b1b3f7586377b0875000f57e6513f19502236274ce2b17d3b2e9dd9 7836
edfbrowser_1.66+dfsg-2.debian.tar.xz
Files:
ae7d13532b8b3a4c766954dbf16e9355 2074 science optional
edfbrowser_1.66+dfsg-2.dsc
476c03eb492c046f2359d5bc6cc4e5cc 7836 science optional
edfbrowser_1.66+dfsg-2.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQJFBAEBCAAvFiEE8fAHMgoDVUHwpmPKV4oElNHGRtEFAlwCKZYRHHRpbGxlQGRl
Ymlhbi5vcmcACgkQV4oElNHGRtH2bg//aKoh3qx0SN/QgDtwwj71iFvbk4emDp0c
LOtaUQJJdOlYYm9EIN7HsqJcTZA6JU8vOjbuGCQGW/ilFlCTg+4SQuQHBIr98FoF
ig8lfnjXIlCLk1pATGw1eG9FdMpXao7uH7j2xCTH6MTB2L5DNeRr2HUJ2FkyzB/n
DaeBAwfmRJy21SVyGXqq18/5XACTBOTWWpXasivJIF+0s4i1rgvKnNPRtc3CgZub
KqZQzalX7V9PoYuoV3YzinlyCwFD5HHn4wPU0MhP/cIYy3jfuvcqUSvPE/FY+zww
a0hvza21ozDk1nCSCB4TcIPKD5aEmI55h8+NDyhFNfA/rPFY76pqzBGEzCjX7oNu
9UtJzBm2Kgcy+ueuZH5p3B9+I3Mp2By/6jvLMTXsEmj28I/Jae1/Jhxdps7NWb8l
x9SplpMa/vG5+kGCuABQ4B3KDKcsOIU/AqC31ZF7wZJTpFio2Yu+T0N7yVq66i8h
Dy2VORPQqL6LSv4ph1VmbBzMel6GHQxU+aWiSsnaXjDQjg650M9NHXkqSFmnLyBP
eoT0314eTkuWxNRMrctRRHloslADX5SeZ6l6D3ZrlJd7khwYlXjBmTCS1AGgVAcS
epamSfYIoDq9zRz9sRUSk87c/EilzdeUm8gYS1Yu7PKBwPAdECaHqQF6BqzJWxKr
4uwW2lrJvjs=
=miy9
-----END PGP SIGNATURE-----
--- End Message ---
