Your message dated Sun, 16 Dec 2018 06:19:17 +0000 with message-id <[email protected]> and subject line Bug#888899: fixed in e2fsprogs 1.44.5-1 has caused the Debian Bug report #888899, regarding e4defrag: Unsigned integer overflow in failure count when new files created to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 888899: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=888899 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: e2fsprogs Version: 1.43.4-2 Severity: minor I have a web cache which creates and destroys new files on a regular basis. I tried defragmenting the cache folder recently and got this result: ---- # ionice -c3 nice -n 20 e4defrag -v /cache ... [786179/779728]/cache/94/31c16d90eb4dc4d0df8df8f3b1be7594: 100% extents: 1 -> 1 [ OK ] [786180/779728]/cache/94/3cfbcc37f603bb9365d48f4264eace94: 100% extents: 1 -> 1 [ OK ] Success: [ 785923/779728 ] Failure: [ 4294961101/779728 ] Total extents: 2865002->2591929 Fragmented percentage: 18%->17% ---- Curiously, the success count is higher than the theoretical total, while the failure count is just below MAX_INT. The running count has also exceeded its supposed maximum. The issue appears to be that the code is doing: printf("\n\tSuccess:\t\t\t[ %u/%u ]\n", succeed_cnt, total_count); printf("\tFailure:\t\t\t[ %u/%u ]\n", total_count - succeed_cnt, total_count); This would be fine except that: * total_count and succeed_cnt are both unsigned integers. * total_count is incremented via an initial call to nftw64() using calc_entry_counts() * succeed_cnt is incremented by a _later_ call to nftw64() using file_defrag(). * Defragmentation occurs on a live filesystem, not a snapshot. If enough new files are created during the defragmentation process, more may be successfully defragged in the second walk than are initially counted. This might not have been noticed before because defrag is often done on a complete, mostly-static disk with several expected failures. Probably the success/failure printf()s should use defraged_file_count (incremented at the start of file_defrag) rather than total_count. I'm more ambivalent about the inconsistency in the running count - it could be argued that it merely reflects the harsh reality. -- Laurence "GreenReaper" Parry http://www.greenreaper.co.uk/
--- End Message ---
--- Begin Message ---Source: e2fsprogs Source-Version: 1.44.5-1 We believe that the bug you reported is fixed in the latest version of e2fsprogs, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Theodore Y. Ts'o <[email protected]> (supplier of updated e2fsprogs package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Sat, 15 Dec 2018 22:46:49 -0500 Source: e2fsprogs Binary: fuse2fs e2fsck-static e2fsprogs-l10n libcomerr2 libcom-err2 comerr-dev libss2 ss-dev e2fsprogs-udeb e2fslibs e2fslibs-dev libext2fs2 libext2fs-dev e2fsprogs Architecture: source Version: 1.44.5-1 Distribution: unstable Urgency: medium Maintainer: Theodore Y. Ts'o <[email protected]> Changed-By: Theodore Y. Ts'o <[email protected]> Description: comerr-dev - common error description library - headers and static libraries e2fsck-static - statically-linked version of the ext2/ext3/ext4 filesystem checke e2fslibs - transitional package e2fslibs-dev - transitional package e2fsprogs - ext2/ext3/ext4 file system utilities e2fsprogs-l10n - ext2/ext3/ext4 file system utilities - translations e2fsprogs-udeb - stripped-down versions of e2fsprogs, for debian-installer (udeb) fuse2fs - ext2 / ext3 / ext4 file system driver for FUSE libcom-err2 - common error description library libcomerr2 - transitional package libext2fs-dev - ext2/ext3/ext4 file system libraries - headers and static librari libext2fs2 - ext2/ext3/ext4 file system libraries libss2 - command-line interface parsing library ss-dev - command-line interface parsing library - headers and static libra Closes: 888899 907634 914087 915942 916188 Changes: e2fsprogs (1.44.5-1) unstable; urgency=medium . * New upstream version * Avoid overflows when tracking the number of files defragged by e4defrag (Closes: #888899) * Fix groff formatting nits in various man pages (Closes: #916188) * Fix location of libext2fs documentation (Closes: #915942) * Fix regression so we are correctly translating Posix ACL's in libext2fs * Use the online free block counts so e2freefrag's percentages are correct * Fix a false warning that tune2fs will take long time to change a UUID if the metadata_csum feature is not enabled * Fix mk_cmds so it works on a usrmerge system when e2fsprogs is built on a non-usrmerge system (Closes: #914087) * E2fsck will avoid offering to set the inline_data feature flag unnecessarily * E4defrag will handle the case where it is running as root and it can't find the file system to open more gracefully (Closes: #907634) * Fix a bug where resize2fs was failing to update the extent tree checksums in an corner case * Fix fuse2fs's command line parsing when options are specified after the target device/image * Fix a bug which could cause e2fsprogs tools to segfault on a corrupted file system where the journal's s_nr_users is impossibly large. * E2image now includes the mmp block (if needed) when creating a metadata-only image. * When e2fsck notices it could optimize an extent tree, it will now ask "Optimize?" instead of "Fix?", which was confusing some users since it implied that something was broken. Checksums-Sha1: 44105d35e604d6ef2e34d8367a5748a3a5b16293 2747 e2fsprogs_1.44.5-1.dsc c3f64d10b6ef1a268a077838a5cafb6aaebe2986 7619237 e2fsprogs_1.44.5.orig.tar.gz db05093049f5f2788a5b6fd23a6746bbcfe05ed9 488 e2fsprogs_1.44.5.orig.tar.gz.asc 42f5b9d82b58387138efa2d51cff303f0c7291ae 78056 e2fsprogs_1.44.5-1.debian.tar.xz 3a2708e16aad449d9c3b1301f803e509769394b4 10624 e2fsprogs_1.44.5-1_amd64.buildinfo Checksums-Sha256: 119cb2a7901e48bb282b6335121388f7e5849b40664dae0c05c03491236db5bb 2747 e2fsprogs_1.44.5-1.dsc 2e211fae27ef74d5af4a4e40b10b8df7f87c655933bd171aab4889bfc4e6d1cc 7619237 e2fsprogs_1.44.5.orig.tar.gz c0e3e4e51f46c005890963b005015b784b2f19e291a16a15681b9906528f557e 488 e2fsprogs_1.44.5.orig.tar.gz.asc 287dd7f311a98c99e984500d7cfd2860aa0c5409672f35515f0a31412799d0dc 78056 e2fsprogs_1.44.5-1.debian.tar.xz 2af9e3c8a5a609534834e5f9ca2c174272bcd8e231dc766879f84c11aadf2ef6 10624 e2fsprogs_1.44.5-1_amd64.buildinfo Files: 9964621411884cf0dcdeb998e400eb2d 2747 admin required e2fsprogs_1.44.5-1.dsc 8d78b11d04d26c0b2dd149529441fa80 7619237 admin required e2fsprogs_1.44.5.orig.tar.gz dde8ecabaf0f5082ef7de90e8bc9b8c6 488 admin required e2fsprogs_1.44.5.orig.tar.gz.asc 9ee35898680b692654c908121aedf43d 78056 admin required e2fsprogs_1.44.5-1.debian.tar.xz 0e157b3759a60871c1a7ab79245375fd 10624 admin required e2fsprogs_1.44.5-1_amd64.buildinfo -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEK2m5VNv+CHkogTfJ8vlZVpUNgaMFAlwV60IACgkQ8vlZVpUN gaOA6Af+JciSTLx0xu40c0CsAzhE7bFjCsinRIsZCOkbv3UMVjprXvB3L4iSM0x2 muvOIaMlb9W+XyqyspNoEwJkADGPdZ8aXtVFryAxW7qALF/+UKCdnm7xQ1yPTTwL eOFdX9ssTXWoxBSreNHm8/b2VoKrzWkurp4h8e0t2GeaPRn+I6Tbtmy+TNutg27A /dJ3YLIji5yw6PsmUUV4jJlrfY+Cgq4dpc+adQDMkbiCIGtBij8PXTEf7XhStUGm vhLcxk8vFVsk3gw8N0/3+pHBIkjJYBucCTaRC4mt2H8O6/OrmuCJLv+idM548cz9 Q0ALhMHpbLQGQ5W/PL8GX7MJuPXguA== =/X2i -----END PGP SIGNATURE-----
--- End Message ---
