Your message dated Sun, 16 Dec 2018 11:21:03 +0000 with message-id <e1gyutn-000etn...@fasolo.debian.org> and subject line Bug#915953: fixed in postgresql-common 198 has caused the Debian Bug report #915953, regarding pg_buildext: support Makefile variables to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 915953: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=915953 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: postgresql-server-dev-all Version: 197 Severity: wishlist Tags: patch Dear Maintainer, it would be nice if pg_buildext allowed to pass Makefile variables down to the make calls. The specific issue at hand for me was passing 'with_llvm=no' cause the extension I wanted to build currently has issues with it. AFAICT this is currently not possible via pg_buildext? The attached patch adds an option -x (maybe not the best pick?) whose $OPTARG are passed down to alle make calls - that works for me, but I have not tested it extensively. Michaeldiff --git a/pg_buildext b/pg_buildext index 9800495..66c4e37 100755 --- a/pg_buildext +++ b/pg_buildext @@ -24,10 +24,11 @@ die() { } VENVARGS="" -while getopts "c:i:o:s" opt ; do +while getopts "c:i:o:sx:" opt ; do case $opt in c|i|o) VENVARGS="$VENVARGS -$opt $OPTARG" ;; s) VENVARGS="$VENVARGS -$opt" ;; + x) MAKEVARS="$OPTARG" ;; *) exit 1 ;; esac done @@ -73,7 +74,7 @@ build() { mkdir -p $vtarget # if a Makefile was created by configure, use it, else the top level Makefile [ -f $vtarget/Makefile ] || makefile="-f $srcdir/Makefile" - make -C $vtarget ${makefile:-} ${cflags:+CFLAGS="$cflags"} PG_CONFIG="$pgc" VPATH="$srcdir" USE_PGXS=1 + make -C $vtarget ${makefile:-} ${cflags:+CFLAGS="$cflags"} PG_CONFIG="$pgc" VPATH="$srcdir" USE_PGXS=1 $MAKEVARS } install() { @@ -83,7 +84,7 @@ install() { mkdir -p $vtarget # if a Makefile was created by configure, use it, else the top level Makefile [ -f $vtarget/Makefile ] || makefile="-f $srcdir/Makefile" - make -C $vtarget ${makefile:-} install DESTDIR="$PWD/debian/$package" PG_CONFIG="$pgc" VPATH="$srcdir" USE_PGXS=1 + make -C $vtarget ${makefile:-} install DESTDIR="$PWD/debian/$package" PG_CONFIG="$pgc" VPATH="$srcdir" USE_PGXS=1 $MAKEVARS } clean() { @@ -91,7 +92,7 @@ clean() { # if a Makefile was created by configure, use it, else the top level Makefile [ -f $vtarget/Makefile ] || makefile="-f $srcdir/Makefile" - [ -d $vtarget ] && make -C $vtarget clean ${makefile:-} PG_CONFIG="$pgc" VPATH="$srcdir" USE_PGXS=1 + [ -d $vtarget ] && make -C $vtarget clean ${makefile:-} PG_CONFIG="$pgc" VPATH="$srcdir" USE_PGXS=1 $MAKEVARS rm -rf $vtarget } @@ -101,11 +102,11 @@ loop() { package=$(echo $target | sed -e "s:%v:$1:g") echo "# $1: make clean" - make -C "$srcdir" clean PG_CONFIG="$pgc" USE_PGXS=1 + make -C "$srcdir" clean PG_CONFIG="$pgc" USE_PGXS=1 $MAKEVARS echo "# $1: make" - make -C "$srcdir" PG_CONFIG="$pgc" USE_PGXS=1 + make -C "$srcdir" PG_CONFIG="$pgc" USE_PGXS=1 $MAKEVARS echo "# $1: make install" - make -C "$srcdir" install DESTDIR="$PWD/debian/$package" PG_CONFIG="$pgc" USE_PGXS=1 + make -C "$srcdir" install DESTDIR="$PWD/debian/$package" PG_CONFIG="$pgc" USE_PGXS=1 $MAKEVARS echo "### done $1 ###" } @@ -125,7 +126,7 @@ installcheck() { [ -f $vtarget/Makefile ] || makefile="-f $srcdir/Makefile" if ! pg_virtualenv $VENVARGS -v $1 \ make -C $vtarget ${makefile:-} installcheck \ - PG_CONFIG="$pgc" VPATH="$srcdir" USE_PGXS=1; then + PG_CONFIG="$pgc" VPATH="$srcdir" USE_PGXS=1 $MAKEVARS; then if [ -r $vtarget/regression.diffs ]; then echo "**** $vtarget/regression.diffs ****" cat $vtarget/regression.diffs @@ -134,7 +135,7 @@ installcheck() { fi else if ! pg_virtualenv $VENVARGS -v $1 \ - make installcheck PG_CONFIG="$pgc" USE_PGXS=1; then + make installcheck PG_CONFIG="$pgc" USE_PGXS=1 $MAKEVARS; then if [ -r regression.diffs ]; then echo "**** regression.diffs ****" cat regression.diffs
--- End Message ---
--- Begin Message ---Source: postgresql-common Source-Version: 198 We believe that the bug you reported is fixed in the latest version of postgresql-common, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 915...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Christoph Berg <m...@debian.org> (supplier of updated postgresql-common package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Sun, 16 Dec 2018 11:55:10 +0100 Source: postgresql-common Binary: postgresql-common postgresql-client-common postgresql-server-dev-all postgresql postgresql-client postgresql-doc postgresql-contrib postgresql-all Architecture: source Version: 198 Distribution: unstable Urgency: medium Maintainer: Debian PostgreSQL Maintainers <team+postgre...@tracker.debian.org> Changed-By: Christoph Berg <m...@debian.org> Description: postgresql - object-relational SQL database (supported version) postgresql-all - metapackage depending on all PostgreSQL server packages postgresql-client - front-end programs for PostgreSQL (supported version) postgresql-client-common - manager for multiple PostgreSQL client versions postgresql-common - PostgreSQL database-cluster manager postgresql-contrib - additional facilities for PostgreSQL (supported version) postgresql-doc - documentation for the PostgreSQL database management system postgresql-server-dev-all - extension build tool for multiple PostgreSQL versions Closes: 915953 Changes: postgresql-common (198) unstable; urgency=medium . [ Christoph Berg ] * Add gitlab-ci.yml file to be included in all PostgreSQL team packages. * testsuite: Stop postgresql@* explicitly. (Workaround for #759725) . [ Michael Banck ] * pg_buildext: Add support for passing Makefile variables via the new -m option. (Closes: #915953) Checksums-Sha1: 92fc6c7efb951c504669e5aeabfc17ad4bcc3988 2309 postgresql-common_198.dsc fc934a6a6f4b473febe9c7674935a79212f7e308 210036 postgresql-common_198.tar.xz Checksums-Sha256: e56eee317044c43074445d96153abf8a3664e05d28adacc6eacf39106151a984 2309 postgresql-common_198.dsc 8485828b7bcfd201cee309fa26483942777e7e4311f7a82f24c78e684a205354 210036 postgresql-common_198.tar.xz Files: 0dc6fa1c1511a0741169b426445cbda6 2309 database optional postgresql-common_198.dsc e1024c2e8367603f1b15b1c500e4f418 210036 database optional postgresql-common_198.tar.xz -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEXEj+YVf0kXlZcIfGTFprqxLSp64FAlwWL1AACgkQTFprqxLS p67ZEA/5AZJmp1Nk9JePdtuVz+0C8+uphu2GXw/EwGs1ec3ZV6UP+iY9MdAUrs8v kayBT1s4PdfTaxJVb6LuaNY16v9kYLmgAMyDYh0t5Xgjt38yfemjgGJ7Kjr5edQv BlTDpHynXboIVfCZYoiPuNrrR5Gkooro6Kpt3Pr1fcPOvyC7SwRI2ZETtZrhVoMS ivZ8HlLscbVJ8v17TfWlQAhCAZElrW62YZiS0JiKbvmyNRC2R0krwZb6z/FgdVg5 dhDzNcKMJ8ym3gDQ/M4v5eA+aEpjCxGreps0LG8tUYYdCsspjUOqFX3gJ26Fh7wO Rsk/BPOTiDOtg7H/ucZixuC/x//eN6/EpJ8ByrhK7+QjTmwm2fuC7vq1hef7+VNA CpxUZFfnY8qXUA5dX+zadD31hh4Hsh0aOjCXrafn47pa3NwcB0qegZ6i3tVZO0an 9WnWL9gVt5vyrZW1fYJupSELiEaCBKEaT63TRKCpbw6G7/i7j0BJ7P/S/GAfETb5 ponL0QROlWpOCOaF7x9kLHOHDg5gb3gST0ai+oAP5azSlhSl/CtdMv7ON3UqhO1L 0Mc+xyM+klWSKxigLkL8IuQpgVSvM29h5AQBRXvFzcpsEoJ6Ag1dDWqmoBM2sFlf nYZTwr3RLSzAfWJ795LH2Ues4zK0kkG5clCKe2bNGf1TKRzCZhw= =TvVH -----END PGP SIGNATURE-----
--- End Message ---
