Your message dated Tue, 18 Dec 2018 20:51:43 +0000
with message-id <[email protected]>
and subject line Bug#916660: fixed in luola 1.3.2-12
has caused the Debian Bug report #916660,
regarding luola: FTBFS with ld --as-needed
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
916660: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=916660
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: luola
Version: 1.3.2-11
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu disco ubuntu-patch

Dear Maintainer,

luola currently fails to build from source with ld --as-needed, which is
enabled by default in Ubuntu. This linker option requires that
libraries be placed after the objects that require them, but the current
logic to add -lm to LDFLAGS adds it near the beginning of the command
with the linker options.

In Ubuntu, the attached patch was applied to achieve the following:

  * d/p/link_against_libm: Use Autotools to find/link against libm instead of
    manually appending -lm to LDFLAGS to fix FTBFS with ld --as-needed.

Thanks for considering the patch.

Logan Rosen

-- System Information:
Debian Release: buster/sid
  APT prefers cosmic-updates
  APT policy: (500, 'cosmic-updates'), (500, 'cosmic-security'), (500, 
'cosmic'), (400, 'cosmic-proposed'), (100, 'cosmic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.18.0-12-generic (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru luola-1.3.2/debian/patches/link_against_libm 
luola-1.3.2/debian/patches/link_against_libm
--- luola-1.3.2/debian/patches/link_against_libm        1969-12-31 
19:00:00.000000000 -0500
+++ luola-1.3.2/debian/patches/link_against_libm        2018-12-16 
19:15:32.000000000 -0500
@@ -0,0 +1,10 @@
+--- a/configure.ac
++++ b/configure.ac
+@@ -73,6 +73,7 @@
+ #AC_CHECK_LIB(pthread, main,, AC_MSG_ERROR(SDL needs pthread !))
+ AC_CHECK_LIB([SDL_image],[main],[],AC_MSG_ERROR(SDL_image is needed))
+ AC_CHECK_LIB([z],[main],[],AC_MSG_ERROR(libz is needed))
++AC_SEARCH_LIBS([hypot],[m],[],AC_MSG_ERROR(libm is needed))
+ 
+ AC_CONFIG_FILES([Makefile
+                  contrib/Makefile
diff -Nru luola-1.3.2/debian/patches/series luola-1.3.2/debian/patches/series
--- luola-1.3.2/debian/patches/series   2018-09-13 17:50:13.000000000 -0400
+++ luola-1.3.2/debian/patches/series   2018-12-16 19:12:42.000000000 -0500
@@ -2,3 +2,4 @@
 luola-manpage
 remove_implicit_declaration
 hurd_path_max
+link_against_libm
diff -Nru luola-1.3.2/debian/rules luola-1.3.2/debian/rules
--- luola-1.3.2/debian/rules    2018-09-13 17:50:13.000000000 -0400
+++ luola-1.3.2/debian/rules    2018-12-16 19:15:38.000000000 -0500
@@ -5,7 +5,6 @@
 export DH_VERBOSE=1
 
 export DEB_BUILD_MAINT_OPTIONS=hardening=+all
-export DEB_LDFLAGS_MAINT_APPEND = -lm
 
 %:
        dh $@

--- End Message ---
--- Begin Message ---
Source: luola
Source-Version: 1.3.2-12

We believe that the bug you reported is fixed in the latest version of
luola, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christian T. Steigies <[email protected]> (supplier of updated luola package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 18 Dec 2018 21:06:04 +0100
Source: luola
Binary: luola luola-data
Architecture: source all amd64
Version: 1.3.2-12
Distribution: unstable
Urgency: medium
Maintainer: Christian T. Steigies <[email protected]>
Changed-By: Christian T. Steigies <[email protected]>
Description:
 luola      - multiplayer cave-flying game
 luola-data - data files for luola
Closes: 916660
Changes:
 luola (1.3.2-12) unstable; urgency=medium
 .
   * add Vcs entries
   * apply ubuntu patch to fix FTBFS with ld --as-needed  (closes: #916660)
Checksums-Sha1:
 5d02199ac7dcd6b9df354a8925a770d7b0771f19 1981 luola_1.3.2-12.dsc
 bc5fa87341941508df8dc1bf2ae4473de5df3f0d 10988 luola_1.3.2-12.debian.tar.xz
 70cd94e40af62ee710b0dc403e04e3c819498d45 1312512 luola-data_1.3.2-12_all.deb
 d908a0839cc247ed08a2fe7c262f3d82181d6645 312536 luola-dbgsym_1.3.2-12_amd64.deb
 b39ad4a36c9ee370eed022b74e72d8334d286e5f 13542 luola_1.3.2-12_amd64.buildinfo
 2294211f1884bb8342300e234fee9d2dc3a7710f 112460 luola_1.3.2-12_amd64.deb
Checksums-Sha256:
 ea92b04076260d4fe0003dd0cadd48226f11ecd9fcc44649ec35234ac05246cb 1981 
luola_1.3.2-12.dsc
 51f00ed2304ae6a8e2146140e8433180ee8b3abd6b85c3ebcb56adb4c22c5d94 10988 
luola_1.3.2-12.debian.tar.xz
 003cfa1929a4325c62e3812a757e89ad4bcfaac5d44b76fa702110cbfc8cb877 1312512 
luola-data_1.3.2-12_all.deb
 0c00bf62d81f8bb7ce57616823bf330484b84e10242eb3959ef9adaa8c090f0d 312536 
luola-dbgsym_1.3.2-12_amd64.deb
 1e1cac7d225c44ddf04ac8a886658e66a440548982b8d404b845c8e920ada203 13542 
luola_1.3.2-12_amd64.buildinfo
 bf0ad70567f936e50701f4174e7fa0851eedbe48ab8a64f0b19b75dcc5bf0874 112460 
luola_1.3.2-12_amd64.deb
Files:
 fd32c030aea117a960fab0ae85496fb3 1981 games optional luola_1.3.2-12.dsc
 1f041393d96685499191454ff3c4d3a7 10988 games optional 
luola_1.3.2-12.debian.tar.xz
 9c8e055a2e1f95d5777e516e5e03dba4 1312512 games optional 
luola-data_1.3.2-12_all.deb
 db5eca208645d557ba2eff46d88b2258 312536 debug optional 
luola-dbgsym_1.3.2-12_amd64.deb
 97e41f97c561dcfd42e30b69615b2497 13542 games optional 
luola_1.3.2-12_amd64.buildinfo
 331926ec06ad7388595c09c88693aacd 112460 games optional luola_1.3.2-12_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEMuHemUY/GC4Wej4EcA1WeHGyg0IFAlwZVSkACgkQcA1WeHGy
g0IDbxAAtnwHoxdowgFx/lfeue/KK1IFl5qOWRTgWLVn9+2lAOVZyJdKCmgjIUpw
lJ2q97MVtRz8swJK1jI3Km7/pg+47qGs+aELoAyy9K00mCIiWPuAnb/APv8+USYi
2ILbOHWBmfJofQ2guxstWkIva9Jjy/L/0RunYw5/rk9O/CZYV+rGwhTGE6+u9HMv
l79BHk1YYBsLxUgtMQQpnCzIM66RI20t4QdwjxtNgpMA6G1R5eMEiiAOxIWS7JTt
k0yXpxiJ3pGF9ZEwpJhRwWp1rDIxCx3fXrFXCXzLwborZwk4WID0JLvSmj/Md7FA
CTWGp6Lj0L0PniP0+P0q3ZVLllF8UZbrLQEbxXDAe9SS2UU+3d69sB0TxEUVGj4l
V7wPhT2tn7zLW6zzBmloPDFOwSUXTbnHqHMUMIhGvqC6MdPY5dsKErAEB+E3c77G
SdyrzjbPQh2i5CIbMNV12sGidhuyqFoCaX6tSXNdP3dBb8MQsXTZGbWP9xdeZAK6
C4vJqkWRt1KPo/Xisnl7DyFuuQMpQQlxZNXwCeFESjzV1H/rwsnBdPMhDY2Ku5py
ZfdR/DyTlQ9YifRIL8HF2861Vmdvs0fU9ND1Kpf2KJ517pp1d0oCcS/WJZ3UROLN
hnN2fUvtCd4sMyg9B/diEC0Gi2uRsMF99KDTTk8OE1oKULD9XWw=
=1wXr
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to