Your message dated Mon, 31 Dec 2018 04:48:46 +0000
with message-id <[email protected]>
and subject line Bug#917521: Removed package(s) from unstable
has caused the Debian Bug report #749981,
regarding configure test HAVE_VISIBILITY_ATTR unnecessarily introduces nested 
functions
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
749981: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=749981
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ntdb
Version: 1.0-4
Severity: wishlist
Usertags: goto-cc

While building the package I noticed an unexpected

[...]
Checking compiler accepts -fvisibility=hidden                                   
  : yes
Checking for HAVE_VISIBILITY_ATTR                                               
  : not found

when using a compiler that does not have support for nested functions. Yet it
seems that these aspects should not interact, but the configure check in
lib/replace/wscript uses the following:

    if conf.CHECK_CFLAGS('-fvisibility=hidden'):
        conf.env.VISIBILITY_CFLAGS = '-fvisibility=hidden'
        conf.CHECK_CODE('''void vis_foo1(void) {}
                           __attribute__((visibility("default"))) void 
vis_foo2(void) {}''',
                        cflags=conf.env.VISIBILITY_CFLAGS,
                        define='HAVE_VISIBILITY_ATTR')

with buildtools/wafsamba/samba_autoconf.py doing the following:

    if addmain:
        fragment='%s\n%s\n int main(void) { %s; return 0; }\n' % (defs, hdrs, 
code)
    else:
        fragment='%s\n%s\n%s\n' % (defs, hdrs, code)

Hence the function vis_foo1 and vis_foo2 will end up being defined within main,
resulting in nested functions. This unnecessarily breaks the build using
compilers such as Clang.

To fix the problem, conf.CHECK_CODE should be called with link=False,
addmain=False.

Best,
Michael

PS.: This configuration bit appears to exist as literal copy in several
packages, the bug report will be cloned accordingly.

Attachment: pgph7FwPCVmQ4.pgp
Description: PGP signature


--- End Message ---
--- Begin Message ---
Version: 1.0-9+rm

Dear submitter,

as the package ntdb has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see https://bugs.debian.org/917521

The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
[email protected].

Debian distribution maintenance software
pp.
Scott Kitterman (the ftpmaster behind the curtain)

--- End Message ---

Reply via email to