Your message dated Thu, 10 Jan 2019 20:45:17 +0000 with message-id <[email protected]> and subject line Bug#898297: fixed in ufraw 0.22-4 has caused the Debian Bug report #898297, regarding ufraw/ufraw-batch: segfault during ufraw_close (program shutdown) to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 898297: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=898297 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: ufraw-batch,ufraw Version: 0.22-3 Severity: important Tags: upstream I am observing a segmentation fault when processing any file with ufraw or ufraw-batch with any combination of options I tried. The segfault happens after closing a file: (gdb) bt #0 lfModifier::~lfModifier (this=0x0, __in_chrg=<optimized out>) at ./libs/lensfun/modifier.cpp:270 #1 0x00007f53406cb2f9 in lfModifier::Destroy (this=0x0) at ./libs/lensfun/modifier.cpp:143 #2 0x00007f53406cb395 in lf_modifier_destroy (modifier=<optimized out>) at ./libs/lensfun/modifier.cpp:308 #3 0x0000559485cd368a in ufraw_close (uf=0x559487c6ece0) at ufraw_ufraw.c:770 #4 0x0000559485cce2da in main (argc=<optimized out>, argv=<optimized out>) at ufraw-batch.c:107 (gdb) While ufraw takes care to check uf->TCAmodifier against NULL, it doesn't in ufraw_ufraw.c line 770 and just passes a NULL pointer to lf_modifier_destroy. Sounds like all we need here is a NULL pointer check (untested): --- a/ufraw_ufraw.c +++ b/ufraw_ufraw.c @@ -767,7 +767,8 @@ g_free(uf->displayProfile); g_free(uf->RawHistogram); #ifdef HAVE_LENSFUN - lf_modifier_destroy(uf->TCAmodifier); + if (uf->TCAmodifier != NULL) + lf_modifier_destroy(uf->TCAmodifier); lf_modifier_destroy(uf->modifier); #endif ufobject_delete(uf->conf->ufobject); This pretty much breaks ufraw-batch, because it segfaults after processing the first file. Helmut
--- End Message ---
--- Begin Message ---Source: ufraw Source-Version: 0.22-4 We believe that the bug you reported is fixed in the latest version of ufraw, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Hubert Chathi <[email protected]> (supplier of updated ufraw package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Thu, 10 Jan 2019 10:59:32 -0500 Source: ufraw Binary: ufraw ufraw-batch gimp-ufraw Architecture: source amd64 Version: 0.22-4 Distribution: unstable Urgency: medium Maintainer: Hubert Chathi <[email protected]> Changed-By: Hubert Chathi <[email protected]> Description: gimp-ufraw - gimp importer for raw camera images ufraw - standalone importer for raw camera images ufraw-batch - batch importer for raw camera images Closes: 898297 Changes: ufraw (0.22-4) unstable; urgency=medium . * Check for null pointers before destroying. (Closes: #898297) Thanks to Helmut Grohe and Lauro Moura. Checksums-Sha1: 593007ed7b89819e8fdf7d1c8956945cd6ced935 1619 ufraw_0.22-4.dsc 06f1f0540ac8545969e586171c2030ab31bbdd80 9048 ufraw_0.22-4.debian.tar.xz ef3b5ce6584fc64a36783aa530a914db53d18408 877528 gimp-ufraw-dbgsym_0.22-4_amd64.deb a683e2d65bdacfbe2af32699b6b77da043bec8ef 488452 gimp-ufraw_0.22-4_amd64.deb 31f549fb90d07d4e81765bc164946204ca9fb13c 658636 ufraw-batch-dbgsym_0.22-4_amd64.deb 701d9e0a0e7c534d59b5df701189b152032d2cf0 395404 ufraw-batch_0.22-4_amd64.deb f9d797a957aed153177fe17f644ff44423bdd338 899020 ufraw-dbgsym_0.22-4_amd64.deb c6755667c705431e1ce6c4372369fe35bb978db5 14086 ufraw_0.22-4_amd64.buildinfo b68e83093cf249d044314cd9e652249879cc2a29 617644 ufraw_0.22-4_amd64.deb Checksums-Sha256: 8ff4fad5b207b7e7220cd20443eb0378052a847e0210fb80844b7df7abff24f5 1619 ufraw_0.22-4.dsc 5a06d7d5660df57c2cf7861dd000ebb48dcaa9b7caab4a6c1f5a2a3ac9ad4c5a 9048 ufraw_0.22-4.debian.tar.xz 67b0f641601af69dc751dc9a8bbc81e7f81df07e1c4ad6ff6d5b85cc21c90a85 877528 gimp-ufraw-dbgsym_0.22-4_amd64.deb a436f0d93bb550983fc807f720f110eda4004acda16e189387633a9a426570c1 488452 gimp-ufraw_0.22-4_amd64.deb f3260baa8ef7a5fe0bb87ee9ff0bcc3167ba216c8f4b814172caeed4f344cf49 658636 ufraw-batch-dbgsym_0.22-4_amd64.deb 5b4e64c3f1a8a5c5564e95283a9e3a6adfdd4a50f9bf5069b5f1800f63ade6b9 395404 ufraw-batch_0.22-4_amd64.deb 9df61137845a90f7748096f2f0da3214dbbfecff838e69c65588c6ee5e767c9c 899020 ufraw-dbgsym_0.22-4_amd64.deb 9f70f6ca5726d3830bfd1771d6a1af5218f3cd675f004e2beaf805ca17dad41c 14086 ufraw_0.22-4_amd64.buildinfo 0041e26ce4e60dd70f321162a91ec14539c5fabdb8a71d51b9ab4ed9d2c7b246 617644 ufraw_0.22-4_amd64.deb Files: cc164bcc4a2cfb7f30e7b5ef156704d8 1619 graphics optional ufraw_0.22-4.dsc 68e9a7f9ab022789a1ffadf24b779026 9048 graphics optional ufraw_0.22-4.debian.tar.xz 323d8d4d5d86bfaf0ad14056281f121c 877528 debug optional gimp-ufraw-dbgsym_0.22-4_amd64.deb 4162a1e52317c1a37a4cedd2dcaf479e 488452 graphics optional gimp-ufraw_0.22-4_amd64.deb 0e1632eb3a17ca93f45cd5d33e9b5fb9 658636 debug optional ufraw-batch-dbgsym_0.22-4_amd64.deb 33b15bf22dbff804661c95c7d5a67d14 395404 graphics optional ufraw-batch_0.22-4_amd64.deb 062a513b3623e8dbf328766103a0189c 899020 debug optional ufraw-dbgsym_0.22-4_amd64.deb 19fdb6004dc0038581085f32e8fe838d 14086 graphics optional ufraw_0.22-4_amd64.buildinfo f20988d19fba58629296c6b40fe0c2e0 617644 graphics optional ufraw_0.22-4_amd64.deb -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEE3juhvb4UN2X4rCw4rXmvZUDjNa8FAlw3oTkACgkQrXmvZUDj Na/XbggAilj8NuroYZe3FD6dq1CQKMX//0beS6d2Y8YquHb7DMfJ9VIFklUNvj4A ERkZGjYLZvYVlsqTBAILvcEcW1PdP+z8JLqlUJMyRfgZ781jquGaCB2CZN/Z264F 0E6ytC7RFNB254nW8vs44u8XvYeqbe8DrCzhyRwMnUFk7YLRp3c07VwwsFJ/tLBS meWgV+a0DodlCNIYFdCxwENLThq7oDLIyjl3uOstRT7TT2j+BsQA147TRntE2/N9 Y+MMSQr+8rTmzqCNwQjefGlBjSd/q2gQ2hMbMV3ZCRxps0tNJ/xXInMZFy+Y77TP HgK2YjDUbl2JkMScFk2lF6J1J5vFOQ== =GI2e -----END PGP SIGNATURE-----
--- End Message ---
