Your message dated Sat, 12 Jan 2019 14:48:35 +0000
with message-id <[email protected]>
and subject line Bug#918725: fixed in grafx2 2.6-1
has caused the Debian Bug report #918725,
regarding grafx2 FTCBFS: hard codes the build architecture pkg-config
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
918725: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=918725
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: grafx2
Version: 2.5+git20181211-1
Tags: patch upstream
User: [email protected]
Usertags: rebootstrap
grafx2 fails to cross build from source, because src/Makefile hard codes
plain pkg-config. For cross compilation, we need to use a
triplet-prefixed pkg-config and dh_auto_build substitutes that.
Therefore making pkg-config substitutable is sufficient for making
grafx2 cross buildable. Please consider applying the attached patch.
Helmut
--- grafx2-2.5+git20181211.orig/src/Makefile
+++ grafx2-2.5+git20181211/src/Makefile
@@ -90,6 +90,7 @@
ifeq (default,$(origin CC))
CC = gcc
endif
+PKG_CONFIG ?= pkg-config
# There is no uname under windows, but we can guess we are there with the COMSPEC env.var
# Windows specific
@@ -191,14 +192,14 @@
SDLCOPT = $(shell sdl-config --cflags)
ifeq ($(OSX_STATIC), 1)
SDLLOPT = $(shell sdl-config --static-libs | sed 's/-lSDL //' | sed 's/-lX[^ ]*//g' | sed 's/-L[^ ]*//g')
- SDLLIBDIR = $(shell pkg-config --variable=libdir SDL_image)
+ SDLLIBDIR = $(shell $(PKG_CONFIG) --variable=libdir SDL_image)
#SDLLOPT += $(SDLLIBDIR)/libSDL.a
SDLLOPT += $(addsuffix .a, $(shell ../tools/osx_find_dependencies.sh $(SDLLIBDIR)/libSDL_image.dylib $(SDLLIBDIR)/libSDL_ttf.dylib | grep -v SDL | cut -d'.' -f 1))
SDLLOPT += $(SDLLIBDIR)/libSDL_image.a
TTFLOPT =
- SDLLOPT += $(shell pkg-config --variable=libdir SDL_ttf)/libSDL_ttf.a
+ SDLLOPT += $(shell $(PKG_CONFIG) --variable=libdir SDL_ttf)/libSDL_ttf.a
else
- SDLLOPT = $(shell sdl-config --libs) $(shell pkg-config --libs SDL_image)
+ SDLLOPT = $(shell sdl-config --libs) $(shell $(PKG_CONFIG) --libs SDL_image)
endif
else
# these are for use with Mac OS X native frameworks
@@ -209,32 +210,32 @@
endif
ifeq ($(API),sdl2)
SDLCOPT = $(shell sdl2-config --cflags)
- #TTFCOPT = $(shell pkg-config --cflags SDL2_ttf)
+ #TTFCOPT = $(shell $(PKG_CONFIG) --cflags SDL2_ttf)
ifeq ($(OSX_STATIC), 1)
SDLLOPT = $(shell sdl2-config --static-libs | sed 's/-lSDL2//' | sed 's/-L[^ ]*//')
- SDLLIBDIR = $(shell pkg-config --variable=libdir SDL2_image)
+ SDLLIBDIR = $(shell $(PKG_CONFIG) --variable=libdir SDL2_image)
SDLLOPT += $(SDLLIBDIR)/libSDL2.a
# trick to get all dependencies
SDLLOPT += $(addsuffix .a, $(shell ../tools/osx_find_dependencies.sh $(SDLLIBDIR)/libSDL2_image.dylib $(SDLLIBDIR)/libSDL2_ttf.dylib | grep -v SDL2 | cut -d'.' -f 1))
SDLLOPT += $(SDLLIBDIR)/libSDL2_image.a
TTFLOPT =
- SDLLOPT += $(shell pkg-config --variable=libdir SDL2_ttf)/libSDL2_ttf.a
+ SDLLOPT += $(shell $(PKG_CONFIG) --variable=libdir SDL2_ttf)/libSDL2_ttf.a
else
- SDLLOPT = $(shell sdl2-config --libs) $(shell pkg-config --libs SDL2_image)
+ SDLLOPT = $(shell sdl2-config --libs) $(shell $(PKG_CONFIG) --libs SDL2_image)
SDLLOPT += -Wl,-framework,Cocoa
- TTFLOPT = $(shell pkg-config --libs SDL2_ttf)
+ TTFLOPT = $(shell $(PKG_CONFIG) --libs SDL2_ttf)
endif
endif
# these are for use with macports
- LUAPKG := $(shell for p in lua lua5.3 lua-5.3 lua53 lua5.2 lua-5.2 lua52 lua5.1 lua-5.1 lua51 ; do pkg-config --exists $$p && echo $$p && break ; done)
+ LUAPKG := $(shell for p in lua lua5.3 lua-5.3 lua53 lua5.2 lua-5.2 lua52 lua5.1 lua-5.1 lua51 ; do $(PKG_CONFIG) --exists $$p && echo $$p && break ; done)
ifneq ($(LUAPKG), )
ifeq ($(OSX_STATIC),1)
- LUACOPT = $(shell pkg-config $(LUAPKG) --cflags | sed 's/-I/-idirafter/')
- LUALOPT = $(shell pkg-config $(LUAPKG) --variable=libdir)/liblua.a
+ LUACOPT = $(shell $(PKG_CONFIG) $(LUAPKG) --cflags | sed 's/-I/-idirafter/')
+ LUALOPT = $(shell $(PKG_CONFIG) $(LUAPKG) --variable=libdir)/liblua.a
else
- LUACOPT = $(shell pkg-config $(LUAPKG) --cflags)
- LUALOPT = $(shell pkg-config $(LUAPKG) --libs)
+ LUACOPT = $(shell $(PKG_CONFIG) $(LUAPKG) --cflags)
+ LUALOPT = $(shell $(PKG_CONFIG) $(LUAPKG) --libs)
endif
else
# these are for use with Mac OS X native frameworks
@@ -342,8 +343,8 @@
LUALOPT =
else
LUAPKG=lua
- LUACOPT = -D__ENABLE_LUA__ $(shell pkg-config $(LUAPKG) --cflags)
- LUALOPT = $(shell pkg-config $(LUAPKG) --libs)
+ LUACOPT = -D__ENABLE_LUA__ $(shell $(PKG_CONFIG) $(LUAPKG) --cflags)
+ LUALOPT = $(shell $(PKG_CONFIG) $(LUAPKG) --libs)
endif
COPT = -W -Wall -g $(shell sdl-config --cflags) $(TTFCOPT) -I/boot/common/include $(LUACOPT)
COPT += -DENABLE_FILENAMES_ICONV
@@ -436,9 +437,9 @@
ifdef WIN32CROSS
LUACOPT = -I../3rdparty/usr/include
else
- LUAPKG := $(shell for p in lua5.3 lua-5.3 lua53 lua5.2 lua-5.2 lua52 lua5.1 lua-5.1 lua51 lua ; do pkg-config --exists $$p && echo $$p && break ; done)
- LUACOPT = $(shell pkg-config $(LUAPKG) --cflags)
- LUALOPT = $(shell pkg-config $(LUAPKG) --libs)
+ LUAPKG := $(shell for p in lua5.3 lua-5.3 lua53 lua5.2 lua-5.2 lua52 lua5.1 lua-5.1 lua51 lua ; do $(PKG_CONFIG) --exists $$p && echo $$p && break ; done)
+ LUACOPT = $(shell $(PKG_CONFIG) $(LUAPKG) --cflags)
+ LUALOPT = $(shell $(PKG_CONFIG) $(LUAPKG) --libs)
endif
endif
endif
@@ -447,7 +448,7 @@
ifdef WIN32CROSS
#cross compile a Win32 executable
CROSS_CC ?= $(shell which i686-w64-mingw32-gcc || which mingw32-gcc)
- CROSS_PKGCONFIG ?= $(shell which i686-w64-mingw32-pkg-config || which mingw32-pkg-config || which pkg-config)
+ CROSS_PKGCONFIG ?= $(shell which i686-w64-mingw32-pkg-config || which mingw32-pkg-config || which $(PKG_CONFIG))
CROSS_SDLCONFIG ?= $(shell which ../3rdparty/usr/bin/sdl-config || which /usr/local/cross-tools/i386-mingw32/bin/sdl-config)
CROSS_PKG_CONFIG_PATH ?= $(shell if [ -d ../3rdparty/usr ] ; then echo "$${PWD}/../3rdparty/usr/lib/pkgconfig" ; fi )
CC = $(CROSS_CC)
@@ -547,7 +548,7 @@
COPT += $(shell sdl2-config --cflags)
endif
COPT += $(TTFCOPT) $(LUACOPT) $(JOYCOPT) -O$(OPTIM)
- COPT += $(shell pkg-config --cflags libpng)
+ COPT += $(shell $(PKG_CONFIG) --cflags libpng)
ifneq ($(PLATFORM), FreeBSD)
COPT += -D_XOPEN_SOURCE=700
@@ -561,22 +562,22 @@
ifeq ($(API),sdl)
LOPT += $(shell sdl-config --libs) -lSDL_image
ifneq ($(NO_X11),1)
- LOPT += $(shell pkg-config --libs x11)
- COPT += $(shell pkg-config --cflags x11)
+ LOPT += $(shell $(PKG_CONFIG) --libs x11)
+ COPT += $(shell $(PKG_CONFIG) --cflags x11)
endif
endif
ifeq ($(API),sdl2)
LOPT += $(shell sdl2-config --libs) -lSDL2_image
ifneq ($(NO_X11),1)
- LOPT += $(shell pkg-config --libs x11)
- COPT += $(shell pkg-config --cflags x11)
+ LOPT += $(shell $(PKG_CONFIG) --libs x11)
+ COPT += $(shell $(PKG_CONFIG) --cflags x11)
endif
endif
ifeq ($(NO_X11),1)
COPT += -DNO_X11
endif
LOPT += $(TTFLOPT)
- LOPT += $(shell pkg-config --libs libpng)
+ LOPT += $(shell $(PKG_CONFIG) --libs libpng)
LOPT += $(LUALOPT)
OBJDIR = ../obj/unix
FCLOPT = -lfontconfig
--- End Message ---
--- Begin Message ---
Source: grafx2
Source-Version: 2.6-1
We believe that the bug you reported is fixed in the latest version of
grafx2, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Gürkan Myczko <[email protected]> (supplier of updated grafx2 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 10 Jan 2019 16:51:38 +0100
Source: grafx2
Binary: grafx2
Architecture: source
Version: 2.6-1
Distribution: unstable
Urgency: medium
Maintainer: Gürkan Myczko <[email protected]>
Changed-By: Gürkan Myczko <[email protected]>
Description:
grafx2 - ultimate 256-color bitmap paint program
Closes: 918725
Changes:
grafx2 (2.6-1) unstable; urgency=medium
.
* New upstream version. (Closes: #918725)
* debian/control: add libtiff-dev.
Checksums-Sha1:
a566e21c315ee80c431105e12ad4ff32373c1206 1835 grafx2_2.6-1.dsc
0748749c7d07e1c6ebc1fecd9e06b07505a732f4 1241679 grafx2_2.6.orig.tar.gz
dc698192a53da8ff0b5b4281773bcd25151db4e7 4212 grafx2_2.6-1.debian.tar.xz
d34bb8e171f3eed034ceec0cab762697b4bd4e35 10882 grafx2_2.6-1_source.buildinfo
Checksums-Sha256:
24faecf45fb338d773ba8f6a23f309689d38ff3063eca2f3bf5d57012b66b19f 1835
grafx2_2.6-1.dsc
78b8b24dc3726fc936381c98d0179e2bd131811c411a565bb55f24be1d93cb7c 1241679
grafx2_2.6.orig.tar.gz
f553313f9451516323363ee0305967abd6a407e284dab860336192707cc6ef20 4212
grafx2_2.6-1.debian.tar.xz
0d9d9989489d4fff470c5b67e40712c90a699ff8565452bb0226426a19d222c0 10882
grafx2_2.6-1_source.buildinfo
Files:
1bb46d7eb8ecdc1143f21ad3f24993c7 1835 graphics optional grafx2_2.6-1.dsc
83f3bdfe4c67979451688dace6b17d22 1241679 graphics optional
grafx2_2.6.orig.tar.gz
def8c9f8ebb036fbd78d2df32ad0fc14 4212 graphics optional
grafx2_2.6-1.debian.tar.xz
f9dbe97a4c8b44ae67f993c1a8ac2dac 10882 graphics optional
grafx2_2.6-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEE8f9dDX4ALfD+VfsMplt42+Z8eqwFAlw57LoACgkQplt42+Z8
eqx6/A//WBjaEcYjuVhztsJDDsPB0hgkn0yeu81/y4CrLkBwOo9N1dDEAtwxmPZ8
6/EOvmCXRSwKTReQJCyB1QQbFvHTNSkIwvEtxSBCC+uWKI4Y6BtKEpmQWbaVCxtQ
kRwFf1umMZ4c29wZ4FK1sgI8inhmEzyXswVKmIVekKUALjplHgyXdEWSJ2rMQ5Z9
XGVm4AVwQrsqr9dtUabsClNGZV9olmEuUH54XepRxVrYmGj6JvJtciy5DRw75TXq
KShDBv5rqtrP1oQsWfgJG+8Ngp21N3cQGZNjvROd2iZtBVyE+5lnIi9pUIVTJp0n
bQbmTYluTo0Wkuw3F/j4HI9qqC9hUmUYp7BWQ9XDjwjC9wm64X+OphRxzGKxA4dB
dqzSlmMSMfcoxY/MesJbJsOdHwNhKuzBDbs4cyqCOm8VILl5ZZq7Uum9yNKecbrJ
6xXw/Wq8CnNXGIVTZM4T3zQ5AX0TY2W4LyACe91vHGZ7MFwuy1o7VxpdQKh9jaEj
YxRCTObtvxPVcsvaEExLJfWpjvnhCwzY68TzGYlhqcwA0slzrGZ7t7/SS2x3/nMD
ODdAWZ/XgTrTVmNSu+2rCTwPSfk/fTs3ccNrt+elFl45k0Aft4CaQZ8/joJ6WX4Q
yZTjEaciMF4NxueSHFv4xBAG5aK5++RkR+T4TgKw7VQQ4wJoJZo=
=EGix
-----END PGP SIGNATURE-----
--- End Message ---
