Your message dated Tue, 15 Jan 2019 14:53:38 +0100
with message-id <[email protected]>
and subject line fixed 906245 1.5-15
has caused the Debian Bug report #906245,
regarding /etc/network/if-pre-up.d/bridge can fail to properly create vlan
bridge ports
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
906245: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=906245
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: bridge-utils
Version: 1.5-13+deb9u1
/etc/network/if-pre-up.d/bridge can fail to properly create vlan bridge
ports
/lib/bridge-utils/bridge-utils.sh has a create_vlan_port function that
tests if the vlan interface already exists
If it does not, it creates it, if it does exist it does nothing.
The problem is that it check to see if the interface exists with:
grep -q "$port:" /proc/net/dev
port is the interface name like "eth0.99"
but the period in a VLAN name is actually treated as a regex so if you have
a
br-eth0-99 interface or eth0199 then it thinks eth0.99 is already up and
fails to create it because those names match the "eth0.99" regex
And improvement would just be
grep -q -F "$port"
That could still fail for br-eth0.99
or even something that looks for the beginning of the line (and whitespace)
grep -q -F "^\s*$port"
I haven't tried, there may be a simpler more reliable solution like:
if ip address show dev $port >/dev/null 2>&1 ...
--- End Message ---
--- Begin Message ---
fixed 906245 1.5-15
quit
This problem is like the one described on #873087 which was already fixed on
version 1.5-15
Regards.
--
Manty/BestiaTester -> http://manty.net
--- End Message ---
