Your message dated Sun, 27 Jan 2019 22:04:21 +0000
with message-id <e1gnsxn-0003mj...@fasolo.debian.org>
and subject line Bug#349065: fixed in indent 2.2.12-1
has caused the Debian Bug report #349065,
regarding indent: adds extra const keywords to C++ programs
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
349065: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=349065
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: indent
Version: 2.2.10-1
Severity: normal

Steps to reproduce:
1) cat > svg.cc <<EOF
void Svg::write(std::ostream &st, const Graph &g) const { }
EOF
2) indent -o svg.cc.indent svg.cc

Expected results:
2) svg.cc.indent and svg.cc differ only in whitespace

Actual results:
2) svg.cc.indent has extra const keyword:

void
Svg::write (std::ostream & st, const Graph & g) const const
{
}


More info:
1) If I run indent again to the output file it adds yet another const
keyword. This means that indent is not idempotent and can not be used
to check whether a file already has correct indentation or not.
2) The bug also occurs with indent 2.2.9-7 in debian stable.
3) It seems that the first const is written by handle_token_decl() and
the second const is written by copy_id():


case decl:
    /* we have a declaration type (int, register, etc.) */

    handle_token_decl(dec_ind, file_exit_value,
                      pbreak_line);

    copy_id(type_code, force_nl, file_exit_value, can_break);

Maybe this could be fixed by just not writing const from
handle_token_decl?



--- End Message ---
--- Begin Message ---
Source: indent
Source-Version: 2.2.12-1

We believe that the bug you reported is fixed in the latest version of
indent, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 349...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Santiago Vila <sanv...@debian.org> (supplier of updated indent package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 27 Jan 2019 22:35:20 +0100
Source: indent
Architecture: source
Version: 2.2.12-1
Distribution: unstable
Urgency: low
Maintainer: Santiago Vila <sanv...@debian.org>
Changed-By: Santiago Vila <sanv...@debian.org>
Closes: 228112 349065 487517 657461 726105 865677 916199
Changes:
 indent (2.2.12-1) unstable; urgency=low
 .
   * New upstream release. Closes: #916199.
     This is now maintained upstream by Andrej Shadura.
   * Drop all debian/patches/*, not required anymore.
   * Should fix '*' in function declaration. Closes: #228112.
   * Should fix double const after C++ function declaration. Closes: #349065.
   * Should improve support for gettext macros. Closes: #487517.
   * New option --fix-nested-comments. Closes: #657461.
   * Should not change !! to ! ! anymore when using -linux. Closes: #726105.
   * Should now cross-build. Closes: #865677.
   * Rules-Requires-Root: no.
Checksums-Sha1:
 36783e19c275da879687c9f2d8844c4d57402f64 1390 indent_2.2.12-1.dsc
 eecb3d7e78516d846af70e7bc86aabac9b92399c 620280 indent_2.2.12.orig.tar.xz
 d280f8b35975b8df52cd391411559234b5b97de7 5948 indent_2.2.12-1.debian.tar.xz
 9ae2b38a123edf27551aa324e0c184acab82ea84 4896 indent_2.2.12-1_source.buildinfo
Checksums-Sha256:
 e802796b98203d047d819685801bd970b20a6525836b35c5a9fd119eb7cf176d 1390 
indent_2.2.12-1.dsc
 b745a5dfc68f86a483d7f96dc1cda7aafd1e78ecba3c7d8ad304709e91e1defb 620280 
indent_2.2.12.orig.tar.xz
 d3ac4770ff8a0de2497a44c2a2d3e57521efb748620793bf531499565c50c5ea 5948 
indent_2.2.12-1.debian.tar.xz
 d62fde0178001f6517549001f78abba0c64d9a4c2bede1056b123610c9ed529e 4896 
indent_2.2.12-1_source.buildinfo
Files:
 235cbcac6f3c8e67d8c2ddf55ee33a3e 1390 devel optional indent_2.2.12-1.dsc
 9cba859a8b1958baa2e3dce1dadb37db 620280 devel optional 
indent_2.2.12.orig.tar.xz
 85039d044a9c085d5a506ff9ad66dd74 5948 devel optional 
indent_2.2.12-1.debian.tar.xz
 aa435f822003c88ec252181c36d9a3af 4896 devel optional 
indent_2.2.12-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEE1Uw7+v+wQt44LaXXQc5/C58bizIFAlxOKC4ACgkQQc5/C58b
izL00wf/Zm/3/RhTtw5rZ6s+9YDbDRoqBmbY2v1a06rWF0+rFRLHpGm1mKgwKwOf
/VNSkobY+7a/SNda/rzWgHdDT+ekcAXh4VBc3UiG51BNOl9RTjauupDgLnccEVUt
mepPmLP2btWupN1mSAaHy1HIySV3miQbQYFMLo9/QlcO3eVu7ZPpFP5jy76iLqLT
pUYIDuw/4MCoUcAun//CF/KHshpONhCi1nx5Pa9rFsEidtlH1QIPalQUmvgvbnpQ
kqVLrcPR9TnpCPIniySTrfeAu53I3LSUkAgFtH9P2QHIQgMRCJSwEfCox3ZROaEL
x0lVS45qFVrvIqoPBXjVU3c1yXBVBQ==
=lz9b
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to