Your message dated Fri, 01 Mar 2019 05:22:25 +0000 with message-id <[email protected]> and subject line Bug#923379: fixed in u-boot 2019.01+dfsg-3 has caused the Debian Bug report #923379, regarding u-boot: Dreamplug fails to detect SPI and USB to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 923379: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=923379 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: u-boot Version: 2019.01+dfsg-1 Severity: important Tags: upstream Dear Maintainer, I flashed u-boot 2019.01+dfsg-1 on my Dreamplug. I found that u-boot was unable to detect the SPI flash on the device (and thus could not read the u-boot environment). It could also not detect the usb storage. On booting, the following output is observed: ------------8<------------ U-Boot 2019.01+dfsg-1 (Jan 15 2019 - 00:36:19 +0000) Marvell-DreamPlug oC: Kirkwood 88F6281_A1 DRAM: 512 MiB Loading Environment from SPI Flash... Invalid bus 0 (err=-19) *** Warning - spi_flash_probe_bus_cs() failed, using default environment In: serial Out: serial Err: serial Net: egiga0 Error: egiga0 address not set. , egiga1 Error: egiga1 address not set. 88E1116 Initialized on egiga0 88E1116 Initialized on egiga1 IDE: ide_preinit failed Hit any key to stop autoboot: 0 => usb start starting USB... USB0: USB EHCI 1.00 scanning bus 0 for devices... EHCI timed out on TD - token=0x80008d80 EHCI timed out on TD - token=0x80008c80 EHCI timed out on TD - token=0x80008c80 EHCI timed out on TD - token=0x80008c80 ERROR: NOT USB_CONFIG_DESC a3 EHCI timed out on TD - token=0x80008d80 EHCI timed out on TD - token=0x80008c80 EHCI timed out on TD - token=0x80008c80 2 USB Device(s) found scanning usb for storage devices... 0 Storage Device(s) found ------------8<------------ I then compiled u-boot from the upstream git tree and tried various versions. The results are as follows: v2018.01 all works v2018.07 all works v2018.09 all works v2018.11 USB fails v2019.01 SPI flash fails, USB fails I then bisected both issues. The USB issue was caused by the following commit: commit 93b283d49f933f95f3a6f40762936f454ac655a8 Author: Adam Ford <[email protected]> Date: Thu Aug 16 13:23:11 2018 -0500 ARM: CPU: arm926ejs: Consolidate cache routines to common file Four different boards had different options for enabling cache that were virtually all the same. This consolidates these common functions into arch/arm/cpu/arm926ejs/cache.c This also has the positive side-effect of enabling cache on the Davinci (da850) boards. Signed-off-by: Adam Ford <[email protected]> [trini: Add mach-at91 to the list of consolidations] Signed-off-by: Tom Rini <[email protected]> I used the following patch to temporarily fix up the issue (I am no expert on ARM so cannot say whether this is in any way correct): iff --git a/arch/arm/mach-kirkwood/cpu.c b/arch/arm/mach-kirkwood/cpu.c index d54de53f31..8a065d73ae 100644 --- a/arch/arm/mach-kirkwood/cpu.c +++ b/arch/arm/mach-kirkwood/cpu.c @@ -291,7 +291,6 @@ int arch_misc_init(void) temp |= (1 << 22); writefr_extra_feature_reg(temp); - icache_enable(); /* Change reset vector to address 0x0 */ temp = get_cr(); set_cr(temp & ~CR_V); diff --git a/include/configs/dreamplug.h b/include/configs/dreamplug.h index f4d717213c..6348935c68 100644 --- a/include/configs/dreamplug.h +++ b/include/configs/dreamplug.h @@ -79,4 +79,6 @@ #define CONFIG_SYS_ATA_IDE0_OFFSET MV_SATA_PORT0_OFFSET #endif /*CONFIG_MVSATA_IDE*/ +#define CONFIG_SYS_DCACHE_OFF + #endif /* _CONFIG_DREAMPLUG_H */ I then bisected the SPI flash issue, and found it was caused by the following commit: commit 6aaf76beb131c2ff2b7184c2d63c2c63e5ab339c Author: Chris Packham <[email protected]> Date: Wed Nov 21 22:22:23 2018 +1300 arm: kirkwood: configs: dreamplug: Convert to DM_SPI Enable CONFIG_DM_SPI=y and CONFIG_DM_SPI_FLASH=y in the defconfig. Signed-off-by: Chris Packham <[email protected]> Reviewed-by: Stefan Roese <[email protected]> Signed-off-by: Stefan Roese <[email protected]> I don't know enough about u-boot to easily diagnose this issue. -- System Information: Debian Release: buster/sid APT prefers testing APT policy: (500, 'testing') Architecture: armel (armv5tel) Kernel: Linux 4.19.7+ Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: sysvinit (via /sbin/init) -- no debconf information
--- End Message ---
--- Begin Message ---Source: u-boot Source-Version: 2019.01+dfsg-3 We believe that the bug you reported is fixed in the latest version of u-boot, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Vagrant Cascadian <[email protected]> (supplier of updated u-boot package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Thu, 28 Feb 2019 20:42:31 -0800 Source: u-boot Architecture: source Version: 2019.01+dfsg-3 Distribution: unstable Urgency: medium Maintainer: Vagrant Cascadian <[email protected]> Changed-By: Vagrant Cascadian <[email protected]> Closes: 923379 923443 Changes: u-boot (2019.01+dfsg-3) unstable; urgency=medium . [ Romain Perier ] * [armel] u-boot-rpi: Add Raspberry Pi Zero W. . [ Vagrant Cascadian ] * [armhf] u-boot-sunxi: Add bananapi_m2_berry target. (Closes: #923443) Thanks to Lucas Nussbaum. * [armhf] u-boot-imx: Add novena-rawsd target. * Add patches to fix SPI and USB on Dreamplug (Closes: #923379). Thanks to Leigh Brown and Chris Packham. * u-boot-tools: Remove Synopsys lintian override. * Add patch to fix spelling of "mismatched". * Add patch to fix spelling of "download". Checksums-Sha1: 4b5d81a5ca83fb0879086ea55dc9140a9d9ed25b 2392 u-boot_2019.01+dfsg-3.dsc 739c9280d930d9cbb42b83da7e9edbf5714403cc 40228 u-boot_2019.01+dfsg-3.debian.tar.xz f16d83fe55d5de238b00dcada1ce8bd942e1e3ab 5070 u-boot_2019.01+dfsg-3_amd64.buildinfo Checksums-Sha256: 49862a684c3122a2d3e27fbe64a07b79d43d1fe2576a13a5eaeaafd9b90b2972 2392 u-boot_2019.01+dfsg-3.dsc ac11ac9cb0cee83135faec643bf89834fd42ae0e081f56e9e21bee1172a4b046 40228 u-boot_2019.01+dfsg-3.debian.tar.xz b03873225294bf057dba98705dc1ee34763e9df1627a390100bcb090e6a91e45 5070 u-boot_2019.01+dfsg-3_amd64.buildinfo Files: 7df6acf84853be89126cc15fa216f054 2392 admin optional u-boot_2019.01+dfsg-3.dsc 8ca2b7417f823c1e6d4e2a1a69385fba 40228 admin optional u-boot_2019.01+dfsg-3.debian.tar.xz 81fc4d342c28891cbe7ee4fcde3f1101 5070 admin optional u-boot_2019.01+dfsg-3_amd64.buildinfo -----BEGIN PGP SIGNATURE----- iIkEARYKADEWIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCXHi5aBMcdmFncmFudEBk ZWJpYW4ub3JnAAoJENxRj8h/lxaqzNkBAOTnrSHqFTaE4pFxXoOfU3KqUmkiishC mwMdbGByLxH3AP9o1mi2VjnBNjdGbXNsG4M6IC8SdXW5SfpNDPTOYDGVDQ== =WLa5 -----END PGP SIGNATURE-----
--- End Message ---
