Your message dated Sun, 31 Mar 2019 22:48:59 +0000
with message-id <[email protected]>
and subject line Bug#919789: fixed in rspamd 1.9.0-1
has caused the Debian Bug report #919789,
regarding rspamd: log rotation fails if using systemd
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
919789: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=919789
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: rspamd
Version: 1.8.1-2+b2
Severity: normal
Tags: patch

Dear Maintainer,

The logrotate script /etc/logrotate.d/rspamd makes the log rotate and then:
    service rspamd reopenlog >/dev/null 2>&1 || true

Unfortunately, for the non-standard action reopenlog, /usr/sbin/service uses
the SysVinit script which does:
    start-stop-daemon --stop --signal 10 --quiet --pidfile $PIDFILE

If I do this, I get:
    $ sudo start-stop-daemon --stop --signal 10 --pidfile /run/rspamd/rspamd.pid
    No process in pidfile '/run/rspamd/rspamd.pid' found running; none killed.

And rspamd continues to write to the rotated logfile
/var/log/rspamd/rspamd.log.1 .

The following is one way to fix this. Another way would be to update the systemd
service file to create a PID file.

--- rspamd-1.8.1/debian/rspamd.logrotate        2018-11-10 22:58:51.000000000 
+0100
+++ rspamd-1.8.1.new/debian/rspamd.logrotate    2019-01-19 17:18:17.693282920 
+0100
@@ -6,7 +6,7 @@
        notifempty
        missingok
        postrotate
-          service rspamd reopenlog >/dev/null 2>&1 || true
+          systemctl kill --signal=SIGUSR1 rspamd >/dev/null 2>&1 \
+             || service rspamd reopenlog >/dev/null 2>&1 || true
        endscript
 }


Thanks,

Alex

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8), 
LANGUAGE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages rspamd depends on:
ii  adduser          3.118
ii  ca-certificates  20180409
ii  libc6            2.28-5
ii  libevent-2.1-6   2.1.8-stable-4
ii  libglib2.0-0     2.58.2-4
ii  libicu63         63.1-5
pn  libjemalloc2     <none>
ii  libjs-bootstrap  3.4.0+dfsg-1
pn  libjs-d3         <none>
ii  libjs-jquery     3.2.1-1
pn  libjs-requirejs  <none>
pn  libluajit-5.1-2  <none>
ii  libmagic1        1:5.35-2
ii  libpcre2-8-0     10.32-3
ii  libsqlite3-0     3.26.0+fossilbc891ac6b-1
ii  libssl1.1        1.1.1a-1
ii  libunwind8       1.2.1-8
ii  lsb-base         10.2018112800
ii  zlib1g           1:1.2.11.dfsg-1

rspamd recommends no packages.

rspamd suggests no packages.

--- End Message ---
--- Begin Message ---
Source: rspamd
Source-Version: 1.9.0-1

We believe that the bug you reported is fixed in the latest version of
rspamd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sebastien Badia <[email protected]> (supplier of updated rspamd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 01 Apr 2019 00:32:39 +0200
Source: rspamd
Architecture: source
Version: 1.9.0-1
Distribution: experimental
Urgency: medium
Maintainer: Sebastien Badia <[email protected]>
Changed-By: Sebastien Badia <[email protected]>
Closes: 914477 919789
Changes:
 rspamd (1.9.0-1) experimental; urgency=medium
 .
   * New upstream version 1.9.0
   * d/rules: Slashing: Distinguish lualibdir, pluginsdir and sharedir
   * d/logrotate: Fix log rotation if SystemD is used (Closes: #919789)
                  Thanks Alexandre !
   * d/tests: Ugly-patch for flaky tests… (Closes: #914477)
   * d/copyright: Added Jerome and I on debian/*
Checksums-Sha1:
 6a3ce3350ccaf650d942c02fc7a291a6e5acd731 2233 rspamd_1.9.0-1.dsc
 5f6e9e59aebc4f3eb92591d89b9ef3f9358ab303 3279940 rspamd_1.9.0.orig.tar.xz
 ac24f0264d46d4917e718ec91a46d83c6df59bc6 98060 rspamd_1.9.0-1.debian.tar.xz
 92d1ac3ffa19d1852b7c5162c1753c6704e51848 5372 rspamd_1.9.0-1_source.buildinfo
Checksums-Sha256:
 d40259683e14abdb04e4f8543c01d43dd22e0988a46d5dec777db023014b2ab4 2233 
rspamd_1.9.0-1.dsc
 9b505e6a0229c85a36033cd30986d1ed0c0399e0ffc9b6bff839f091cf8254d4 3279940 
rspamd_1.9.0.orig.tar.xz
 071ca80e78d2498245b526063c07c7b3c332faf0c7c2958395a4a06a3747779e 98060 
rspamd_1.9.0-1.debian.tar.xz
 eb902a6245669806f8292080d475d6871e4ff3197a533c4efc6dff1807b711a6 5372 
rspamd_1.9.0-1_source.buildinfo
Files:
 4ee24ff4a65cba7d6f48ff7f79e51e17 2233 mail optional rspamd_1.9.0-1.dsc
 007aea477e9efe84f9b044fe582e53c4 3279940 mail optional rspamd_1.9.0.orig.tar.xz
 566931f9d7b95d5004e8128960d7d23c 98060 mail optional 
rspamd_1.9.0-1.debian.tar.xz
 47640f33cb54547aea0ded5a35aa582a 5372 mail optional 
rspamd_1.9.0-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfkPprL9yerPPCIUzhxbORhSkUtgFAlyhQMkACgkQhxbORhSk
UtisUA//Ub65vHve8AG9yhz4qUH0B/x+kJD84PsQGmegFdCUcTe4660ZlJkRrkQy
jatDcrVaaObyaVryZGQIUdlK+k5THHnUHTXGcTfiV2c13IQ+LYQ39ja+lwcvs65I
iab5jOHoWWpsOlPqaY40tlGiziqTSos9NDcjMGSVD9jTOKHLbgEZL192Av0E4dNq
og/oWttKasyLI/kGdUgO4b0Ci1vxmAORE7gBUOaut2W1Eg8WUUVfcnniJzwzTdU4
7RWfqBbKclUZKDIPvooe2QWnTiS/jNie8I7Xp9DMcAoB4TP3Q0XTK05jOfJxypxT
wns7m+FkCkP63xiqLf1d+lRQXOsUMF5iyJnsEbiT+HaZ7YZ8RN+TiC1aOATAkUId
sq9FpGLxoD/3/i1SmXy2vQfH2SO5WOpzvWE34s575GZXusyKUTXe9vMWwcD7fIq9
JvokSkLiw8N+Rx8PzDkvhqcYi/gcBNJkZIhvicLZUGBmc06n8QRcCqy4R+kvmMKr
n3DMyWA2kBaNTYG+jsM2ljledlURP4x+wl/Hy8TLKAk19aVFqE2+Nz8C5LvsiTkY
ZqVHWH7OuGJlq2rp2T+x2YUD8VeNbBAF6Inif1JnbVp9b3VxdVdxRpBIgyPt7SqK
5ddyV8dwNQN7Q3Ir8CeUAyuCnkP8jsSPFKGomaNoDy99FvQvUdo=
=fc5N
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to