Your message dated Mon, 08 Apr 2019 17:04:02 +0000
with message-id <[email protected]>
and subject line Bug#924688: fixed in runit 2.1.2-28
has caused the Debian Bug report #924688,
regarding runit: Supervise path not consistent with dh-runit
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
924688: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=924688
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: runit
Version: 2.1.2-25helpers1
Severity: normal
Tags: patch

Hi,

I've just find out about #919296, so I realised that runit's update-service
(used in git-daemon maint scripts) is using a different path for supervise
directory.
In the attached patch i'm changing that path to be consistent with the one
used by dh-runit (both service and log).

But also I spot another difference:
a directory inside supervise created by dh-runit has mode 755 while the one
created by runsv (with update-service) has mode 700.
For example:
# ls -l /var/lib/supervise/ | grep elogind
drwx------ 2 root root 4096 Mar 15 19:11 elogind
drwx------ 2 root root 4096 Mar 15 19:11 elogind.log

# ls -l /var/lib/runit/supervise/ | grep getty-tty2
drwxr-xr-x 2 root root 4096 Mar 15 19:11 getty-tty2

With mode 755 both the pid file and the stat file are world readable..
Maybe mode 700 is safer?

Thanks,
Lorenzo


-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.20.3-van (SMP w/4 CPU cores; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: runit (via /run/runit.stopit)

Versions of packages runit depends on:
ii  libc6           2.28-8
ii  runit-helper    2.8.9
ii  sysuser-helper  1.3.3

Versions of packages runit recommends:
ii  runit-init  2.1.2-25helpers1

runit suggests no packages.

-- Configuration Files:
/etc/runit/3 changed [not included]

-- no debconf information
>From 365ed42d2e6840cd531d534bb94c27d12f7ee39d Mon Sep 17 00:00:00 2001
From: Lorenzo Puliti <[email protected]>
Date: Thu, 14 Mar 2019 22:29:41 +0100
Subject: [PATCH] Change the supervise path in update-service

Change the supervise directory path of update-service
to be consistent with the path used in dh-runit.
---
 debian/contrib/update-service | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/contrib/update-service b/debian/contrib/update-service
index 01d10da..7e72501 100644
--- a/debian/contrib/update-service
+++ b/debian/contrib/update-service
@@ -63,11 +63,11 @@ case "$opt" in
     if test "${svdir#/etc/}" != "$svdir"; then
       if test ! -h "$svdir"/supervise; then
         rm -rf "$svdir"/supervise
-        ln -s /var/lib/supervise/"$sv" "$svdir"/supervise
+        ln -s /var/lib/runit/supervise/"$sv" "$svdir"/supervise
       fi
       if test -d "$svdir"/log && test ! -h "$svdir"/log/supervise; then
         rm -rf "$svdir"/log/supervise
-        ln -s /var/lib/supervise/"$sv".log "$svdir"/log/supervise
+        ln -s /var/lib/runit/log/supervise/"$sv" "$svdir"/log/supervise
       fi
     fi
     ln -s "$svdir" "$servicedir"/"$sv"
-- 
2.20.1


--- End Message ---
--- Begin Message ---
Source: runit
Source-Version: 2.1.2-28

We believe that the bug you reported is fixed in the latest version of
runit, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dmitry Bogatov <[email protected]> (supplier of updated runit package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 08 Apr 2019 16:40:06 +0000
Source: runit
Architecture: source
Version: 2.1.2-28
Distribution: experimental
Urgency: medium
Maintainer: Dmitry Bogatov <[email protected]>
Changed-By: Dmitry Bogatov <[email protected]>
Closes: 924688 924768
Changes:
 runit (2.1.2-28) experimental; urgency=medium
 .
   * Change the supervise directory path of update-service to be consistent
     with the path used in dh-runit. (Closes: #924688)
   * Stop init.d script in invoke-run(5) (Closes: #924768)
Checksums-Sha1:
 2262ab9b2c221b211f316222a880f380bffa7909 2152 runit_2.1.2-28.dsc
 15408f2e54904328ae3624ce3e7f9899f073ec9e 29416 runit_2.1.2-28.debian.tar.xz
 a8e8361f84feac3c0ab32b87cb60e209acc770c4 5348 runit_2.1.2-28_source.buildinfo
Checksums-Sha256:
 4d37d4ec3e315793bb06cc08641119e33fb6bf0c9f5f226cbb7038b352c78ad6 2152 
runit_2.1.2-28.dsc
 084ff05aa0d74c3ed67e699c00083d6d2a22d684548feae49b226aa016ac505e 29416 
runit_2.1.2-28.debian.tar.xz
 87c719df408070c6b3a13b9e370b4404a9a86991f7f24410b13b7ba1d0e8e384 5348 
runit_2.1.2-28_source.buildinfo
Files:
 7d84a9c073ef652880191628ff819ddf 2152 admin optional runit_2.1.2-28.dsc
 73eef96903ccafd5b2dbdc913d2efa98 29416 admin optional 
runit_2.1.2-28.debian.tar.xz
 aefcbf6e9857bf04ece0da8e622d26ea 5348 admin optional 
runit_2.1.2-28_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJHBAEBCgAxFiEEhnHVzDbtdH7ktKj4SBLY3qgmEeYFAlyrepETHGthY3Rpb25A
ZGViaWFuLm9yZwAKCRBIEtjeqCYR5vJfD/4oaorRU4+V/D5lEXXs1vc0cjuWUaoY
BXSf/a5zvzOHjY/aq8TPtYHwi1cR9qxpL21reIZNJR9rli+qtsbxkraPmsp2IKNr
99x0zgwZgKUhdbzb9x8yh5l6UMbA7gsj5hGaxQg72TZ+89LH6kft1JVph8Jshndq
nrid+8u7ihGTOEhIcG9kTefXRPWVXmK2p4jRJMOR3xjt7lBByHuBf0JVpjHKmqTS
odQoT7U7mXVNSJAa2HSC+pkH2v9KDIFCzu81R3JVYNiek1nnIKhu9aWij6fQcBSl
a9jtUrmQ0YKjFcnZ7w/31ql/D3Q//AKkSh3Sweb1FjUFswbQF+6xKZFtaKTqp0R3
X4RFrADD+KCDVEDrqXyDeQfz7CRmt2b7HlBAed8vysMcmrRWlePKke+Bg4uxT+q7
UffSzYpSW9R6iDUyanXl+i6AL/yOAg7ICukZWsb0hVMVKNIYRJXGecx9F0SYJeob
tlbcVN+SsvFWzPm6EriihEi/ydRPo6n8GadCeAcDYAfAlnRyxKpMSB+x+wHtXSuZ
jNniGFrmoFRc/RiwxHub4mbLwCc0kQh864Lb4eMiFdvPst9Bze8vD3JSA1kvWj09
qC0+yucb6BDesj8Uog8tQC14Z4LgiyghZANdyhEgboP4wFui9Cl/UEb2lERgmyTA
qKHua+sNbzp2jQ==
=4F2B
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to