Your message dated Sat, 11 May 2019 20:35:07 +0000
with message-id <[email protected]>
and subject line Bug#928249: fixed in sysvinit 2.94-5
has caused the Debian Bug report #928249,
regarding sysv-rc: fix styling
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
928249: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=928249
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: sysvinit
Version: 2.94-2
Severity: wishlist
I hope to make running shellcheck part of `make test', and here is
little step in that direction. This patch fixes only suggestions, that
require no refactoring -- just more of double quotes.
Review is welcome.
From fe660a07d02f5ad46ec39924a5ab4354682a8fd0 Mon Sep 17 00:00:00 2001
From: Dmitry Bogatov <[email protected]>
Date: Mon, 29 Apr 2019 03:13:41 +0000
Subject: [PATCH] Fix style in /etc/init.d/rc script
Fix several style recommentations in /etc/init.d/rc script, suggested
by shellcheck(1).
---
debian/src/sysv-rc/rc | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/debian/src/sysv-rc/rc b/debian/src/sysv-rc/rc
index ed828cf5..025a1c54 100755
--- a/debian/src/sysv-rc/rc
+++ b/debian/src/sysv-rc/rc
@@ -38,7 +38,9 @@ stty onlcr 0>&1
# Now find out what the current and what the previous runlevel are.
+# shellcheck disable=SC2153 # this variable is set by /sbin/init
runlevel=$RUNLEVEL
+
# Get first argument. Set new runlevel to this argument.
[ "$1" != "" ] && runlevel=$1
if [ "$runlevel" = "" ]
@@ -117,16 +119,15 @@ case "$CONCURRENCY" in
startup() {
action=$1
shift
- scripts="$@"
- for script in $scripts ; do
- $debug "$script" $action
+ for script ; do
+ "$script" "$action"
done
}
;;
esac
# Is there an rc directory for this new runlevel?
-if [ -d /etc/rc$runlevel.d ]
+if [ -d "/etc/rc$runlevel.d" ]
then
case "$runlevel" in
0|6)
@@ -150,7 +151,7 @@ then
elif [ "$previous" != N ]
then
CURLEVEL=""
- for s in /etc/rc$runlevel.d/K*
+ for s in "/etc/rc$runlevel.d/K"*
do
# Extract order value from symlink
level=${s#/etc/rc$runlevel.d/K}
@@ -161,10 +162,10 @@ then
fi
CURLEVEL=$level
SCRIPTS=""
- for i in /etc/rc$runlevel.d/K$level*
+ for i in "/etc/rc$runlevel.d/K$level"*
do
# Check if the script is there.
- [ ! -f $i ] && continue
+ [ ! -f "$i" ] && continue
#
# Find stop script in previous runlevel but
@@ -198,7 +199,7 @@ then
else
# Now run the START scripts for this runlevel.
CURLEVEL=""
- for s in /etc/rc$runlevel.d/S*
+ for s in "/etc/rc$runlevel.d/S"*
do
# Extract order value from symlink
level=${s#/etc/rc$runlevel.d/S}
@@ -209,9 +210,9 @@ then
fi
CURLEVEL=$level
SCRIPTS=""
- for i in /etc/rc$runlevel.d/S$level*
+ for i in "/etc/rc$runlevel.d/S$level"*
do
- [ ! -f $i ] && continue
+ [ ! -f "$i" ] && continue
suffix=${i#/etc/rc$runlevel.d/S[0-9][0-9]}
if [ "$previous" != N ]
@@ -252,4 +253,3 @@ fi
trap - EXIT # Disable emergency handler
exit 0
-
pgpxfsAafgDUi.pgp
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: sysvinit
Source-Version: 2.94-5
We believe that the bug you reported is fixed in the latest version of
sysvinit, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Dmitry Bogatov <[email protected]> (supplier of updated sysvinit package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sat, 11 May 2019 20:03:26 +0000
Source: sysvinit
Architecture: source
Version: 2.94-5
Distribution: experimental
Urgency: medium
Maintainer: Debian sysvinit maintainers
<[email protected]>
Changed-By: Dmitry Bogatov <[email protected]>
Closes: 670585 928249 928250 928348
Changes:
sysvinit (2.94-5) experimental; urgency=medium
.
* Split long message into several lines to avoid terminal glitches.
+ Closes: #670585
+ Thanks: Antoni Villalonga <[email protected]>
* Fix style in /etc/init.d/rc script (Closes: #928249)
* Make lsb-base hard dependency of sysv-rc (Closes: #928250)
* Error handle redirection used to truncate /var/run/wtmp
+ Closes: #928348
+ Thanks: Cristian Ionescu-Idbohrn <[email protected]>
Checksums-Sha1:
7e84aa02013a55cca84d47ac5f2be17410dfda04 2654 sysvinit_2.94-5.dsc
ff1002e8e8f18c4195b8e2bf710e40d37c152bac 127368 sysvinit_2.94-5.debian.tar.xz
02cd817fd1bd610d44032dbb24a529abb3a6806c 5655 sysvinit_2.94-5_source.buildinfo
Checksums-Sha256:
7c920a2b69fa7187bf3a07c36eb8d65b0860a335032b09911ca3809b70fa15b6 2654
sysvinit_2.94-5.dsc
8bd967564dfca17ab6339b3190f4b2c7d00f941f892cd31ea2d2f620d4be204c 127368
sysvinit_2.94-5.debian.tar.xz
f446672f6212a117245325327e3dc3b65f72614c2bb445a0d0c86facd7c5b0fd 5655
sysvinit_2.94-5_source.buildinfo
Files:
49ae8413d28e0ae61aa024cbd35db217 2654 admin optional sysvinit_2.94-5.dsc
c734529caa8c925f591e93f92f2a4f05 127368 admin optional
sysvinit_2.94-5.debian.tar.xz
90b3694dcc088f2cd07486ed2d6d281e 5655 admin optional
sysvinit_2.94-5_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJHBAEBCgAxFiEEhnHVzDbtdH7ktKj4SBLY3qgmEeYFAlzXKx0THGthY3Rpb25A
ZGViaWFuLm9yZwAKCRBIEtjeqCYR5rglD/9z01L97Gqo44VWF8sQnj9gm6LQUkbi
yK6esnL0HyQwJrzCLN+3sGr4pmwSnpjQLnspGoJaak5rUBMeKVQOEmRsdEnQsPXZ
rYc9VlYNTDheJhRPNJzKZyUYgONljtz5+Wa/pNy2WQTzJ7mPtvrTW+1TVudIyYGW
fWb8tB+AgfxRNTSe2enWoy/+fM2siBI4NVXd+MHbirky6t/d5Uo158DTBL0k/gwC
lvERRoNZV+sqXU2HrdRJsR1fCdxYdKuo1Z0YwDw4z9VQacwLwbQanZMkGJ7ukEjY
0Fz9amluomvzZt/UrGD0GhSGMDQ16Vvp4YZZ5pAAgrulhDhss1GlumZPONiZfrKZ
Nf211NTEr31YmWdwJeU/EkEOSjGth/EjfNHEcS7hW1vgZJKatvQXQ4/fuTUG683Y
yiaJwS6OLcxk41V4t+HIr7uzCBDncH1BzGs7dQOFfC6Mkdua1Ynbei7LFHtbfSV3
S+n34YjC+9um4elk+K7bYznjw88i8f4pjzJslO3qCav0bGkI2+jYwXVU6JuMf3jT
EvvD7ZWdJvnXVgf4b+9Nry7oiDTZ7RdYxONhYupzKXqgT7qQRmX7LPnSu1qMBag3
v4hizTXtfcu7LUSog3BtTY3EoqiTb72l06coLgstOaoUhR0BLndwpKoPrVxLjLBS
vwJ8WQieNzdcBg==
=hrnR
-----END PGP SIGNATURE-----
--- End Message ---
