Your message dated Sun, 16 Apr 2006 14:02:27 -0700 with message-id <[EMAIL PROTECTED]> and subject line Bug#327404: fixed in devscripts 2.9.17 has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what I am talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Debian bug tracking system administrator (administrator, Debian Bugs database)
--- Begin Message ---Package: uscan Severity: wishlist Tags: patch If a HREF contains HTML entities (most commonly "&") or no filename can be extracted with basename(), uscan fails to download the file. I suggest to add a new option "localfilename" which can override $newfile_base. The patch I've attached, adds this option, so something like this is possible: # # HREF=http://foo.bar.org/download/?path=&download=foo-0.1.1.tar.gz # version=4 opts=localfilename=s/.*=(.*)/$1/ \ http://foo.bar.org/download/ \?path=&download=foo-(.*).tar.gz The localfilename-option behaves just like uversionmangle and dversionmangle. It may be possible, that the HREF does not contain a filename at all. In this case, something like this can be done: # # HREF=http://foo.bar.org/download/?path=&download_version=0.1.1 # version=4 opts=localfilename=s/.*/download.tar.gz/ \ http://foo.bar.org/download/ \?path=&download_version=(.*) This will always save the download as download.tar.gz. In both of the above examples, "&" has to be replaced by "&" before starting the download (see attached patch). -- System Information: Debian Release: testing/unstable APT prefers testing APT policy: (500, 'testing') Architecture: i386 (i686) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.11-1-k7 Locale: [EMAIL PROTECTED], [EMAIL PROTECTED] (charmap=ISO-8859-15)--- uscan 2005-08-04 04:15:22.000000000 +0200 +++ uscan-neu 2005-09-09 23:24:41.000000000 +0200 @@ -43,7 +43,7 @@ } } } -my $CURRENT_WATCHFILE_VERSION = 3; +my $CURRENT_WATCHFILE_VERSION = 4; my $progname = basename($0); my $modified_conf_msg; @@ -627,6 +627,9 @@ elsif ($opt =~ /^dversionmangle\s*=\s*(.+)/) { @{$options{'dversionmangle'}} = split /;/, $1; } + elsif ($opt =~ /^localfilename\s*=\s*(.+)/) { + @{$options{'localfilename'}} = split /;/, $1; + } else { warn "$progname warning: unrecognised option $opt\n"; } @@ -807,6 +810,13 @@ } my $newfile_base=basename($newfile); + if (exists $options{'localfilename'}) + { + $newfile_base=$newfile; + } + foreach my $pat (@{$options{'localfilename'}}) { + eval "\$newfile_base =~ $pat;"; + } # Remove HTTP header trash if ($site =~ m%^http://%) { @@ -921,6 +931,11 @@ # Download newer package if ($upstream_url =~ m%^http://%) { print STDERR "$progname debug: requesting URL $upstream_url\n" if $debug; + + # substitute HTML entities + # TODO: anything else than "&" required? + $upstream_url =~ s/&/&/; + $request = HTTP::Request->new('GET', $upstream_url); $response = $user_agent->request($request, "../$newfile_base"); if (! $response->is_success) {
signature.asc
Description: OpenPGP digital signature
--- End Message ---
--- Begin Message ---Source: devscripts Source-Version: 2.9.17 We believe that the bug you reported is fixed in the latest version of devscripts, which is due to be installed in the Debian FTP archive: devscripts_2.9.17.dsc to pool/main/d/devscripts/devscripts_2.9.17.dsc devscripts_2.9.17.tar.gz to pool/main/d/devscripts/devscripts_2.9.17.tar.gz devscripts_2.9.17_i386.deb to pool/main/d/devscripts/devscripts_2.9.17_i386.deb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [EMAIL PROTECTED], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Julian Gilbey <[EMAIL PROTECTED]> (supplier of updated devscripts package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [EMAIL PROTECTED]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.7 Date: Sun, 16 Apr 2006 19:43:15 +0100 Source: devscripts Binary: devscripts Architecture: source i386 Version: 2.9.17 Distribution: unstable Urgency: low Maintainer: Julian Gilbey <[EMAIL PROTECTED]> Changed-By: Julian Gilbey <[EMAIL PROTECTED]> Description: devscripts - Scripts to make the life of a Debian Package maintainer easier Closes: 203781 218222 226947 230702 262525 293715 309362 327404 347809 350455 355505 356959 358278 360027 360783 360857 360995 361029 361319 361877 361979 362187 362202 Changes: devscripts (2.9.17) unstable; urgency=low . [ Julian Gilbey ] * several Perl scripts: make sure we set the SIGPIPE handler before doing an open '-|' * bts: actually support the --sendmail option rather than just say we do! (Closes: #293715) * bts: fix URI in manpage (Closes: #360783) * bts: fix unblock NNNNN by|with NNNNN handling (Closes: #361029) * bts: fix uninitialized value bugs (Closes: #362187) * debchange: add --qa option (Closes: #358278) * debdiff: check file permissions and new/deleted control files (Closes: #203781, #230702) * debdiff: option --controlfiles to allow comparing postinst etc. (Closes: #218222) * debrelease, debc, debi: support searching for .changes and .debs in a directory other than the parent of the currnent source directory with --debs-dir command line and DEBRELEASE_DEBS_DIR configuration file options (Closes: #309362) * debuild: emulate dpkg-buildpackage rather than call it (unless dpkg-cross is installed); this provides a hook facility (Closes: #226947) * debuild: complains if debian revision in native version (Closes: #262525) * dget: fix manpage type (Closes: #361877) * mass-bug: new script (Closes: #355505) * pts-subscribe: fix config boilerplate to actually set default timeout (Closes: #360857) * pts-subscribe.1: improve the wording of the manpage (Closes: #360027) * svnpath: fix svk info error (Closes: #361979) * uscan: *really* fix the uninitialized value bug (Closes: #356959, #361319) * uscan: provide downloadurlmangle and filenamemangle options to mangle the URL and filename before attempting to perform and save the download respectively (Closes: #327404) * uscan: fix manpage typo (dversionmangle) (Closes: #362202) * uscan: provide "versionmangle" option which does both {u,d}versionmangle (Closes: #350455) * uupdate: correct syntax error (Closes: #360995) * who-uploads: new script to determine most recent uploaders of a package to the Debian archive (Closes: #347809) . [ Joey Hess ] * dd-list: actually support white-space separate pages names from stdin, as documented on man page. * rmadison: escape "+" in package names in http query string Files: 706b13a31aa3cf17f2e708fe2980ec40 693 devel optional devscripts_2.9.17.dsc 48808bec47c2d580536e757fbe2b04c1 364624 devel optional devscripts_2.9.17.tar.gz 322bfd170fe4f9b0c6c278d3c3b26466 336272 devel optional devscripts_2.9.17_i386.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (GNU/Linux) iD8DBQFEQpiQDU59w/205FkRAvWeAKDbLMdS4JMoV/PDIzM5CCh1Vl5tUgCgmFGX sJY52JGZcB6vxdCH9HDe6Oo= =9ysd -----END PGP SIGNATURE-----
--- End Message ---
